From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E02E0A04DD; Fri, 20 Nov 2020 11:51:18 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9D2E5C8DC; Fri, 20 Nov 2020 11:51:16 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 939E6C8B6 for ; Fri, 20 Nov 2020 11:51:13 +0100 (CET) IronPort-SDR: 8ovMHk2i9sWrHKUgLGoJmJiMJMp9h0ukZfwCBaPUnVASx4+YxmDlbPm7JXksXIRAkb8HB04VGM vk1pTQxERQjw== X-IronPort-AV: E=McAfee;i="6000,8403,9810"; a="256162108" X-IronPort-AV: E=Sophos;i="5.78,356,1599548400"; d="scan'208";a="256162108" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Nov 2020 02:51:12 -0800 IronPort-SDR: 4lFhrkSl8IXaYXBqyMj1+sAuc5ZW5hRm+ovmo89s0LpCa/h7He9H5KhPWkntLJLcMCIHjmH14t /VSXj9OCulJQ== X-IronPort-AV: E=Sophos;i="5.78,356,1599548400"; d="scan'208";a="477180972" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.18.192]) ([10.252.18.192]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Nov 2020 02:51:10 -0800 To: Thomas Monjalon , Raslan Darawsheh , matan@nvidia.com Cc: viacheslavo@nvidia.com, =?UTF-8?Q?Beno=c3=aet_Ganne?= , dev@dpdk.org References: <20200327172449.6514-1-bganne@cisco.com> <20201119142018.25277-1-rasland@nvidia.com> <77998079-5ad7-edc4-1153-c318e11c25d0@intel.com> <6072180.DC7U9P3PlK@thomas> From: Ferruh Yigit Message-ID: Date: Fri, 20 Nov 2020 10:51:06 +0000 MIME-Version: 1.0 In-Reply-To: <6072180.DC7U9P3PlK@thomas> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: fix link state update X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/19/2020 6:42 PM, Thomas Monjalon wrote: > 19/11/2020 18:48, Ferruh Yigit: >> On 11/19/2020 2:20 PM, Raslan Darawsheh wrote: >>> From: Benoît Ganne >>> >>> mlx5 PMD refuses to update link state if link speed is defined but >>> status is down or if link speed is undefined but status is up, even if >>> the ioctl() succeeded. >>> This prevents application to detect link up/down event, especially when >>> the link speed is not correctly detected. >>> As link speed is nice to have whereas link status is mandatory for >>> operations, always update link state regardless of link speed. The >>> application can then check link speed if needs be. >>> >> >> Hi Raslan, Matan, >> >> Can you please provide the Fixes tag? Also should this fix backported? > > I think it should not be backported because it is a behaviour change > relying on API doc change. > As far as I understand, API change you mention is making 'ETH_SPEED_NUM_UNKNOWN' speed value a valid value return value. Commit log doesn't give the context that it relies on an ethdev behavior change, it sounds like it is fixing behavior in the driver, it is not possible to figure out the relation without digging the mail list discussions. It would be nice to update the commit log to give more details, I think problem is clear but can good to add why the check was there at first place and why it can be removed now, etc.. Btw with LTS, with the faulty kernel driver, PMD still won't able to get link speed which will prevent returning link status. Or is the kernel driver fixed and no need to worry about this anymore?