From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 86900423B9; Thu, 12 Jan 2023 18:03:43 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6F74F42D55; Thu, 12 Jan 2023 18:03:43 +0100 (CET) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2048.outbound.protection.outlook.com [40.107.237.48]) by mails.dpdk.org (Postfix) with ESMTP id 129F042D4F for ; Thu, 12 Jan 2023 18:03:42 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SSMYDlOTCKWCG6YOA28ozdnU0MRzK6RVEsELPBMKZyR0bPx/8aUAaczFLa3H5xtKXpmxisSsxE6Lsrt4u54VVmGij+GyxjyXtymvlq6Rr+Mu/YMGMFyNDwAX7At/G1UbWxJjtswXMZGzFQ1xZOPDGw3Q3d/gMRZ24uTJZYuyi0Oz7wlti1/Ej+1pSfrtZtG/gRRCVAQtQnWZTfDZA32WY6huBmPqOoyxL/JPJT671WneIiOQce6rp5L+TjIAYzOtGP5EJNJUBU4Zpn9YbOTBHy2mYq0QxflO/piNyCagwuCD2VCztdsFckBHRfcVr9xGKuF5KciZxF2UyKpHFHFWSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NNpU9U6n4nlkDRgNdcHFAsg7r/cy27GJrTDFMv3qiik=; b=cQ4UYnJSgRidUeWRiNVc2zmIQ7xgdVGolQiFveHO6doQKBkHHj3TF4RvhlHzEVbHrTwxG6aISukeykOXPX/QlRw/NM13i+e7UGIoNL9qLZMHk9GNdH7RS35BEVyNYom/PMnBzm8IY9rwJKqalKO9E1CTpP1AdaB/fJsRFsBdBg0W2flccyFjnP3mKxZGP+I+XsGj88sML/wXFUjmY2Z2PwcfWXjO1/MFIHql2fwTPkcLYNZN96UCJMTeSAqltBnTL8Cwj020hT0LxHG48XHmWurTCOaFOLcn7C/KHj3/u5Mtn9W5F3dFx4oKBj3XqU7RLSYE7diis7rpoDfLsLCtCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NNpU9U6n4nlkDRgNdcHFAsg7r/cy27GJrTDFMv3qiik=; b=TKIz76uZyM7SZ6W1EXXuezRT08FoG8kbKqMoj0VQGOk1wtdcoCv7FY+nXQpnHvuC6viBq/tTyQtkP/348vIq/6iCSWNYdIsFyzKsT6OcQ6MorpaLm5GsKd/rk5CySMul3PVakwocW6tldYyPWvtx8YgFCSEzKHwBzXhDePHclxk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DM6PR12MB4089.namprd12.prod.outlook.com (2603:10b6:5:213::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Thu, 12 Jan 2023 17:03:39 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::4807:1f44:5e04:e05a]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::4807:1f44:5e04:e05a%9]) with mapi id 15.20.5986.019; Thu, 12 Jan 2023 17:03:39 +0000 Message-ID: Date: Thu, 12 Jan 2023 17:03:23 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v5 0/6] add trace points in ethdev library Content-Language: en-US To: Ankur Dwivedi , dev@dpdk.org Cc: thomas@monjalon.net, david.marchand@redhat.com, mdr@ashroe.eu, orika@nvidia.com, chas3@att.com, humin29@huawei.com, linville@tuxdriver.com, ciara.loftus@intel.com, qi.z.zhang@intel.com, mw@semihalf.com, mk@semihalf.com, shaibran@amazon.com, evgenys@amazon.com, igorch@amazon.com, chandu@amd.com, irusskikh@marvell.com, shepard.siegel@atomicrules.com, ed.czeck@atomicrules.com, john.miller@atomicrules.com, ajit.khaparde@broadcom.com, somnath.kotur@broadcom.com, jerinj@marvell.com, mczekaj@marvell.com, sthotton@marvell.com, srinivasan@marvell.com, hkalra@marvell.com, rahul.lakkireddy@chelsio.com, johndale@cisco.com, hyonkim@cisco.com, liudongdong3@huawei.com, yisen.zhuang@huawei.com, xuanziyang2@huawei.com, cloud.wangxiaoyun@huawei.com, zhouguoyang@huawei.com, simei.su@intel.com, wenjun1.wu@intel.com, qiming.yang@intel.com, Yuying.Zhang@intel.com, beilei.xing@intel.com, xiao.w.wang@intel.com, jingjing.wu@intel.com, junfeng.guo@intel.com, rosen.xu@intel.com, ndabilpuram@marvell.com, kirankumark@marvell.com, skori@marvell.com, skoteshwar@marvell.com, lironh@marvell.com, zr@semihalf.com, radhac@marvell.com, vburru@marvell.com, sedara@marvell.com, matan@nvidia.com, viacheslavo@nvidia.com, longli@microsoft.com, spinler@cesnet.cz, chaoyong.he@corigine.com, niklas.soderlund@corigine.com, hemant.agrawal@nxp.com, sachin.saxena@oss.nxp.com, g.singh@nxp.com, apeksha.gupta@nxp.com, sachin.saxena@nxp.com, aboyer@pensando.io, rmody@marvell.com, shshaikh@marvell.com, dsinghrawat@marvell.com, andrew.rybchenko@oktetlabs.ru, jiawenwu@trustnetic.com, jianwang@trustnetic.com, jbehrens@vmware.com, maxime.coquelin@redhat.com, chenbo.xia@intel.com, steven.webster@windriver.com, matt.peters@windriver.com, bruce.richardson@intel.com, mtetsuyah@gmail.com, grive@u256.net, jasvinder.singh@intel.com, cristian.dumitrescu@intel.com, jgrajcia@cisco.com, mb@smartsharesystems.com References: <20221222063306.3383695-1-adwivedi@marvell.com> <20230112112140.807233-1-adwivedi@marvell.com> From: Ferruh Yigit In-Reply-To: <20230112112140.807233-1-adwivedi@marvell.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0441.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a9::14) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DM6PR12MB4089:EE_ X-MS-Office365-Filtering-Correlation-Id: 9a0ed774-2599-4941-caf5-08daf4bef323 X-LD-Processed: 3dd8961f-e488-4e60-8e11-a82d994e183d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2SlJFI2sOQ/agUk80Bg83PknqLscD9rQsKnw0fBxMT2DH+BHa94iO+hFhwgGKFThji8UzOYI/V0OsHw4BHVEqpJ4cyXO1qlBNqV5frrJbAlTnapY4RMfwr8/huAL8xf9MbJ+cgqNbMazFObXlsTZgR3l5auxC8idvMIaE43UU7LKVzcp9gNo/WprGR/+nNsOMy70XKPOeeU4pbvW9wlZej/i1BnFM4l4L+YphNwA8rCvG+urQvXcHMXZV9S0vnAAVE3ncuUz09gssZHfB3QclZJrb9KvcYIheKh769zesR5owxZzlx0rNge+K62AtruWFPqPXg2vi6IhOpQXmRbXZ0MZu84OFndE5K4Q4h4N4uAyDuBeV8nJVBPozUO+7nOY0Z+KhxB+qOpMNPWq02+2FgS77mINjp4LU/Oeh3LAppPgX3fi8BMrIIclX2RjGlUDab5QmLLC9IwECDnHLtgmu7xhtiOJQcg/XTWiD2BkI4J0ewJ4XT7OJ7uDBUbowDEKP6pMS7cMCa3TafIaQQYgnuF0/eVDMH/NKURTFR8sujFSBJ/BJcNkaXES/9ZtumktXflw3kqm/tzcNUpW74CdnJdDXqUbdF+TEAq+M6V4OMXWD/rezX5kE+icoPi8n5ZFpFbuqH9Vd4TPFX9aEF3zmvSseCAswAa2ActnyJJYiAq3JF45nkAXjMkbeDoY2trzw+JYDUWd5VWmK/m7whuD3Sn7nPJm1ggbiZoBuBBOYdaoGzhDyeLF0CXCyfz+bi70 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(346002)(136003)(366004)(396003)(376002)(39860400002)(451199015)(31686004)(66556008)(44832011)(2906002)(7416002)(7336002)(7366002)(5660300002)(7406005)(36756003)(8936002)(6666004)(66946007)(41300700001)(8676002)(66476007)(2616005)(316002)(4326008)(53546011)(6486002)(478600001)(6506007)(26005)(6512007)(186003)(966005)(31696002)(83380400001)(86362001)(38100700002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dUtYeFlQVHp2SG9LUy9zckRrU1NIQmE5Wk9XaElucldwV1VCZ1B3S0lhY3BE?= =?utf-8?B?R0hRQVNUa3l3ZE9OeWFMVjYxQTZ3SGRpUlF0eGgyU1d2bzdyNFhOQmZPYUNx?= =?utf-8?B?eFpXSytXZ2NFOGVOaDA3QmFEd3c2NEpkeHlQRGlLd09JdGJTeFN5c1RBSmxr?= =?utf-8?B?L2U1ZzRVb21Gc3pvb0JxS3hRN1dDVzE4ZUtiK3BsOXUzUXBwdFZFemtjNzdP?= =?utf-8?B?OUgwMklWZjlPamFkNGFEaFo2NHZiU0hPWFM3aEw5S0R4OXJ4azY2ZTZpdnc5?= =?utf-8?B?NGUrRHh1N3lBVVVKM0lkeG1QdUtlWDdYb29ueDdzOTBvOTFqak1NWTg2b0lF?= =?utf-8?B?MUxiZmtjbDI3RGY1emdHN2VwdVpNdmRPd21Zd1JTVVVWZ3NuR21lbDRLakU5?= =?utf-8?B?aFl6dDRLb0srdHRkdmlMM0dsMUs4N2trMlhZMUVkUXpOY2xocVRIMXJoY0pz?= =?utf-8?B?V2dnL01JT2JHQ01QYkF5bUYzbVh6SC8yTkRjNzhHRHhZNi9XUHozZXdBUGIy?= =?utf-8?B?Z0pIZzVLL3gveVVoYzF2dlZ3aDZJZUZZVFlwN3h5U0RzUFpHYWdNanhwakt5?= =?utf-8?B?eHlqZWJQdkMzQndGZG5pbjg0eUV4Mmh4c05pcFBDL3VUeHFkM3dPKzA1Y2E4?= =?utf-8?B?eDgyV05DNHNRZnc2dVcxUHdLVW1pWVoxcGNlMW93eS9VNlh5eDJKazhxNHA1?= =?utf-8?B?djFBREZ2NU8wcmtvalQvZFRqUU5ZMWFBTHRHVUtRMkcweHpyN2RYYmtSVEV3?= =?utf-8?B?RVFZaHRLWmh2QU9FNTlRZmo5UGhZamlVNCtKM0Z2VSs5ZDdOY2lmZTc4RHBC?= =?utf-8?B?WEVoWi9weERXTmFEZnpsM0hkbys5bDlnL0hCSEhoMW5TbXZkcTVKRzcrV0Vn?= =?utf-8?B?Tko3SGtwVS9BaXowL1dMNFFnTitBQWVGb0JGbEtacVBEa1RVeUZxZm01ZnZC?= =?utf-8?B?KzQ4M3RTN1JzaHJITjlFMndZd01rNTlSN080Vk5QVElLck05dWlSVHFyVEVT?= =?utf-8?B?QmE0dzA4b212aElOcXdBS1hjMnZVQ1FLeWhqSE9TbDI3dUtFR1hOVmt2R0Nn?= =?utf-8?B?WkphaU83OWZFdUVuUkNzQVZyWkdFRytYRm1HREx2c3BFZE4zZkxxNHM1aGpF?= =?utf-8?B?QmJqaVQwUHJlTWVwN3NPazhIMzdhcVN5ZlRlL1hQcEp5T0k1bFZYdXk5QWty?= =?utf-8?B?MS8wWkdaVWh3UXlGLzcvZ3gxelFLMi9JQVhDSjZxRlVtLzk0TVpleUQ2MXdO?= =?utf-8?B?alZzbkoyQnlPYS9mdU1lYUxQMzVDWDg2VGc3b2kwZDN1K0FEWktFN2VvZXFl?= =?utf-8?B?eENjeGY1WDRGZkFQVS9PdHo0TXo1Z2t0eTFBS2c2YitCc3BQaVU2TFVmdGdS?= =?utf-8?B?SGF3K3lqY2NDemczSjhaY1dhT1k3M3dLS1pqMXoyTEFoS29xY215R3pSQkkw?= =?utf-8?B?UVYxZ3BFQk9mTmxkVm04MEJqUVB2RGZNRXhxVk1vYzd2QlpnOXFzQkd4bjJj?= =?utf-8?B?U20zRWZnUS94RlZxTDN2RVdvbW5sVmsyd2ROV3JWcEk0cUg1cmN5Q0c2cG94?= =?utf-8?B?T2grbWJqVmV4akJLVVZOYUJ2UEFwZTE2VnNFRjhjN3FFaW4zc1ltMXl3UGxJ?= =?utf-8?B?TE96ZU1hYndiY3JLUDZPeUxySTVSMVF5cWhXdTVScVQvL1Uxa25GbEFsQThB?= =?utf-8?B?ZmpMUllFNmM0UzVGdGxMOE12TFFkcFJlU0d0dFYvcmt5YU9oSVN4RGNlQjVL?= =?utf-8?B?SmYvMW1WcS9rYW5POTZhZ3puV0JkM3ZTWnk3SmdhSHZ6b2FPWFpVWU15V2JM?= =?utf-8?B?YjI3SFR4REY0TEpRL1dMaWJoRFNxbkRzcGNZMFBEb1M0dmZjZnFyLzUzVXZq?= =?utf-8?B?R2VjajJjenZIcEhzRThFaDNUcDJBSTZEa3hXL2ZBcTdDQW1POUI2OHNwQkxt?= =?utf-8?B?c3BFUmRxdVh2RjdObzhudjJFWkNLd2VEeTUxYm1LNXlIWFZqZjNHR29JSXNR?= =?utf-8?B?c3NvVm1ySVlzNkZuVU5xRkNUSklCNDlLZDNzam1OYnladzc0OUZNMEV1cE9n?= =?utf-8?B?YyswaU85V1RwN1duUjAxKzhBbkkwenduYkpwY2tyNCtJQUFVYWVnejFIeHNE?= =?utf-8?Q?fSDd8DbzpDo3TlP2BaXQKibP0?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9a0ed774-2599-4941-caf5-08daf4bef323 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2023 17:03:39.0893 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bEq4U7SvYfVi/+K5LzBddhZKPlIawxS4tySY6PGxDPsbw2xLmGAe6RVn51dEC1db X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4089 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/12/2023 11:21 AM, Ankur Dwivedi wrote: > This series adds trace points for functions in the ethdev library. > The trace points are added in ethdev, flow, mtr and tm files. > > v5: > - The rte_trace_point_emit_char_array function is renamed to > rte_trace_point_emit_blob. With this function an array of > any length upto 65535 bytes can be captured. > For example, the following is the ctf metadata created to display > a mac addr array in rte_eth_trace_macaddr_get(): > struct { > ... > uint16_t len; > uint8_t mac_addr_addr_bytes[len]; > }; > - Added additional test cases for rte_eal_trace_generic_blob > test case. > - Capturing of return value of a function is added to tracepoint > for flow, mtr and tm patches. > - In ehdev patch (1/6), removed extra line. Also added rx_pkts and > tx_pkts pointer in trace point. > > v4: > - Adds tracepoint function to emit char array. Also adds the > test case. > - Resolved review comments on "ethdev: add trace point" patch. > This patch is divided into 2 patches to minimize per patch > size. > - From the earlier version (v3), few tracepoints in ethdev, > flow, mtr, tm are made as fast path tracepoints. For the > tracepoint which i was unsure, i have made it as fastpath. > All the fast path tracepoints can be found in > rte_ethdev_trace_fp.h and rte_ethdev_trace_fp_burst.h. > All the slow path tracepoints can be found in rte_ethdev_trace.h. > - Capturing of return value is added to tracepoint in ethdev. > For flow, mtr and tm these changes are still yet to bde done. > Will do it in the next versions. > - Moved the trace functions from INTERNAL to EXPERIMENTAL in > version.map. > > v3: > - Moved the trace functions from EXPERIMENTAL to INTERNAL in > version.map. > - Moved trace functions call to the end, in ethdev and flow trace. > - Added code to print the input value of features in > rte_eth_trace_rx_metadata_negotiate(). > - Added code to capture return value in flow trace. > > Ankur Dwivedi (6): > eal: trace: add trace point emit for blob > ethdev: add trace points for ethdev > ethdev: add trace points for remaining functions > ethdev: add trace points for flow > ethdev: add trace points for mtr > ethdev: add trace points for tm Hi Ankur, Build seems failing with set, can you please check: https://mails.dpdk.org/archives/test-report/2023-January/339696.html I can reproduce build failures via 32bit and debugoptimized builds.