From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D47FEA0547; Tue, 26 Oct 2021 18:16:47 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9CB0E410D5; Tue, 26 Oct 2021 18:16:47 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 2955F40E0F for ; Tue, 26 Oct 2021 18:16:45 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10149"; a="290790118" X-IronPort-AV: E=Sophos;i="5.87,184,1631602800"; d="scan'208";a="290790118" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2021 09:15:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,184,1631602800"; d="scan'208";a="494264631" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga007.fm.intel.com with ESMTP; 26 Oct 2021 09:15:59 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 26 Oct 2021 09:15:58 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 26 Oct 2021 09:15:58 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.169) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 26 Oct 2021 09:15:58 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K+ldDhEV/xHarFTxQuEu6qmKe+1WYAPxrLVlmek7AnXakVVDU4mjcJk0wX4UBDs1chbjqBdJVLazv9bfrD3srICyD9RWy8jQNpaf9LbrP47+ig6VWmje9RdBG83Eo5aoLE2sRhCSZczErCs1KZsZa4a0fpdS59lT4WTinCjH78pBCgC45cD57I+EhZ1QzDU7nE4uu8zg0itv+oXW8UuvWRjqrcPkOGwCCaR3zsC4WzXhz28uqdQfSEGfxSTaMHX4zyV9wNQKeLOpSl6RB0cTsKrucwN+ywVmHWpN1GmiBnDzla6uVW5Ku/i5l7m+q9zd1yTgb+4MZToWod7XRhnfsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IfswrDuUcEdP09BcHsXcrUYRHPghy4RUPFmbLxNVdNA=; b=E+fNZrNno4vO8ylYKx/egPN7w1M05e+MEp87qtmNDtNjBEGJkMjxEmIarUrIp2rS1A5SEOVzMUgRU1XOtp2oCSqwb4GVcCR9Ixc6RtSKu5/NtP/qpluUr2nDVZOHDJBuBjgz2TurwTEeXD3DVOdeXdZt2IJyaf58lljaTDwCZ6s288VuG/bTf6fe8PrCAG2nnVYE/fOJ6e+enCnuEf0PwUnIGqoEcapQucZLdlU9I4ANiNSer8r3WF9gFPLWguCPaIQ5u3ARgbI/44KjfZevSo9uK0ABEVcmUGY08i5F1qvkJnStBTTZIV0Jx6og+h7M43QkT8cuElkEOTG5G0Sa8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IfswrDuUcEdP09BcHsXcrUYRHPghy4RUPFmbLxNVdNA=; b=d3RQZ/vlT0t8EbBndErdC0BxlYl1WcpN4HoVgEtapYg+SQas3sbjfRYItR2/XsxjKVCgTopmQjKWIy7qi2EttTWGaalgoHKyvh+bt8MPxvugAm4YPgAc5IinpbCafDxDyxcJ/DG9hFFawYn61LMgIN+nZUEkt0eNnQEolXbic4Y= Authentication-Results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5206.namprd11.prod.outlook.com (2603:10b6:510:3f::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18; Tue, 26 Oct 2021 16:15:57 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%6]) with mapi id 15.20.4628.020; Tue, 26 Oct 2021 16:15:57 +0000 Message-ID: Date: Tue, 26 Oct 2021 17:15:49 +0100 Content-Language: en-US To: Thomas Monjalon , Ivan Malov CC: David Marchand , dev , "Andrew Rybchenko" , Ori Kam , Xiaoyun Li , Ray Kinsella References: <20211005003604.31684-1-ivan.malov@oktetlabs.ru> <52ec19b3-8765-ff61-1e29-3f0073ec0c17@oktetlabs.ru> <2396318.f23G9BEs4G@thomas> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <2396318.f23G9BEs4G@thomas> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB8PR06CA0022.eurprd06.prod.outlook.com (2603:10a6:10:100::35) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB8PR06CA0022.eurprd06.prod.outlook.com (2603:10a6:10:100::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18 via Frontend Transport; Tue, 26 Oct 2021 16:15:54 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fbc49960-ddf0-4b5e-2ba6-08d9989be477 X-MS-TrafficTypeDiagnostic: PH0PR11MB5206: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UoLomEhRm3cFIXiVgrvAjrWs/hu+nd7yxg4MYgjJNQBs3w6ez9KPOnvbkEgE0veXCLEJNozK7I97lmO/W0rHTiWSONEp1ulU9X6JI01SsatcHyvVU8Lc7WGPzc+ObM5uhvyuyGIEeFC+yG7Y7P0KPyxCIAw2iWqJMAxo71qnL1nVlNA97u2RpgM0swL1vsOqv5zdy1UPWjnNyxeCLuAtj+YSPBC1LIQzr/kqWg3ToL/B90tthIH4QJ56OWITQKjM8xg0O1uAGHswVcWE8A1UdBuxI0zsgIIuNCeWmpjgHx73GfQ1MJlBjDLIsO6uEmcbE9/C4SCxiACJDzRzmN/AfvjCGHNx/9bE+07XiP5PsNOiZ/aBoUJuEtz8yMNc4rTZdF/06BMNyYosMK3GO5+RCC/tQNa7N6rd3zD7y4BS6i4aOtOd9v1t/3ASiIV/0ZPpLZCI+zHUgSjW+2QTWMMLChXUccHlJnnWWNiujRwMPiaV02d+V94KTJ3Dpt627pxe1ttYI2JkpFN7mzkLQXTb+1/5lyY6/n+dzuJeFERuNrDbfxzj8A0jwC70Pi5w459f0sxicqdWNKJqrCJ8BjOo9GNfsc7FwJX3qDM3ckf3VXK3YPM8ScsdT11GJuJWYswtuIQbhC3C90acbpQX50frKXCXIug0fckwdiXtxTwY//nZ3VXPZCWro91VY1n2TGOfEpY6xoS7IW5bIquHJPX8eXaEWqpI6x2DKbXHLB9spjWAj1CaBdu3p471Q15rYhuZ8Bz3F0KV4buP9XLgS1OFlGB3sgftQBRh062RJ43EAHawpYRHo2ikOA8EMadwc/ZFRBe7fxMb1oWvXCTKMjQEAA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(66946007)(66556008)(82960400001)(66476007)(508600001)(8676002)(5660300002)(16576012)(6666004)(966005)(31686004)(8936002)(83380400001)(54906003)(316002)(2616005)(44832011)(31696002)(4326008)(2906002)(36756003)(956004)(6486002)(26005)(86362001)(53546011)(110136005)(186003)(38100700002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SFBMMWMwRlZxdktwZzRLTmx5cjB1c3dXVGFKWlYxVHJqZVFWMmlVM2JPcm5k?= =?utf-8?B?UmNMNEI1T1pVSisrV1VYRXEwZG5FNVUvOGk4ZEI5dHViRGxwbHJPOFNsRWxH?= =?utf-8?B?dE8xNVI4WnlTdmhSK1VQWUF6cU9Va3A2RlREU1g4UDVyRHBPbWhSby9JQWJI?= =?utf-8?B?VmZJNXVvSFBnY2ZsUkZ5cXNRV0thR1Y1dENHNzlDVDVaMzBhVVFXQ2dUNGFu?= =?utf-8?B?V1ppS20wVW52STBXWDc4ck96TkJHUmdYdDVJc0lnNytEWktlZ08xdTV0cGNm?= =?utf-8?B?YkdTRXI2K1VGZmprbmV3eklFWUNlRHMrMU5lc1ViYVE2Y2xwckxyTzd1cDk4?= =?utf-8?B?dE03bWY4UTZhQ0pHaWo1dzJSekdvV3VRYkRXK09kY0haMWJ6OXkyTXVONmZu?= =?utf-8?B?SjYrVWtYUmJRb0paLy9FamlQYjd2M3NVajJDNW1Odlc3ZVlvakh1NENTbUVU?= =?utf-8?B?T1VUQ1dmZGkrU3AySTBheUVHM2ZhT0F4ZEFjdVJOOTJlMHlrMmUrRDlteHNq?= =?utf-8?B?WTdzQU9uZlhNV0RWbEVicW9aaUFrYnpkOVhzTGpOdHBmY3RDSjdCWXgzNXdx?= =?utf-8?B?WjBDZEtKd1VvK3lZc1h3dWUwTlBzR09WWlgreWt6OW9ZdytYeXFNWW1uMFhy?= =?utf-8?B?NjdjQVhwczBMWFV4dnRrZEdBS0tlTGNTZmRnT0VrWnp4VGF2U05VNDBuNEVW?= =?utf-8?B?NnlsclZqRUs4QlFBZ0FUbUNkUnZ0aW1SWmJUSFlWZktBblZmV3hHZWIyM08y?= =?utf-8?B?dUQ0VDJRWUNFTHJsZEIwdjJ2NlplVDVlaUtFUEI1MWhWdUxScUlPbUNGMi95?= =?utf-8?B?bnlLN0tUOXBUVjBGSmRNTFVOMFg3YWYyVGpaSHF6VjdOVHAzZW8ySU52ejhl?= =?utf-8?B?TXRtNGRTeURGSVNHblp0bEZaaS9ESkRQV2ZOWU1MSS9mQzlxaVpXU1B5eWdX?= =?utf-8?B?R2F2aTllWS9WdTZjSS8yWDVCUmFHa2NGWUptM1hMdk40ZjRqWFE5QzZjSFdU?= =?utf-8?B?clloWkVrSkdjanhWWHlPcGhyemNZN2UwekozTXdRY2hFbkZ1d0RpTk5WaGV4?= =?utf-8?B?MVE4QUErczBBZERMMng5N3piS1lEK1hjRWRDOGxQaEJlaEd3STVSc0RsZ1FF?= =?utf-8?B?bWNodVBQbTR4V2plUXYrbnVsUzlIaXo4RzhUSm5FZzF0ZkF4bStzbFp4eXFw?= =?utf-8?B?MUwvSXNaS3VGcnBjNTNkd1piZ3gxV1hTQ05Jczkzclo3WjVQT3pCTXBwY1Jk?= =?utf-8?B?WXllOE8zdmVodVV3M29UUEFFRXQwM0hwV0VBUFJ1Y3N3dFNZK05LdWUvcGs5?= =?utf-8?B?c2s1ZVA2Q1NGZVFwbGE2Kzc3bXpQTzZUUHNvdFdENjBOSE5qK256VFdXQmNE?= =?utf-8?B?cXdZUlgyOVN2SWlhdW5ycEJGOTFRSEo3Tk9iNk54TWgrQVdIWk04b3VqRFlv?= =?utf-8?B?MHZjSU9Pa3FmSzc3ZHFnTDcraVlBRGROblo0UFNFOFh6ZmwxaktwVWJFVTFh?= =?utf-8?B?WUFOV0VvcCtHbDFPeUhKUnRQWmRUUm9XNW0xeFY4RzVjZzVUeG9xQ3FFOUhK?= =?utf-8?B?bFc5MjlCek1QNEdRRGM1RUZqbTdOVzBrZXVyR2t4QjlZOWxFWWw5M2w1UCtL?= =?utf-8?B?UlY5V2U3aWlNOGdTQkFJVHhJbXUwV24weTg4NlJsMUpmQWFhK1h2YmpZUERU?= =?utf-8?B?QlVUaGRpbnh4SEZ5NkxZRFQvelVERGNQTWJPbnBVYkJsNXk0YzlyaGNFZUlS?= =?utf-8?B?V3RSRG90OUg5RktHb2o3KzJWNktkYnNPYjA3Y2lkRm9QQVREUUJOdEdXdUxU?= =?utf-8?B?c2VjQTR6RGM3WFFkUXRaN1QzVjdEK0s1U1lhRlRqczZlNlpWcWhWeWJzMXRR?= =?utf-8?B?UEpYNUhTbUtSUnl1RExpZFZPTkF2Z1VSclM2eTZobVBpWVhRQ1BML2I1Nk9U?= =?utf-8?B?K09NRzY5aTliUzVNWmcwZlJpaG10YlBkN2I5NVU2ODQwVG9mb0FNbEpRN3hH?= =?utf-8?B?Q3lqNjYrc2N2cFBDTk11WGEreTk2Y2Vnakh1dHlZeE9ZbzlBOFhyQnBiMGpu?= =?utf-8?B?cGJsQzFtdDRVRWtQOEJnb0l6TFVnazdpSlEyZXR2TE5nZGZUOXZ3Umc3SzF4?= =?utf-8?B?T1RqdURNS1NEWmJTUm5HNXY1b2UyMGR3Z2ZHVXpNelNkb3lTTVhzeWFqSTJr?= =?utf-8?Q?LAJ+X272j3jByNtFiZhOO0Y=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: fbc49960-ddf0-4b5e-2ba6-08d9989be477 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2021 16:15:57.2622 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6yRGr4lk/5pt23iigH9C/FgrKPPghyjDJ5s2PjSt1mHcDLusRJ8lAckwTSp+ojThsZZURI/JBw3h6C75iNFtCg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5206 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v4] ethdev: add API to query proxy port to manage transfer flows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/26/2021 4:58 PM, Thomas Monjalon wrote: > 26/10/2021 17:47, Ivan Malov: >> Hi David, >> >> On 26/10/2021 17:46, David Marchand wrote: >>> On Thu, Oct 14, 2021 at 5:22 AM Ivan Malov wrote: >>>> >>>> Not all DPDK ports in a given switching domain may have the >>>> privilege to manage "transfer" flows. Add an API to find a >>>> port with sufficient privileges by any port in the domain. >>>> >>>> Signed-off-by: Ivan Malov >>>> Reviewed-by: Andrew Rybchenko >>>> Acked-by: Ori Kam >>>> --- >>>> Patch series [1] has reworked support for "transfer" flows. >>>> This allows to elaborate on the idea which first appeared >>>> in RFC [2]. Hence the patch in question. >>>> >>>> net/sfc driver is going to support the new API. The >>>> corresponding patch is already in progress and will >>>> be provided in the course of this release cycle. >>>> >>>> [1] https://patches.dpdk.org/project/dpdk/list/?series=19608 >>>> [2] https://patches.dpdk.org/project/dpdk/list/?series=18737 >>>> >>> >>> [snip] >>> >>>> @@ -568,6 +568,25 @@ eth_rx_metadata_negotiate_mp(uint16_t port_id) >>>> } >>>> } >>>> >>>> +static void >>>> +flow_pick_transfer_proxy_mp(uint16_t port_id) >>>> +{ >>>> + struct rte_port *port = &ports[port_id]; >>>> + int ret; >>>> + >>>> + port->flow_transfer_proxy = port_id; >>>> + >>>> + if (!is_proc_primary()) >>>> + return; >>>> + >>>> + ret = rte_flow_pick_transfer_proxy(port_id, &port->flow_transfer_proxy, >>>> + NULL); >>>> + if (ret != 0) { >>>> + fprintf(stderr, "Error picking flow transfer proxy for port %u: %s - ignore\n", >>>> + port_id, rte_strerror(-ret)); >>>> + } >>>> +} >>> >>> I did not follow this subject, but I find it odd to get a warning >>> regardless of what is done in testpmd. >>> Like simply running a forwarding test with null pmd, I get: >> >> The API is meant to avoid returning error when the PMD does not support >> the corresponding method. However, it has to return error when the PMD >> does not support flow API at all (rte_flow_ops_get() failure). >> >> I guess, this is exactly what happens in your case. net/null does not >> support "flow_ops_get", and the API in question forwards error >> from rte_flow_ops_get(). >> >> Non-dummy PMDs should not trigger the error you see. >> >>> >>> $ ./devtools/test-null.sh >>> EAL: Detected CPU lcores: 8 >>> EAL: Detected NUMA nodes: 1 >>> EAL: Detected static linkage of DPDK >>> EAL: Multi-process socket /run/user/114840/dpdk/rte/mp_socket >>> EAL: Selected IOVA mode 'VA' >>> Interactive-mode selected >>> Auto-start selected >>> >>> vvvv >>> Error picking flow transfer proxy for port 0: Function not implemented - ignore >>> Error picking flow transfer proxy for port 1: Function not implemented - ignore >>> ^^^^ > > We should avoid such meaningless error message. +1 > Please Ivan what do you suggest? > >