From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <remy.horton@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 65D4329D6
 for <dev@dpdk.org>; Tue,  8 Nov 2016 04:19:04 +0100 (CET)
Received: from orsmga004.jf.intel.com ([10.7.209.38])
 by orsmga101.jf.intel.com with ESMTP; 07 Nov 2016 19:19:02 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.31,608,1473145200"; d="scan'208";a="28801842"
Received: from rhorton-mobl.ger.corp.intel.com (HELO [10.239.204.76])
 ([10.239.204.76])
 by orsmga004.jf.intel.com with ESMTP; 07 Nov 2016 19:19:02 -0800
To: "Pattan, Reshma" <reshma.pattan@intel.com>
References: <1478230579-4689-1-git-send-email-remy.horton@intel.com>
 <1478230579-4689-2-git-send-email-remy.horton@intel.com>
 <3AEA2BF9852C6F48A459DA490692831F010C15B0@IRSMSX109.ger.corp.intel.com>
 <3AEA2BF9852C6F48A459DA490692831F010C1A9E@IRSMSX109.ger.corp.intel.com>
Cc: dev@dpdk.org
From: Remy Horton <remy.horton@intel.com>
Organization: Intel Shannon Limited
Message-ID: <c5fa9664-deb7-9aaa-2bea-5b60392797d2@intel.com>
Date: Tue, 8 Nov 2016 11:19:00 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.1.1
MIME-Version: 1.0
In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F010C1A9E@IRSMSX109.ger.corp.intel.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v3 1/3] lib: add information metrics library
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Nov 2016 03:19:04 -0000


On 07/11/2016 23:25, Pattan, Reshma wrote:
[..]
>>> + * Initialises statistic module. This only has to be explicitly
>>> +called
>>
>> Typo < Initialises>
>
> To avoid confusion, here I mean to say "Initializes" should be used (i.e. US English) .

Sorta guessed that.. :)


> Also another non-related comment, you may need to add a comment about EMWA
> near the mean bit rate calculation code.

Quite a few comments needed updating. Going to hold off the v5 until 
16.11 is out as I'll also need to change all the references to 17.02..

..Remy