From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id D4A0A2BA1;
 Thu, 29 Sep 2016 10:15:26 +0200 (CEST)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by fmsmga105.fm.intel.com with ESMTP; 29 Sep 2016 01:15:25 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.30,414,1470726000"; d="scan'208";a="767111148"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.221.7])
 ([10.237.221.7])
 by FMSMGA003.fm.intel.com with ESMTP; 29 Sep 2016 01:15:26 -0700
To: "John W. Linville" <linville@tuxdriver.com>, dev@dpdk.org
References: <1475090404-20707-1-git-send-email-linville@tuxdriver.com>
 <1475090404-20707-4-git-send-email-linville@tuxdriver.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dpdk stable <stable@dpdk.org>
Message-ID: <c5fd0eef-ffa3-abb1-7bae-4a87c9409c83@intel.com>
Date: Thu, 29 Sep 2016 09:15:24 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.3.0
MIME-Version: 1.0
In-Reply-To: <1475090404-20707-4-git-send-email-linville@tuxdriver.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH 3/4] i40e_vsi_release: do not use vsi until
 after NULL check
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Sep 2016 08:15:27 -0000

On 9/28/2016 8:20 PM, John W. Linville wrote:
> Coverity: 127556
> 
> Signed-off-by: John W. Linville <linville@tuxdriver.com>

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>


a few minor nits:
- patch subject tag/label should be "net/<driver>: ", so patch subject:
"net/i40e: do not use VSI until after NULL check"

- These are fixes, requires fixes line, for this patch:
Fixes: 440499cf5376 ("net/i40e: support floating VEB")

- For coverity fixes, defined usage is: "Coverity issue: XXXXX"

- Can be good to CC stable tree for these fixes.


Overall patch comment becomes something like:
"
net/i40e: do not use VSI until after NULL check

Coverity issue: 127556
Fixes: 440499cf5376 ("net/i40e: support floating VEB")

Signed-off-by: John W. Linville <linville@tuxdriver.com>
"