From: Panu Matilainen <pmatilai@redhat.com>
To: dev@dpdk.org
Cc: rasesh.mody@qlogic.com, harish.patil@qlogic.com, sony.chacko@qlogic.com
Subject: [dpdk-dev] [PATCH] qede: add missing external dependency and disable by default
Date: Tue, 24 May 2016 13:28:31 +0300 [thread overview]
Message-ID: <c610f841ac50a2dbd7417f8f1bcc5d27260b62c9.1464085711.git.pmatilai@redhat.com> (raw)
The qede driver depends on libz but the LDLIBS entry in makefile
was missing. Also because of the external dependency, make it
disabled in default config as per common DPDK policy on external deps.
Fixes: ec94dbc57362 ("qede: add base driver")
Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
---
config/common_base | 2 +-
drivers/net/qede/Makefile | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/config/common_base b/config/common_base
index 3535c6e..47c26f6 100644
--- a/config/common_base
+++ b/config/common_base
@@ -299,7 +299,7 @@ CONFIG_RTE_LIBRTE_BOND_DEBUG_ALB_L1=n
# QLogic 25G/40G PMD
#
-CONFIG_RTE_LIBRTE_QEDE_PMD=y
+CONFIG_RTE_LIBRTE_QEDE_PMD=n
CONFIG_RTE_LIBRTE_QEDE_DEBUG_INIT=n
CONFIG_RTE_LIBRTE_QEDE_DEBUG_INFO=n
CONFIG_RTE_LIBRTE_QEDE_DEBUG_DRV=n
diff --git a/drivers/net/qede/Makefile b/drivers/net/qede/Makefile
index 4cc9ee8..c9b3b1c 100644
--- a/drivers/net/qede/Makefile
+++ b/drivers/net/qede/Makefile
@@ -14,6 +14,8 @@ LIB = librte_pmd_qede.a
CFLAGS += -O3
CFLAGS += $(WERROR_FLAGS)
+LDLIBS += -lz
+
EXPORT_MAP := rte_pmd_qede_version.map
LIBABIVER := 1
--
2.5.5
next reply other threads:[~2016-05-24 10:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-24 10:28 Panu Matilainen [this message]
2016-05-24 14:15 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c610f841ac50a2dbd7417f8f1bcc5d27260b62c9.1464085711.git.pmatilai@redhat.com \
--to=pmatilai@redhat.com \
--cc=dev@dpdk.org \
--cc=harish.patil@qlogic.com \
--cc=rasesh.mody@qlogic.com \
--cc=sony.chacko@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).