From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id CAEF24A65 for ; Tue, 24 May 2016 12:28:37 +0200 (CEST) Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 373D27F0A6; Tue, 24 May 2016 10:28:37 +0000 (UTC) Received: from sopuli.koti.laiskiainen.org.com (vpn1-4-146.ams2.redhat.com [10.36.4.146]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u4OASZxj022123; Tue, 24 May 2016 06:28:36 -0400 From: Panu Matilainen To: dev@dpdk.org Cc: rasesh.mody@qlogic.com, harish.patil@qlogic.com, sony.chacko@qlogic.com Date: Tue, 24 May 2016 13:28:31 +0300 Message-Id: X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Tue, 24 May 2016 10:28:37 +0000 (UTC) Subject: [dpdk-dev] [PATCH] qede: add missing external dependency and disable by default X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 May 2016 10:28:38 -0000 The qede driver depends on libz but the LDLIBS entry in makefile was missing. Also because of the external dependency, make it disabled in default config as per common DPDK policy on external deps. Fixes: ec94dbc57362 ("qede: add base driver") Signed-off-by: Panu Matilainen --- config/common_base | 2 +- drivers/net/qede/Makefile | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/config/common_base b/config/common_base index 3535c6e..47c26f6 100644 --- a/config/common_base +++ b/config/common_base @@ -299,7 +299,7 @@ CONFIG_RTE_LIBRTE_BOND_DEBUG_ALB_L1=n # QLogic 25G/40G PMD # -CONFIG_RTE_LIBRTE_QEDE_PMD=y +CONFIG_RTE_LIBRTE_QEDE_PMD=n CONFIG_RTE_LIBRTE_QEDE_DEBUG_INIT=n CONFIG_RTE_LIBRTE_QEDE_DEBUG_INFO=n CONFIG_RTE_LIBRTE_QEDE_DEBUG_DRV=n diff --git a/drivers/net/qede/Makefile b/drivers/net/qede/Makefile index 4cc9ee8..c9b3b1c 100644 --- a/drivers/net/qede/Makefile +++ b/drivers/net/qede/Makefile @@ -14,6 +14,8 @@ LIB = librte_pmd_qede.a CFLAGS += -O3 CFLAGS += $(WERROR_FLAGS) +LDLIBS += -lz + EXPORT_MAP := rte_pmd_qede_version.map LIBABIVER := 1 -- 2.5.5