From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 627438E7C for ; Thu, 19 Apr 2018 16:50:49 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Apr 2018 07:50:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,469,1517904000"; d="scan'208";a="52042729" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.237.220.128]) ([10.237.220.128]) by orsmga002.jf.intel.com with ESMTP; 19 Apr 2018 07:50:46 -0700 To: Arnon Warshavsky Cc: Thomas Monjalon , "Lu, Wenzhuo" , "Doherty, Declan" , jerin.jacob@caviumnetworks.com, Bruce Richardson , "Yigit, Ferruh" , dev@dpdk.org References: <1524117669-25729-1-git-send-email-arnon@qwilt.com> <1524117669-25729-8-git-send-email-arnon@qwilt.com> <9d631c8a-5ec6-aae1-9f5d-0c890dfb1c19@intel.com> <3082a58f-46c9-d4c0-6c30-bb84a17bd6fe@intel.com> From: "Burakov, Anatoly" Message-ID: Date: Thu, 19 Apr 2018 15:50:45 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <3082a58f-46c9-d4c0-6c30-bb84a17bd6fe@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 07/11] eal: replace rte_panic instances in hugepage_info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Apr 2018 14:50:49 -0000 On 19-Apr-18 3:45 PM, Burakov, Anatoly wrote: > On 19-Apr-18 3:09 PM, Arnon Warshavsky wrote: >> Thanks Anatoly. Will fix that in v5. >> Is it preferred to keep all version notes in the cover letter alone? >> > > Generally, cover letter should give general outline (i.e. "fixed 32 bit > compile"), while notes for individual patches should be more specific > about the changes between versions (but not too specific, i.e. don't do > "change variable X on line 100 to be Y"). > > So, whatever you think gets your point across best. Not all changes > deserve to be called out in the cover letter. > Just to be clear: With my initial reply, i did not mean "patch notes should be in the cover letter". What i meant was that you have put your version changes "e.g. v4 - changed this to that" into the commit message. What you should have done is put your patch notes after the commit message, like this: replace panic calls with log and retrun value. Signed-off-by: Arnon Warshavsky --- v4 static size calculation function changed to return success/fail code in addition to filling the size result. lib/librte_eal/linuxapp/eal/eal_hugepage_info.c | 32 ++++++++++++++++--------- 1 file changed, 21 insertions(+), 11 deletions(-) Note that the v4 comments are after the "---" - this is where the commit message ends as far as git concerned, so you can put your notes there. -- Thanks, Anatoly