From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 55EB0A00C4; Thu, 30 Jun 2022 18:22:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E11F24069D; Thu, 30 Jun 2022 18:22:50 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 5768940694 for ; Thu, 30 Jun 2022 18:22:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656606169; x=1688142169; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=bJhVcG0Nd/nVKJmeGRmGRx8/Tmmwl9Y3JlR+4aWNdh8=; b=IU+cgRREyMpwrnlN05g8pH/ImSe9/wJaITfbWRyPEO55jddO64dPxk0t hGk8IKQVwACnQvPk4G5Iv2Cbg7tdwzmtR0f2kDmeSPNg/u1lC3mtrl2Ye FmJWVokcFU2rhQGRVXAXIO0ZgP7zT2hVQk2de/j5lKr2oUMuRWKUHNiTy +3r2INhzT7/lqFj2GAP5e9hxh9SlZ9etsqQueohyTZ4bF1pBpnnFapkFX +DimJkYVJO9RqgFcAxD53mjq6yHq6jkCg99EOrRI6R6vdhW69yh2bxS8r suxaIfiz5W43AjXmgWZWt4V7/D5q9sQ7dR4z3cZ+iVmYw6PsamUwuWmbq g==; X-IronPort-AV: E=McAfee;i="6400,9594,10394"; a="282427665" X-IronPort-AV: E=Sophos;i="5.92,234,1650956400"; d="scan'208";a="282427665" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jun 2022 09:22:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,234,1650956400"; d="scan'208";a="541384438" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga003.jf.intel.com with ESMTP; 30 Jun 2022 09:22:47 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 30 Jun 2022 09:22:47 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Thu, 30 Jun 2022 09:22:47 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Thu, 30 Jun 2022 09:22:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DuvkLjT6cXiV7pn5Vmpa34rDRU2I4BhP1Skd0F1Y7IGMF5XJKqNgRWiDoOR3aOFcyMux0WQU4mfCRxlHLN3JAlPIY5xTuxpzRYCF8N8KzX9FWS+YFx7IKcykRoq02GbhDKpDSa06eayAASzUdnCISNJg6IFQG7f4JV9q9hOIFJtevaWfbDuXyZoTjOPVvSsNJw3CuMvSyjQRLAh9WvB9B736Lm4cRT3IuU2cHqeReX+aFq9wF9UuignIazZ+ZUwmeXHmesfrJ7zRoLB/I4hh1mdusUyA5bLC60kCANOj4OzekrneEUft9UOpRd/ZwIcQ/eDKz/SBCa95QyqN9djU6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zAIeAu6NQGfRbUmJD7+EjxaWot0/6kzsdUmybLWA1P0=; b=GesRcNjMI/fRMHDKptag1IJYL+1x/6rz/AM/upk1RHOXCmRkUwVByq2Uisyw+bLmgBZqXXfubYm/9ZG7t4Ffi+lizQKTfSlOPnTSjDPaS6Sw+PbqTamlFiiAt7f+6KLLf9vlwB4e6DhRYFZF7qm6ENNyYbEvz99sliWgWw3HbTbIjksjNq0kRMufKZqfiqREuKTzGbUMyo6nTRQbIBtMWMT7/IWQMNR5ix8c2PjR2w6C5U+kjNRlYbuhUoAjh7MDnxSWCA6nZQZEa4k/E74qv4KVpDc0W8IW6H1Rm8HBd+F9vnjbkXf22jh5wpqcJxoo5OuJyNe1z/ZZgfNJ5OUIKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from SJ0PR11MB5772.namprd11.prod.outlook.com (2603:10b6:a03:422::8) by LV2PR11MB6070.namprd11.prod.outlook.com (2603:10b6:408:179::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14; Thu, 30 Jun 2022 16:22:45 +0000 Received: from SJ0PR11MB5772.namprd11.prod.outlook.com ([fe80::21c2:10bc:efb:9cf5]) by SJ0PR11MB5772.namprd11.prod.outlook.com ([fe80::21c2:10bc:efb:9cf5%6]) with mapi id 15.20.5373.018; Thu, 30 Jun 2022 16:22:45 +0000 Message-ID: Date: Thu, 30 Jun 2022 17:22:39 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v2] examples/ipsec-secgw: fix fallback session create Content-Language: en-US To: Radu Nicolau , Akhil Goyal CC: , , References: <20220630100010.2364032-1-radu.nicolau@intel.com> <20220630114527.2392332-1-radu.nicolau@intel.com> From: "Medvedkin, Vladimir" In-Reply-To: <20220630114527.2392332-1-radu.nicolau@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0650.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:296::20) To SJ0PR11MB5772.namprd11.prod.outlook.com (2603:10b6:a03:422::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 864c02f8-f0cb-48db-f56f-08da5ab4c3d0 X-MS-TrafficTypeDiagnostic: LV2PR11MB6070:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bWQhJtNc6Rw3lH90q2yc1eP+VXiJCxPM31Sti/t8eKxheVgkjqbZhNIpZX5YS2EYgAPNHQTsbfzFt+Qv9xFnmpAtb6uAGEym1FrneGSnmlce1QtAzE9Ogm3GWMa1DoUKHzni4AE2ZUX6fEEfQmJZZUIC/SMm2D3/IskiI+WWWdytQ0i7ETF/e20Mu655gMwZqTAxksxHuK3BUyhS0dqrCODyqm90Hl1nRoTnNXh2wCExciMnUbs6K2Jse1axcYBhcDxXMguDuSX9gyLc4eeyHTZYS7R9WYZbu19OvfllK4vXxr5ZGAHupPYEmLUDIf5AoQ8Atu4LvR0Dkonti6NvIH6qX9azGlQHSVcgGJ4l27Syaht71Xn5eYSDKx1ogXNhxhzJ/eBENcQvUMh1DOlIDEkPrRS8L98PpxmjyGBs15YTjsVSyOuC0nZ/qMZ3cQ1gyukRKwGjMO+tBmNENgxaKlQnElBSgLvzZLqezZIT69GBPGK7PkP5L0D3oTdD3W/hLQxqbacXNYV4x2c4pqhV+xpMiqRdlgK50QA+Uuu26mDnVjf2z/n5/s2NEL9yKdoNgQPlja9jSf77mySs2xPIz/khfU0x0YUjKaMF7cVWq2cZwqv68BGMw/a8TDWQ9+1sAOSfT0pMyB4zIOFgqrl9MPQwVU1EQ+WYToKMFolEvz7v0PsDGWgRetr9CyB5ON6a3FdsB9paKTzEyMa6mfmNHX8pp3kr2SMcC2WoqyqGksAu4LLBf+8rr+i9+SgbSkzAhJunGYreWsLnrXNCN+mr0CtsH51qF7TvMj44/QfpviJwBR/FTQz4GN2ltgs8q/5ll4mp4i+GlReUw8j/VbcppAZZ+KWsTE3EdajjvFUb63o= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR11MB5772.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(376002)(346002)(136003)(39860400002)(366004)(396003)(31696002)(66556008)(6506007)(6666004)(186003)(83380400001)(26005)(2616005)(66476007)(41300700001)(53546011)(82960400001)(38100700002)(6512007)(8676002)(316002)(31686004)(36756003)(5660300002)(6486002)(110136005)(2906002)(478600001)(4326008)(66946007)(8936002)(86362001)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MGttdkpSd1llWDN4Sk1OOTE0WWZTaW9lejJGZGlUSGdsYzJuTDd0M2Z4clRp?= =?utf-8?B?cGZhTWRkMnJhK2QzT1IxdkFHRlRXOUVqa2VhZWJYSmMwUHVMRVZRZDllbDdI?= =?utf-8?B?eWlPSGwzSDFyYTU5TmhFdlVWVC9YckpFWUZiaWVGbzdQVkNvdjNNamdPM3E1?= =?utf-8?B?QVRYYitnWXdlK0VWZytSUnV1Ni9NZDhPZW9TNDJGc3ZNVHp5TU9oTG1qeFJj?= =?utf-8?B?WjlFbk9BZGszQUIwYlhLV00zbW9NekVJazIrTkxJaUlIL2hUalk5ekd5THhu?= =?utf-8?B?WlBtem1wTlZmNW1WMW94b1htdXF3RU1kc3NoTVF0UVZvOGp0VkJySll0UjNn?= =?utf-8?B?RWdOQlBnNkZub05POGI4OFFHWW0ybE13TzAvM3JjcUJkTU03dWlVVCtQZFUv?= =?utf-8?B?aGlRTEh5enVMaVRKam1ncy9YazJ4ek1uVWZXRDZFOG5OdjZhVzlCdG55aEda?= =?utf-8?B?L3I4c0dPYi9YTUJ3eWNkLzRvbU15N1JTYnYrVEUreVZGVmsweEFzZzBtZzdE?= =?utf-8?B?K0xYaUswUzVWV3BCQ0JCVnk0MGVoOHM2NEo1T01CYTRsZ0w5QnowV0x3SFhZ?= =?utf-8?B?MEFrcGpwT2F1aDY4cDBhVkFJWEY2eVdUR1VhMjNSV1lkL3FFQ0hKVC9XNmNC?= =?utf-8?B?K3FVMzhjbTlJR2Fwem5SMTl5N0RTNGRINUtlTUpWblBpWE1nU1EyVlRLK3dC?= =?utf-8?B?ZFNFdDRldnVVaVFiSm5HWDFOWXRzR2oxOXBYUVRGcWxRVmU5NUhXQXZaMklT?= =?utf-8?B?UkJmVVJSZ25iUEZJa2lueGVqcE5sUFQyNVN3dUVPL21pRDVvS0hnd0xSQ0VC?= =?utf-8?B?SE8xQkExREM5a014ZVcvalVXVzVJTGtsQU0rZW42QzhTNm5IMjloVzZQUXIr?= =?utf-8?B?Ri9hOTY2emh5ajFEbCs0MlZIWTlSUzlHTExmTnZIQzNTbUFNdFNEMVRmRzV5?= =?utf-8?B?b2g0RThnWjcrUXJITzVWeTBHdk1rMWpCcEZvVTVkWEpxZFQ1MVo4WS9iRnpK?= =?utf-8?B?UEg5YkxQSFZCSW04YUNaWGxNTGFZTkRVdmlSTXdqNjlHdXlaUTZoM3BQSEI0?= =?utf-8?B?THJ5UzBteVA3L2xNMTVTcE5QL2lYd1d1YUN4a2dkV3dFaG9jS2xxZEVETER0?= =?utf-8?B?eWNpMVl5djh0NkdtOS9SR1pZRWRwU0k5L2NpVXduUTFFOVRBRmZHM1Y2aXJx?= =?utf-8?B?azd6S0F3YUd5MWJPWnNiUDFQVjdrZ0NtZCtJY3p3Ujd2NVg5V0h0bDhONkp3?= =?utf-8?B?b3VzcFBkN0RsQSt5VExGNW1vcCtQMTN2OE9Qcnp0RzVNaU1wV0NYMCtCdGZW?= =?utf-8?B?SytROU1SY2FmY1M1dnVJYitlN29WQ0IwY1FZRjVib2tPbkhnczJjMzZSRUY0?= =?utf-8?B?SXovM2RCMTFKUVliUXVuTXpzcjF0QjFlcWlkT2FHUWZnd3JNMkhhbkhKU2Jx?= =?utf-8?B?RmNyWkhabGdTdzJJc0JLMzduOVI1cFRMcVc5Z3F2cWo5L1Z4bTQ3VTgwb3RU?= =?utf-8?B?YkIvYW15bHZGRE1hdW92NnNUbkxsQm1NWXRiZGlDMVcvZUlWQ3hOVnFmeEJv?= =?utf-8?B?THArS2ovbjNnWWJSa3N1VUg4bFpVM1IrRDYyU21lK3JVUk45MkZIdXM1Wkho?= =?utf-8?B?NDJ1UWx4ZFkzOE5qQ1VYYXJCNEpGSnZLMmttU3ppUXFUTEpEa0NrcllJZm9V?= =?utf-8?B?ZHBOZHRVR0dmWU5zU0R0MVNOcGpHdEdwM3RzR2Uvbk80MTVNU3BURUVhbU13?= =?utf-8?B?cW10RHNpU2t4Q0t5cDIyUHJEUVpaV0hJaml3NjlLakVHQlZCR3hFMG9XMlFq?= =?utf-8?B?NEhZb05hd3kyL28wQXpuVWJaRDU5RW9kUnkwSy9XYU1SL2Z5b1ZHWVBMcUY4?= =?utf-8?B?QVRUa1NvVWNoc1NNdE5mK2tNSlViL3MxYi8rNWIvT24xcXozNnlBU3FEcEg2?= =?utf-8?B?bCtQNnd2UVh6NzN5ODBZcUQrRndobGJndFR4YVV0MXloN0UvTjVUUWhBem03?= =?utf-8?B?VUF6Tk9mL09mcDF1Ui9VZ0VhZTErWjA0azBTOTNnNlhPVjc0S2tYMTRzdE1E?= =?utf-8?B?Y0NrYWRHTUZYY0cyYWVXT3JjcytnZzRyeS9WOVZnQnl3cHpCSXFSZ1o0cXpJ?= =?utf-8?B?QWh3T1ovM2VyQXBBNTg3bWR0SlBlYmUvYVBJOERKTU5UV0NFZDJYYzcvelRk?= =?utf-8?B?NEE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 864c02f8-f0cb-48db-f56f-08da5ab4c3d0 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5772.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jun 2022 16:22:45.5023 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: A+KG9j1RoNrlvn0tXz7lEB4x3dWct3jhsVprvZwL746xYsC6TWgxxHK4391/4u7ifyyfY3uFblXdLRPmGVAWxla1xJ5pRnxvjI5CP1LuxUM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR11MB6070 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Tested-by: Vladimir Medvedkin On 30/06/2022 12:45, Radu Nicolau wrote: > Fix fallback session create for inline sessions. > > Fixes: a8ade12123c3 ("examples/ipsec-secgw: create lookaside sessions at init") > Cc: vfialko@marvell.com > > Signed-off-by: Radu Nicolau > --- > v2: create the session rather than just check if it's NULLL > > examples/ipsec-secgw/sa.c | 23 ++++++++++++++++------- > 1 file changed, 16 insertions(+), 7 deletions(-) > > diff --git a/examples/ipsec-secgw/sa.c b/examples/ipsec-secgw/sa.c > index 5d9cec97db..d081cd0e2c 100644 > --- a/examples/ipsec-secgw/sa.c > +++ b/examples/ipsec-secgw/sa.c > @@ -1533,7 +1533,8 @@ fill_ipsec_session(struct rte_ipsec_session *ss, struct rte_ipsec_sa *sa) > * Initialise related rte_ipsec_sa object. > */ > static int > -ipsec_sa_init(struct ipsec_sa *lsa, struct rte_ipsec_sa *sa, uint32_t sa_size) > +ipsec_sa_init(struct ipsec_sa *lsa, struct rte_ipsec_sa *sa, uint32_t sa_size, > + struct socket_ctx *skt_ctx, struct ipsec_ctx *ips_ctx[]) > { > int rc; > struct rte_ipsec_sa_prm prm; > @@ -1572,8 +1573,15 @@ ipsec_sa_init(struct ipsec_sa *lsa, struct rte_ipsec_sa *sa, uint32_t sa_size) > return rc; > > /* init inline fallback processing session */ > - if (lsa->fallback_sessions == 1) > - rc = fill_ipsec_session(ipsec_get_fallback_session(lsa), sa); > + if (lsa->fallback_sessions == 1) { > + struct rte_ipsec_session *ipfs = ipsec_get_fallback_session(lsa); > + if (ipfs->security.ses == NULL) { > + rc = create_lookaside_session(ips_ctx, skt_ctx, lsa, ipfs); > + if (rc != 0) > + return rc; > + } > + rc = fill_ipsec_session(ipfs, sa); > + } > > return rc; > } > @@ -1583,7 +1591,8 @@ ipsec_sa_init(struct ipsec_sa *lsa, struct rte_ipsec_sa *sa, uint32_t sa_size) > * one per session. > */ > static int > -ipsec_satbl_init(struct sa_ctx *ctx, uint32_t nb_ent, int32_t socket) > +ipsec_satbl_init(struct sa_ctx *ctx, uint32_t nb_ent, int32_t socket, > + struct socket_ctx *skt_ctx, struct ipsec_ctx *ips_ctx[]) > { > int32_t rc, sz; > uint32_t i, idx; > @@ -1621,7 +1630,7 @@ ipsec_satbl_init(struct sa_ctx *ctx, uint32_t nb_ent, int32_t socket) > sa = (struct rte_ipsec_sa *)((uintptr_t)ctx->satbl + sz * i); > lsa = ctx->sa + idx; > > - rc = ipsec_sa_init(lsa, sa, sz); > + rc = ipsec_sa_init(lsa, sa, sz, skt_ctx, ips_ctx); > } > > return rc; > @@ -1700,7 +1709,7 @@ sa_init(struct socket_ctx *ctx, int32_t socket_id, > > if (app_sa_prm.enable != 0) { > rc = ipsec_satbl_init(ctx->sa_in, nb_sa_in, > - socket_id); > + socket_id, ctx, ipsec_ctx); > if (rc != 0) > rte_exit(EXIT_FAILURE, > "failed to init inbound SAs\n"); > @@ -1722,7 +1731,7 @@ sa_init(struct socket_ctx *ctx, int32_t socket_id, > > if (app_sa_prm.enable != 0) { > rc = ipsec_satbl_init(ctx->sa_out, nb_sa_out, > - socket_id); > + socket_id, ctx, ipsec_ctx); > if (rc != 0) > rte_exit(EXIT_FAILURE, > "failed to init outbound SAs\n"); -- Regards, Vladimir