From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 99D8D43AE6; Sat, 10 Feb 2024 12:34:33 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 700DA402CF; Sat, 10 Feb 2024 12:34:33 +0100 (CET) Received: from szxga06-in.huawei.com (szxga06-in.huawei.com [45.249.212.32]) by mails.dpdk.org (Postfix) with ESMTP id AD613400D6 for ; Sat, 10 Feb 2024 12:34:31 +0100 (CET) Received: from mail.maildlp.com (unknown [172.19.163.44]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4TX7sM6hfxz1vtPR; Sat, 10 Feb 2024 19:33:59 +0800 (CST) Received: from dggpeml500024.china.huawei.com (unknown [7.185.36.10]) by mail.maildlp.com (Postfix) with ESMTPS id 603911400E8; Sat, 10 Feb 2024 19:34:29 +0800 (CST) Received: from [10.45.27.222] (10.45.27.222) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Sat, 10 Feb 2024 19:34:28 +0800 Content-Type: multipart/alternative; boundary="------------oDF1VhOSD0qdzdN12g74SlJy" Message-ID: Date: Sat, 10 Feb 2024 19:34:25 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v2] dmadev: standardize alignment To: , , Kevin Laatz , Bruce Richardson CC: References: <20240202090633.10816-1-pbhagavatula@marvell.com> <20240210062758.1510-1-pbhagavatula@marvell.com> Content-Language: en-US From: fengchengwen In-Reply-To: <20240210062758.1510-1-pbhagavatula@marvell.com> X-Originating-IP: [10.45.27.222] X-ClientProxiedBy: dggpeml100010.china.huawei.com (7.185.36.14) To dggpeml500024.china.huawei.com (7.185.36.10) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --------------oDF1VhOSD0qdzdN12g74SlJy Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Acked-by: Chengwen Feng On 2024/2/10 14:27, pbhagavatula@marvell.com wrote: > From: Pavan Nikhilesh > > Align fp_objects based on cacheline size defined > by build configuration. > > Signed-off-by: Pavan Nikhilesh > --- > v2 Changes: > - Drop malloc changes. > > lib/dmadev/rte_dmadev_core.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/dmadev/rte_dmadev_core.h b/lib/dmadev/rte_dmadev_core.h > index 064785686f..e8239c2d22 100644 > --- a/lib/dmadev/rte_dmadev_core.h > +++ b/lib/dmadev/rte_dmadev_core.h > @@ -73,7 +73,7 @@ struct rte_dma_fp_object { > rte_dma_completed_t completed; > rte_dma_completed_status_t completed_status; > rte_dma_burst_capacity_t burst_capacity; > -} __rte_aligned(128); > +} __rte_cache_aligned; > > extern struct rte_dma_fp_object *rte_dma_fp_objs; > > -- > 2.25.1 > --------------oDF1VhOSD0qdzdN12g74SlJy Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: 7bit

Acked-by: Chengwen Feng <fengchengwen@huawei.com>

On 2024/2/10 14:27, pbhagavatula@marvell.com wrote:
From: Pavan Nikhilesh <pbhagavatula@marvell.com>

Align fp_objects based on cacheline size defined
by build configuration.

Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
---
v2 Changes:
- Drop malloc changes.

 lib/dmadev/rte_dmadev_core.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/dmadev/rte_dmadev_core.h b/lib/dmadev/rte_dmadev_core.h
index 064785686f..e8239c2d22 100644
--- a/lib/dmadev/rte_dmadev_core.h
+++ b/lib/dmadev/rte_dmadev_core.h
@@ -73,7 +73,7 @@ struct rte_dma_fp_object {
 	rte_dma_completed_t        completed;
 	rte_dma_completed_status_t completed_status;
 	rte_dma_burst_capacity_t   burst_capacity;
-} __rte_aligned(128);
+} __rte_cache_aligned;

 extern struct rte_dma_fp_object *rte_dma_fp_objs;

--
2.25.1
--------------oDF1VhOSD0qdzdN12g74SlJy--