From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 16A521B168 for ; Tue, 9 Jan 2018 11:30:53 +0100 (CET) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (webmail.solarflare.com [12.187.104.26]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1-us4.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 9692AB40064; Tue, 9 Jan 2018 10:30:51 +0000 (UTC) Received: from [192.168.38.17] (84.52.114.114) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Tue, 9 Jan 2018 02:30:48 -0800 To: Stephen Hemminger , References: <20180108174514.14688-1-stephen@networkplumber.org> <20180108174514.14688-3-stephen@networkplumber.org> From: Andrew Rybchenko Message-ID: Date: Tue, 9 Jan 2018 13:30:46 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180108174514.14688-3-stephen@networkplumber.org> Content-Language: en-GB X-Originating-IP: [84.52.114.114] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ocex03.SolarFlarecom.com (10.20.40.36) X-MDID: 1515493852-vIQWstUKfNUt Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v3 02/15] ethdev: add linkstatus get/set helper functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jan 2018 10:30:53 -0000 On 01/08/2018 08:45 PM, Stephen Hemminger wrote: > Many drivers are all doing copy/paste of the same code to atomically > update the link status. Reduce duplication, and allow for future > changes by having common function for this. > > Signed-off-by: Stephen Hemminger > --- > lib/librte_ether/rte_ethdev.c | 36 ++++++++++++++++++++++++++++++++++++ > lib/librte_ether/rte_ethdev.h | 28 ++++++++++++++++++++++++++++ > 2 files changed, 64 insertions(+) > > diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c > index a524af740f4a..6674500bbc4a 100644 > --- a/lib/librte_ether/rte_ethdev.c > +++ b/lib/librte_ether/rte_ethdev.c > @@ -1495,6 +1495,42 @@ rte_eth_link_get_nowait(uint16_t port_id, struct rte_eth_link *eth_link) > } > } > > +int > +_rte_eth_linkstatus_set(struct rte_eth_dev *dev, > + const struct rte_eth_link *new_link) > +{ > + volatile uint64_t *dev_link > + = (volatile uint64_t *)&(dev->data->dev_link); > + union { > + uint64_t val64; > + struct rte_eth_link link; > + } orig; > + > + RTE_BUILD_BUG_ON(sizeof(*new_link) != sizeof(uint64_t)); > + > + orig.val64 = rte_atomic64_exchange(dev_link, > + *(const uint64_t *)new_link); > + > + return (orig.link.link_status == new_link->link_status) ? -1 : 0; It still contradicts to: -1 if link state has changed, 0 if the same. BTW, it looks like the return value of the link_update callback is not specified (described) and not used. It explains why different drivers behave differently and nobody notices it. > +} > + > +void > +_rte_eth_linkstatus_get(const struct rte_eth_dev *dev, > + struct rte_eth_link *link) > +{ > + volatile uint64_t *src = (uint64_t *)&(dev->data->dev_link); > + uint64_t tmp; > + > + RTE_BUILD_BUG_ON(sizeof(*link) != sizeof(uint64_t)); > + > + /* can't use rte_atomic64_read because it returns signed int */ > + do { > + tmp = *src; > + } while (!rte_atomic64_cmpset(src, tmp, tmp)); > + > + memcpy(link, &tmp, sizeof(tmp)); > +} > + > int > rte_eth_stats_get(uint16_t port_id, struct rte_eth_stats *stats) > { > diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h > index b10e2a92da71..b47402b797c3 100644 > --- a/lib/librte_ether/rte_ethdev.h > +++ b/lib/librte_ether/rte_ethdev.h > @@ -2218,6 +2218,34 @@ int rte_eth_dev_set_link_down(uint16_t port_id); > */ > void rte_eth_dev_close(uint16_t port_id); > > + > +/** > + * @internal > + * Atomically set the link status for the specific device. > + * It is for use by DPDK device driver use only. > + * User applications should not call it > + * > + * @param dev > + * Pointer to struct rte_eth_dev. > + * @param link > + * New link status value. > + * @return > + * -1 if link state has changed, 0 if the same. > + */ > +int _rte_eth_linkstatus_set(struct rte_eth_dev *dev, > + const struct rte_eth_link *link); > + > +/** > + * @internal > + * Atomically get the link speed and status. > + * @param dev > + * Pointer to struct rte_eth_dev. > + * @param link > + * link status value. > + */ > +void _rte_eth_linkstatus_get(const struct rte_eth_dev *dev, > + struct rte_eth_link *link); > + > /** > * Reset a Ethernet device and keep its port id. > *