From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C23E3A0C45; Wed, 20 Oct 2021 09:44:31 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A624841183; Wed, 20 Oct 2021 09:44:31 +0200 (CEST) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id 439F740142 for ; Wed, 20 Oct 2021 09:44:30 +0200 (CEST) Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4HZ2ZM1YzqzbhG6; Wed, 20 Oct 2021 15:39:55 +0800 (CST) Received: from dggpeml500024.china.huawei.com (7.185.36.10) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.15; Wed, 20 Oct 2021 15:44:28 +0800 Received: from [127.0.0.1] (10.67.100.224) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.15; Wed, 20 Oct 2021 15:44:28 +0800 To: Kevin Laatz , CC: , , , References: <20210827172048.558704-1-kevin.laatz@intel.com> <20211019141041.1890983-1-kevin.laatz@intel.com> <20211019141041.1890983-7-kevin.laatz@intel.com> From: fengchengwen Message-ID: Date: Wed, 20 Oct 2021 15:44:28 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20211019141041.1890983-7-kevin.laatz@intel.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.100.224] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH v10 06/16] dma/idxd: add datapath structures X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2021/10/19 22:10, Kevin Laatz wrote: > Add data structures required for the data path for IDXD devices. > > Signed-off-by: Bruce Richardson > Signed-off-by: Kevin Laatz > Reviewed-by: Conor Walsh > --- > drivers/dma/idxd/idxd_bus.c | 1 + > drivers/dma/idxd/idxd_common.c | 33 +++++++++++++++++++++++++ > drivers/dma/idxd/idxd_hw_defs.h | 41 ++++++++++++++++++++++++++++++++ > drivers/dma/idxd/idxd_internal.h | 4 ++++ > drivers/dma/idxd/idxd_pci.c | 2 ++ > 5 files changed, 81 insertions(+) [snip] > +/** > + * Hardware descriptor used by DSA hardware, for both bursts and > + * for individual operations. > + */ > +struct idxd_hw_desc { > + uint32_t pasid; > + uint32_t op_flags; > + rte_iova_t completion; > + > + RTE_STD_C11 > + union { > + rte_iova_t src; /* source address for copy ops etc. */ > + rte_iova_t desc_addr; /* descriptor pointer for batch */ > + }; > + rte_iova_t dst; > + > + uint32_t size; /* length of data for op, or batch size */ > + > + uint16_t intr_handle; /* completion interrupt handle */ > + > + /* remaining 26 bytes are reserved */ > + uint16_t __reserved[13]; The non-reserved take about 30+B, and the struct align 64, so the __reserved[13] could delete. It's a minor problem, so: Reviewed-by: Chengwen Feng > +} __rte_aligned(64); > + > #define IDXD_COMP_STATUS_INCOMPLETE 0 > #define IDXD_COMP_STATUS_SUCCESS 1 > #define IDXD_COMP_STATUS_INVALID_OPCODE 0x10 > diff --git a/drivers/dma/idxd/idxd_internal.h b/drivers/dma/idxd/idxd_internal.h > index 8473bf939f..5e253fdfbc 100644 > --- a/drivers/dma/idxd/idxd_internal.h > +++ b/drivers/dma/idxd/idxd_internal.h > @@ -40,6 +40,8 @@ struct idxd_pci_common { > }; [snip]