From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D2866A054F; Mon, 15 Feb 2021 19:01:18 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5B662160684; Mon, 15 Feb 2021 19:01:18 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id F0C6B406FF for ; Mon, 15 Feb 2021 19:01:15 +0100 (CET) IronPort-SDR: FXjc8qEFHFroB77blxFU3ao7MH4l+VO3UQyzM1TG8lDTqf4wZ2lVyhIsV2cJQmJ1i861sO9WKe g4NU+nMvZKKA== X-IronPort-AV: E=McAfee;i="6000,8403,9896"; a="180173683" X-IronPort-AV: E=Sophos;i="5.81,181,1610438400"; d="scan'208";a="180173683" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2021 10:01:14 -0800 IronPort-SDR: JGCzSqV/pq5LxoqOjbf9unMxV5vSj2LrcyCRg03UhdO0FVkO2dy0aUBRDu2T1FnBTW1pYhFdUX iu4dxZvj3uNQ== X-IronPort-AV: E=Sophos;i="5.81,181,1610438400"; d="scan'208";a="438645750" Received: from klaatz-mobl1.ger.corp.intel.com (HELO [10.213.232.101]) ([10.213.232.101]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2021 10:01:13 -0800 To: Bruce Richardson Cc: dev@dpdk.org References: <20210215155051.8659-1-kevin.laatz@intel.com> <20210215160826.GA255@bricha3-MOBL.ger.corp.intel.com> From: Kevin Laatz Message-ID: Date: Mon, 15 Feb 2021 18:00:59 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210215160826.GA255@bricha3-MOBL.ger.corp.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Subject: Re: [dpdk-dev] [PATCH] usertools/dpdk-telemetry: add file-prefix cmdline argument X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 15/02/2021 16:08, Bruce Richardson wrote: > On Mon, Feb 15, 2021 at 03:50:51PM +0000, Kevin Laatz wrote: >> Currently the dpdk-telemetry.py script connects to all running DPDK apps >> consecutively. With the addition of this file-prefix argument, we can limit >> the amount of information returned providing improved consumability and >> precision to the user. >> >> Signed-off-by: Kevin Laatz > Couple of comments below. With those fixed, please add my reviewed and > tested-by tags. This is a handy change when working with multiple DPDK > processes simultaneously - in my case I tested with OVS and a testpmd > instance using virtio-user connected to it. > > Reviewed-by: Bruce Richardson > Tested-by: Bruce Richardson Thanks for reviewing and testing, Bruce. Will make those changes for v2. /Kevin