DPDK patches and discussions
 help / color / Atom feed
* [dpdk-dev] [PATCH] net/netvsc: disable before changing RSS parameters
@ 2019-11-25 17:13 Stephen Hemminger
  2019-11-26 13:52 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
  2019-12-06 23:52 ` [dpdk-dev] [PATCH v2 0/2] bugfix to netvsc PMD in 19.11 Stephen Hemminger
  0 siblings, 2 replies; 7+ messages in thread
From: Stephen Hemminger @ 2019-11-25 17:13 UTC (permalink / raw)
  To: dev; +Cc: Stephen Hemminger, stable, Dexuan Cui

In order to change RSS parameters, the host requires that RSS
is disable first.

Fixes: 92d23a57cafe ("net/netvsc: support configuring RSS parameters")
Cc: stable@dpdk.org
Signed-off-by: Dexuan Cui <decui@microsoft.com>
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/netvsc/hn_ethdev.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c
index 164e9ad174a7..575780ee5f26 100644
--- a/drivers/net/netvsc/hn_ethdev.c
+++ b/drivers/net/netvsc/hn_ethdev.c
@@ -291,6 +291,13 @@ static int hn_rss_reta_update(struct rte_eth_dev *dev,
 			hv->rss_ind[i] = reta_conf[idx].reta[shift];
 	}
 
+	err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE);
+	if (err) {
+		PMD_DRV_LOG(NOTICE,
+			"rss disable failed");
+		return err;
+	}
+
 	err = hn_rndis_conf_rss(hv, 0);
 	if (err) {
 		PMD_DRV_LOG(NOTICE,
@@ -578,6 +585,13 @@ static int hn_dev_configure(struct rte_eth_dev *dev)
 			return err;
 		}
 
+		err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE);
+		if (err) {
+			PMD_DRV_LOG(NOTICE,
+				"rss disable failed");
+			return err;
+		}
+
 		err = hn_rndis_conf_rss(hv, 0);
 		if (err) {
 			PMD_DRV_LOG(NOTICE,
-- 
2.20.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dpdk-dev] [dpdk-stable] [PATCH] net/netvsc: disable before changing RSS parameters
  2019-11-25 17:13 [dpdk-dev] [PATCH] net/netvsc: disable before changing RSS parameters Stephen Hemminger
@ 2019-11-26 13:52 ` " Ferruh Yigit
  2019-12-06 23:52 ` [dpdk-dev] [PATCH v2 0/2] bugfix to netvsc PMD in 19.11 Stephen Hemminger
  1 sibling, 0 replies; 7+ messages in thread
From: Ferruh Yigit @ 2019-11-26 13:52 UTC (permalink / raw)
  To: Stephen Hemminger, dev; +Cc: stable, Dexuan Cui

On 11/25/2019 5:13 PM, Stephen Hemminger wrote:
> In order to change RSS parameters, the host requires that RSS
> is disable first.
> 
> Fixes: 92d23a57cafe ("net/netvsc: support configuring RSS parameters")
> Cc: stable@dpdk.org
> Signed-off-by: Dexuan Cui <decui@microsoft.com>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

Applied to dpdk-next-net/master, thanks.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [dpdk-dev] [PATCH v2 0/2] bugfix to netvsc PMD in 19.11
  2019-11-25 17:13 [dpdk-dev] [PATCH] net/netvsc: disable before changing RSS parameters Stephen Hemminger
  2019-11-26 13:52 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
@ 2019-12-06 23:52 ` Stephen Hemminger
  2019-12-06 23:52   ` [dpdk-dev] [PATCH v2 1/2] net/netvsc: fix RSS offload flag Stephen Hemminger
                     ` (2 more replies)
  1 sibling, 3 replies; 7+ messages in thread
From: Stephen Hemminger @ 2019-12-06 23:52 UTC (permalink / raw)
  To: dev; +Cc: Stephen Hemminger

This is a resend of earlier bug fix and an additional
fix for RSS flags

Stephen Hemminger (2):
  net/netvsc: fix RSS offload flag
  net/netvsc: disable before changing RSS parameters

 drivers/net/netvsc/hn_ethdev.c | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

-- 
2.20.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [dpdk-dev] [PATCH v2 1/2] net/netvsc: fix RSS offload flag
  2019-12-06 23:52 ` [dpdk-dev] [PATCH v2 0/2] bugfix to netvsc PMD in 19.11 Stephen Hemminger
@ 2019-12-06 23:52   ` Stephen Hemminger
  2019-12-06 23:52   ` [dpdk-dev] [PATCH v2 2/2] net/netvsc: disable before changing RSS parameters Stephen Hemminger
  2019-12-10  9:21   ` [dpdk-dev] [PATCH v2 0/2] bugfix to netvsc PMD in 19.11 Ferruh Yigit
  2 siblings, 0 replies; 7+ messages in thread
From: Stephen Hemminger @ 2019-12-06 23:52 UTC (permalink / raw)
  To: dev; +Cc: Stephen Hemminger, pbhagavatula, stable

The change to add OFFLOAD_RSS_HASH broke use of netvsc PMD
with testpmd. The netvsc driver fails during configure step:

	Configuring Port 1 (socket 0)
	hn_dev_configure(): unsupported RX offload: 0x80000

Fixes: 5d308972954c ("ethdev: add mbuf RSS update as an offload")
Cc: pbhagavatula@marvell.com
Cc: stable@dpdk.org
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/netvsc/hn_ethdev.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c
index 164e9ad174a7..5ef7a452cc69 100644
--- a/drivers/net/netvsc/hn_ethdev.c
+++ b/drivers/net/netvsc/hn_ethdev.c
@@ -42,7 +42,8 @@
 			    DEV_TX_OFFLOAD_VLAN_INSERT)
 
 #define HN_RX_OFFLOAD_CAPS (DEV_RX_OFFLOAD_CHECKSUM | \
-			    DEV_RX_OFFLOAD_VLAN_STRIP)
+			    DEV_RX_OFFLOAD_VLAN_STRIP | \
+			    DEV_RX_OFFLOAD_RSS_HASH)
 
 int hn_logtype_init;
 int hn_logtype_driver;
-- 
2.20.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [dpdk-dev] [PATCH v2 2/2] net/netvsc: disable before changing RSS parameters
  2019-12-06 23:52 ` [dpdk-dev] [PATCH v2 0/2] bugfix to netvsc PMD in 19.11 Stephen Hemminger
  2019-12-06 23:52   ` [dpdk-dev] [PATCH v2 1/2] net/netvsc: fix RSS offload flag Stephen Hemminger
@ 2019-12-06 23:52   ` Stephen Hemminger
  2019-12-10  9:21   ` [dpdk-dev] [PATCH v2 0/2] bugfix to netvsc PMD in 19.11 Ferruh Yigit
  2 siblings, 0 replies; 7+ messages in thread
From: Stephen Hemminger @ 2019-12-06 23:52 UTC (permalink / raw)
  To: dev; +Cc: Stephen Hemminger, stable, Abhishek Marathe, Dexuan Cui

In order to change RSS parameters, the host requires that RSS
is disable first.

Fixes: 92d23a57cafe ("net/netvsc: support configuring RSS parameters")
Cc: stable@dpdk.org
Tested-by: Abhishek Marathe <abmarath@microsoft.com>
Signed-off-by: Dexuan Cui <decui@microsoft.com>
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/netvsc/hn_ethdev.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c
index 5ef7a452cc69..159116f7f691 100644
--- a/drivers/net/netvsc/hn_ethdev.c
+++ b/drivers/net/netvsc/hn_ethdev.c
@@ -292,6 +292,13 @@ static int hn_rss_reta_update(struct rte_eth_dev *dev,
 			hv->rss_ind[i] = reta_conf[idx].reta[shift];
 	}
 
+	err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE);
+	if (err) {
+		PMD_DRV_LOG(NOTICE,
+			"rss disable failed");
+		return err;
+	}
+
 	err = hn_rndis_conf_rss(hv, 0);
 	if (err) {
 		PMD_DRV_LOG(NOTICE,
@@ -579,6 +586,13 @@ static int hn_dev_configure(struct rte_eth_dev *dev)
 			return err;
 		}
 
+		err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE);
+		if (err) {
+			PMD_DRV_LOG(NOTICE,
+				"rss disable failed");
+			return err;
+		}
+
 		err = hn_rndis_conf_rss(hv, 0);
 		if (err) {
 			PMD_DRV_LOG(NOTICE,
-- 
2.20.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dpdk-dev] [PATCH v2 0/2] bugfix to netvsc PMD in 19.11
  2019-12-06 23:52 ` [dpdk-dev] [PATCH v2 0/2] bugfix to netvsc PMD in 19.11 Stephen Hemminger
  2019-12-06 23:52   ` [dpdk-dev] [PATCH v2 1/2] net/netvsc: fix RSS offload flag Stephen Hemminger
  2019-12-06 23:52   ` [dpdk-dev] [PATCH v2 2/2] net/netvsc: disable before changing RSS parameters Stephen Hemminger
@ 2019-12-10  9:21   ` Ferruh Yigit
  2 siblings, 0 replies; 7+ messages in thread
From: Ferruh Yigit @ 2019-12-10  9:21 UTC (permalink / raw)
  To: Stephen Hemminger, dev; +Cc: Donald Lee, Dexuan Cui, Abhishek Marathe

On 12/6/2019 11:52 PM, Stephen Hemminger wrote:
> This is a resend of earlier bug fix and an additional
> fix for RSS flags
> 
> Stephen Hemminger (2):
>   net/netvsc: fix RSS offload flag
>   net/netvsc: disable before changing RSS parameters
> 
>  drivers/net/netvsc/hn_ethdev.c | 17 ++++++++++++++++-
>  1 file changed, 16 insertions(+), 1 deletion(-)
> 


Series applied to dpdk-next-net/master, thanks.

(sign-off/tested tags for 2/2 updated as suggested,
    Signed-off-by: Donald Lee <Donald_Lee@trendmicro.com>
    Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
    Tested-by: Dexuan Cui <decui@microsoft.com>
    Tested-by: Abhishek Marathe <abmarath@microsoft.com>
)

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dpdk-dev] [dpdk-stable] [PATCH] net/netvsc: disable before changing RSS parameters
  2019-11-26 17:02   ` Ferruh Yigit
@ 2019-11-26 17:19     ` " Ferruh Yigit
  0 siblings, 0 replies; 7+ messages in thread
From: Ferruh Yigit @ 2019-11-26 17:19 UTC (permalink / raw)
  To: Dexuan Cui, Stephen Hemminger, dev, Donald Lee (RD-TW)
  Cc: stable, Abhishek Marathe

On 11/26/2019 5:02 PM, Ferruh Yigit wrote:
> On 11/26/2019 3:32 AM, Dexuan Cui wrote:
>>> From: Dexuan Cui
>>> Sent: Monday, November 25, 2019 7:29 PM
>>> To: Stephen Hemminger <stephen@networkplumber.org>; dev@dpdk.org;
>>> Donald_Lee@trendmicro.com
>>> Cc: stable@dpdk.org
>>> Subject: RE: [PATCH] net/netvsc: disable before changing RSS parameters
>>>
>>>> From: Stephen Hemminger <stephen@networkplumber.org>
>>>> Sent: Monday, November 25, 2019 9:13 AM
>>>> To: dev@dpdk.org
>>>> Cc: Stephen Hemminger <stephen@networkplumber.org>;
>>> stable@dpdk.org;
>>>> Dexuan Cui <decui@microsoft.com>
>>>>
>>>> In order to change RSS parameters, the host requires that RSS
>>>> is disable first.
>>>>
>>>> Fixes: 92d23a57cafe ("net/netvsc: support configuring RSS parameters")
>>>> Cc: stable@dpdk.org
>>>> Signed-off-by: Dexuan Cui <decui@microsoft.com>
>>>> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>>>> ---
>>>>  drivers/net/netvsc/hn_ethdev.c | 14 ++++++++++++++
>>>>  1 file changed, 14 insertions(+)
>>>>
>>>> diff --git a/drivers/net/netvsc/hn_ethdev.c
>>> b/drivers/net/netvsc/hn_ethdev.c
>>>> index 164e9ad174a7..575780ee5f26 100644
>>>> --- a/drivers/net/netvsc/hn_ethdev.c
>>>> +++ b/drivers/net/netvsc/hn_ethdev.c
>>>> @@ -291,6 +291,13 @@ static int hn_rss_reta_update(struct rte_eth_dev
>>>> *dev,
>>>>  			hv->rss_ind[i] = reta_conf[idx].reta[shift];
>>>>  	}
>>>>
>>>> +	err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE);
>>>> +	if (err) {
>>>> +		PMD_DRV_LOG(NOTICE,
>>>> +			"rss disable failed");
>>>> +		return err;
>>>> +	}
>>>> +
>>>>  	err = hn_rndis_conf_rss(hv, 0);
>>>>  	if (err) {
>>>>  		PMD_DRV_LOG(NOTICE,
>>>> @@ -578,6 +585,13 @@ static int hn_dev_configure(struct rte_eth_dev
>>>> *dev)
>>>>  			return err;
>>>>  		}
>>>>
>>>> +		err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE);
>>>> +		if (err) {
>>>> +			PMD_DRV_LOG(NOTICE,
>>>> +				"rss disable failed");
>>>> +			return err;
>>>> +		}
>>>> +
>>>>  		err = hn_rndis_conf_rss(hv, 0);
>>>>  		if (err) {
>>>>  			PMD_DRV_LOG(NOTICE,
>>>> --
>>>> 2.20.1
>>>
>>> Hi, Stephen,
>>> I think the patch originally came from Donald Lee (I added him to "To").
>>>
>>> IMO Donald's Signed-off-by should be added.
>>>
>>> And, can you please change my Signed-off-by to Tested-by?
>>>
>>> -- Dexuan
>>
>> Also, please add Tested-by for 
>>
>> Abhishek Marathe <abmarath@microsoft.com> (Cc'd).
> 
> Hi Stephen,
> 
> I will update this in next-net if you confirm.
> And to prevent confusion, can you please reply the tags that needs to be used?
> 

Dropping from next-net until owner of the work clarified.

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, back to index

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-25 17:13 [dpdk-dev] [PATCH] net/netvsc: disable before changing RSS parameters Stephen Hemminger
2019-11-26 13:52 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2019-12-06 23:52 ` [dpdk-dev] [PATCH v2 0/2] bugfix to netvsc PMD in 19.11 Stephen Hemminger
2019-12-06 23:52   ` [dpdk-dev] [PATCH v2 1/2] net/netvsc: fix RSS offload flag Stephen Hemminger
2019-12-06 23:52   ` [dpdk-dev] [PATCH v2 2/2] net/netvsc: disable before changing RSS parameters Stephen Hemminger
2019-12-10  9:21   ` [dpdk-dev] [PATCH v2 0/2] bugfix to netvsc PMD in 19.11 Ferruh Yigit
2019-11-26  3:28 [dpdk-dev] [PATCH] net/netvsc: disable before changing RSS parameters Dexuan Cui
2019-11-26  3:32 ` Dexuan Cui
2019-11-26 17:02   ` Ferruh Yigit
2019-11-26 17:19     ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit

DPDK patches and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox