From: Andrew Rybchenko <arybchenko@solarflare.com>
To: Thomas Monjalon <thomas@monjalon.net>,
Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Neil Horman <nhorman@tuxdriver.com>,
John McNamara <john.mcnamara@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>, <dev@dpdk.org>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
"David Marchand" <david.marchand@redhat.com>, <mdr@ashroe.eu>,
<olivier.matz@6wind.com>
Subject: Re: [dpdk-dev] [PATCH v3] doc: plan splitting the ethdev ops struct
Date: Mon, 25 May 2020 12:11:11 +0300 [thread overview]
Message-ID: <c68af930-d3fa-67bf-4d44-6f8d1a96db5e@solarflare.com> (raw)
In-Reply-To: <4037653.gGmTCM0MZ2@thomas>
On 5/25/20 2:18 AM, Thomas Monjalon wrote:
> 04/03/2020 10:57, Ferruh Yigit:
>> For the ABI compatibility it is better to hide internal data structures
>> from the application as much as possible. But because of some inline
>> functions 'struct eth_dev_ops' can't be hidden completely.
>>
>> Plan is to split the 'struct eth_dev_ops' into two as ones used by
>> inline functions and ones not used, and hide the second part that not
>> used by inline functions completely to the application.
>>
>> Because of ABI break the work will be done in 20.11
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> ---
>> +* ethdev: Split the ``struct eth_dev_ops`` struct to hide it as much as possible
>> + will be done in 20.11.
>> + Currently the ``struct eth_dev_ops`` struct is accessible by the application
>> + because some inline functions, like ``rte_eth_tx_descriptor_status()``,
>> + access the struct directly.
>> + The struct will be separate in two, the ops used by inline functions will be moved
>> + next to Rx/Tx burst functions, rest of the ``struct eth_dev_ops`` struct will be
>> + moved to header file for drivers to hide it from applications.
> Acked-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
next prev parent reply other threads:[~2020-05-25 9:11 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-17 15:38 [dpdk-dev] [PATCH] " Ferruh Yigit
2020-02-18 5:07 ` Jerin Jacob
2020-02-25 12:42 ` Ferruh Yigit
2020-05-26 13:01 ` Thomas Monjalon
2020-02-18 6:01 ` Stephen Hemminger
2020-02-21 10:40 ` Ferruh Yigit
2020-02-25 10:35 ` Andrew Rybchenko
2020-02-25 11:07 ` Ananyev, Konstantin
2020-02-25 11:19 ` Andrew Rybchenko
2020-02-25 12:28 ` Ferruh Yigit
2020-02-25 12:44 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2020-02-25 15:51 ` Andrew Rybchenko
2020-02-25 16:13 ` Ferruh Yigit
2020-02-25 16:41 ` Andrew Rybchenko
2020-02-25 18:13 ` David Marchand
2020-02-25 18:18 ` Ferruh Yigit
2020-03-04 9:57 ` [dpdk-dev] [PATCH v3] " Ferruh Yigit
2020-05-24 23:18 ` Thomas Monjalon
2020-05-25 9:11 ` Andrew Rybchenko [this message]
2020-05-26 13:55 ` Thomas Monjalon
2020-05-25 10:24 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c68af930-d3fa-67bf-4d44-6f8d1a96db5e@solarflare.com \
--to=arybchenko@solarflare.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerinj@marvell.com \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=mdr@ashroe.eu \
--cc=nhorman@tuxdriver.com \
--cc=olivier.matz@6wind.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).