From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id 76B0C2BA4 for ; Thu, 20 Apr 2017 15:07:33 +0200 (CEST) Received: by mail-wm0-f41.google.com with SMTP id r190so47778056wme.1 for ; Thu, 20 Apr 2017 06:07:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=reply-to:subject:references:to:cc:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=/iYLs0gP94LpOgUyE4au1Rk91pB0/zbM8OgnZPBT1kU=; b=c1SwLZgKsfnyPinRnE6E6T4P9r0Ns7zPQ8VvZbygucG421HqJ1/wkfK15oS9GZGCqL 1vbmwyhs/nZh+eOTLeBUWeiQuPkeCaB3nbr3Kiq495kGpHzDez4qOc0GSFpIiNcHsbon fdYDpvC2QsS7mu2bGdKdqYqLACRY06tCq0NdVQzYLEgkwD+6tJhryUf0qx03uYbRnpeR 57ialmKoURGhJmNhgmiZelOmV4/RAM+nzdu5rt+gFdXA4N9uIk7yETHonolLUk9hM90I s80sgLVBtFluaqJllJ4oF6S0NB8Kh1OUnCzgGH3Z+n9rg+noAPrG/kpM7P9nVYr2taz9 FdeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:subject:references:to:cc:from :organization:message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding; bh=/iYLs0gP94LpOgUyE4au1Rk91pB0/zbM8OgnZPBT1kU=; b=qe7HMWyPweZZNZy9nZeWB8h9LlE4aHlwouH/175I8+qzvYQxKsNxdm6z2s6yS2CnBg 8PM9G0TUBFHET8tGr8b647S4ZNLcZCU9oOgT85ZEJGgCjAXpJsKcPkWlLDac1rsOTbJX 2nX9ED2cRrpc1hzkQQj4aRicPFIlJ7a5RNvNnPObPjmLyQxNBh8tFtqFSTEMebI+uB+A 8rlmrNFWXogCpTh2mCdFu+B5lma2X/vN/RnAzmbFPl4YeohAfDYN/xXw2INKV58kMUh5 7kJGiR4Te+qqEqW4ZOnYUNi4+FqSNTHuycX4ehY2+gIvtzddEpqn8dSHH+5hG2qEmruZ 6vDQ== X-Gm-Message-State: AN3rC/4wNvS6ahB4vTzvyWuK5awxeqoBtO1MKazOfvUKWbo3Cbuw33c2 2DyGJtbgMIatAevk X-Received: by 10.28.71.132 with SMTP id m4mr1021331wmi.130.1492693653164; Thu, 20 Apr 2017 06:07:33 -0700 (PDT) Received: from ?IPv6:2a01:e35:8b63:dc30:e06f:4601:8f9c:fc53? ([2a01:e35:8b63:dc30:e06f:4601:8f9c:fc53]) by smtp.gmail.com with ESMTPSA id v7sm2164259wrb.68.2017.04.20.06.07.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 20 Apr 2017 06:07:32 -0700 (PDT) References: <20170420090140.30566-1-nicolas.dichtel@6wind.com> To: Ferruh Yigit Cc: dev@dpdk.org, david.marchand@6wind.com From: Nicolas Dichtel Organization: 6WIND Message-ID: Date: Thu, 20 Apr 2017 15:07:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2] igb_uio: switch to pci_alloc_irq_vectors() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: nicolas.dichtel@6wind.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Apr 2017 13:07:33 -0000 Le 20/04/2017 à 13:59, Ferruh Yigit a écrit : > On 4/20/2017 10:01 AM, Nicolas Dichtel wrote: >> pci_enable_msix() will be removed in kernel 4.12. The new API is available >> since linux 4.8, thus let's use it. >> >> Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=aff171641d18 >> Link: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/commit/?id=4244de1c64de >> Signed-off-by: Nicolas Dichtel >> Reviewed-by: David Marchand > > <...> > >> +#if LINUX_VERSION_CODE < KERNEL_VERSION(4, 8, 0) >> +#define HAVE_PCI_ENABLE_MSIX >> +#endif > > Would you mind moving this check to the end of the file, to preserve > version check in increasing order (although I aware some doesn't fit this)? No problem. I put this stuff here to keep pci_msix stuff together. Regards, Nicolas