From: "tgw_team(腾讯网关团队)" <tgw_team@tencent.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
Tencent TGW team <quzeyao@gmail.com>,
Thomas Monjalon <thomas@monjalon.net>,
Ferruh Yigit <ferruh.yigit@intel.com>,
Andrew Rybchenko <arybchenko@solarflare.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] rte_ethdev: fix unsafe memory access by calling RX callback.
Date: Wed, 4 Mar 2020 17:44:55 +0000 [thread overview]
Message-ID: <c6af8723734e434badb97e478ba57617@tencent.com> (raw)
In-Reply-To: <20200304093747.64f1f251@hermes.lan>
So in my patch it was changed to only one memory access.
________________________________
发件人: Stephen Hemminger <stephen@networkplumber.org>
发送时间: 2020年3月5日 1:37
收件人: tgw_team(腾讯网关团队)
抄送: Tencent TGW team; Thomas Monjalon; Ferruh Yigit; Andrew Rybchenko; dev@dpdk.org
主题: Re: [dpdk-dev] [PATCH] rte_ethdev: fix unsafe memory access by calling RX callback.(Internet mail)
On Wed, 4 Mar 2020 16:38:13 +0000
tgw_team(腾讯网关团队) <tgw_team@tencent.com> wrote:
> Sorry, I`ll use a real name in patch v2.
>
> I don't think this is a TOCTOU question.
> The original code works fine when compiled with the -O3 option.
> At this point the compiler will optimize to one memory access.
> But when compiled with -O0, there will be two memory accesses, which is wrong.
> This change was modified with reference to the rte_eth_tx_burst function.
There is nothing C standard that says compiler has to do it either way.
The optimizer may decide to do two memory accesses or one.
Depending on that in anyway is bad practice.
next prev parent reply other threads:[~2020-03-04 17:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-04 14:05 Tencent TGW team
2020-03-04 14:16 ` Andrew Rybchenko
[not found] ` <61a6b7d5533643d692c40dc0ab1a2cdc@tencent.com>
2020-03-04 16:26 ` tgw_team
2020-03-04 16:15 ` Stephen Hemminger
2020-03-04 16:38 ` [dpdk-dev] [PATCH] rte_ethdev: fix unsafe memory access by calling RX callback.(Internet mail) tgw_team
2020-03-04 17:37 ` Stephen Hemminger
2020-03-04 17:44 ` tgw_team [this message]
2020-03-04 17:33 ` [dpdk-dev] [PATCH v2] rte_ethdev: safer memory access by calling Rx callback ZY Qiu
2020-03-04 17:56 ` Stephen Hemminger
2020-03-04 18:31 ` tgw_team
2020-03-05 9:19 ` Bruce Richardson
2020-03-05 11:27 ` Ananyev, Konstantin
2020-03-05 14:23 ` tgw_team
2020-03-05 14:47 ` Liang, Ma
2020-03-05 15:19 ` Ananyev, Konstantin
2020-03-05 15:42 ` Liang, Ma
2020-03-05 16:47 ` [dpdk-dev] [PATCH v3] rte_ethdev: safer memory access by calling Rx/Tx callback ZY Qiu
2020-03-05 17:23 ` Jerin Jacob
2020-03-11 12:22 ` Ananyev, Konstantin
2020-03-11 12:26 ` Jerin Jacob
2020-10-01 15:14 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6af8723734e434badb97e478ba57617@tencent.com \
--to=tgw_team@tencent.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=quzeyao@gmail.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).