From: Thierry Herbelot <thierry.herbelot@6wind.com>
To: Thomas Monjalon <thomas@monjalon.net>,
Ruifeng Wang <Ruifeng.Wang@arm.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"jerinj@marvell.com" <jerinj@marvell.com>,
"Honnappa Nagarahalli" <Honnappa.Nagarahalli@arm.com>,
"Juraj Linkeš" <juraj.linkes@pantheon.tech>, nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH V6] config/arm: add Qualcomm Centriq 2400 part number
Date: Fri, 18 Jun 2021 10:53:39 +0200 [thread overview]
Message-ID: <c6c7fc0b-1779-1caf-40b8-43e8f9ebd070@6wind.com> (raw)
In-Reply-To: <17848474.vh7KFhE8Hu@thomas>
On 6/18/21 10:51 AM, Thomas Monjalon wrote:
> 18/06/2021 04:09, Ruifeng Wang:
>> From: Thierry Herbelot <thierry.herbelot@6wind.com>
>>> 'part_number_config': {
>>> - '0xc00': {'machine_args': ['-march=armv8-a+crc']}
>>> + '0x800': {'machine_args': ['-march=armv8-a+crc']},
>>> + '0xc00': {'machine_args': ['-march=armv8-a+crc']},
>> Nit, redundant comma at the end of the line.
>
> What is redundant?
The comma at the end of the second line is not necessary.
Thierry
--
Thierry Herbelot
Senior Software Engineer
Tel: +33 1 39 30 92 61
http://www.6wind.com/
Follow us:
https://www.linkedin.com/company/6wind/
https://twitter.com/6WINDsoftware
https://www.youtube.com/user/6windsoftware
next prev parent reply other threads:[~2021-06-18 8:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-25 8:16 [dpdk-dev] [PATCH] " Thierry Herbelot
2021-05-25 8:18 ` Thomas Monjalon
2021-05-25 8:24 ` [dpdk-dev] [PATCH v2] " Thierry Herbelot
2021-06-17 7:06 ` Thomas Monjalon
2021-06-17 7:21 ` David Marchand
2021-06-17 7:24 ` Ruifeng Wang
2021-06-17 7:28 ` Ruifeng Wang
2021-06-17 8:16 ` [dpdk-dev] [PATCH V3] " Thierry Herbelot
2021-06-17 10:03 ` Ruifeng Wang
2021-06-17 11:24 ` Thierry Herbelot
2021-06-17 14:46 ` Ruifeng Wang
2021-06-17 11:36 ` [dpdk-dev] [PATCH V4] " Thierry Herbelot
2021-06-17 11:44 ` [dpdk-dev] [PATCH V5] " Thierry Herbelot
2021-06-17 15:13 ` [dpdk-dev] [PATCH V6] " Thierry Herbelot
2021-06-18 2:09 ` Ruifeng Wang
2021-06-18 8:51 ` Thomas Monjalon
2021-06-18 8:53 ` Thierry Herbelot [this message]
2021-06-18 8:58 ` Thomas Monjalon
2021-06-21 1:52 ` Ruifeng Wang
2021-07-09 15:27 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6c7fc0b-1779-1caf-40b8-43e8f9ebd070@6wind.com \
--to=thierry.herbelot@6wind.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=Ruifeng.Wang@arm.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=juraj.linkes@pantheon.tech \
--cc=nd@arm.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).