From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 57E52A0562; Fri, 3 Apr 2020 21:24:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8798C1BF57; Fri, 3 Apr 2020 21:24:13 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id EE0721BF31 for ; Fri, 3 Apr 2020 21:24:11 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200403192411euoutp026434ff8fec8786188d3826d146200726~CZbYAVwx-1680116801euoutp02k for ; Fri, 3 Apr 2020 19:24:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200403192411euoutp026434ff8fec8786188d3826d146200726~CZbYAVwx-1680116801euoutp02k DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1585941851; bh=0NvalZ4ERnfj8P5UN1fnMTmAt9u0lznt0GpdHoxsYA8=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=oMnSMPvATbTKZEL9MLSuWjoQOjadHYlrukVUSjcrRu7EN0o9z67fSyxOxvWGS+eB4 i5TUkvsr77hrv+mIWEwb2Fm34sMwNzU4Xtt/PSwMaRU9dl2RZs/irlo7dtYykJgiN/ q+CdGw24R7LBQrcuh6vjDjNmcprnvfjdtHuTcO3M= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200403192411eucas1p173cc677725db51501e162c174465ba3a~CZbX6liPs0093800938eucas1p1A; Fri, 3 Apr 2020 19:24:11 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id AE.71.60679.A5D878E5; Fri, 3 Apr 2020 20:24:10 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200403192410eucas1p10813861a502d1075eb8a69a5735dee29~CZbXeuCbU2059320593eucas1p1s; Fri, 3 Apr 2020 19:24:10 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200403192410eusmtrp2d81c596e7ceffb21fe92ff74b40b32ee~CZbXeKh9M2331323313eusmtrp2d; Fri, 3 Apr 2020 19:24:10 +0000 (GMT) X-AuditID: cbfec7f4-0e5ff7000001ed07-e6-5e878d5a743f Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 68.29.08375.A5D878E5; Fri, 3 Apr 2020 20:24:10 +0100 (BST) Received: from [106.210.88.70] (unknown [106.210.88.70]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200403192410eusmtip2f87325bc9caae11fa42e2f342b8fbf5d~CZbW-9kns2064720647eusmtip23; Fri, 3 Apr 2020 19:24:09 +0000 (GMT) To: Akhil Goyal , Thomas Monjalon , "declan.doherty@intel.com" Cc: "dev@dpdk.org" From: Lukasz Wojciechowski Message-ID: Date: Fri, 3 Apr 2020 21:24:08 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: Content-Transfer-Encoding: 8bit Content-Language: en-US X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprFKsWRmVeSWpSXmKPExsWy7djPc7pRve1xBivX21isPzOP0eLNgyYW i3eftjNZfHpwgsWBxePXgqWsHov3vGTyOHZzGrvHxnc7mAJYorhsUlJzMstSi/TtErgyDs/q Yi84J1Gxd91r5gbGB8JdjJwcEgImEqdOvmHrYuTiEBJYwSjx9lgLE4TzhVFi173XUJnPjBL/ D65ggmm5d+0vO0RiOaNE1+fJrBDOW0aJ5/OWsoBUCQsESnzd9h+sSkSglVHi2cPfbCAJZgFF iU/bZoMVsQnYShyZ+ZUVxOYVcJNoeXOKGcRmEVCReH17LSOILSoQK3Hu0Q2oGkGJkzOfgPVy AsW7P96Amikv0bx1NjOELS5x68l8sCckBKazS9zqfssIcbeLxJ0tk1ggbGGJV8e3sEPYMhL/ d8I0bGOUuPr7JyOEs59R4nrvCqgqa4nD/0Be4ABaoSmxfpc+RNhRYkLLA3aQsIQAn8SNt4IQ R/BJTNo2nRkizCvR0SYEUa0n8bRnKiPM2j9rn7BMYFSaheS1WUjemYXknVkIexcwsqxiFE8t Lc5NTy02ykst1ytOzC0uzUvXS87P3cQITDGn/x3/soNx15+kQ4wCHIxKPLw3RNrjhFgTy4or cw8xSnAwK4nwOs5ojRPiTUmsrEotyo8vKs1JLT7EKM3BoiTOa7zoZayQQHpiSWp2ampBahFM lomDU6qBkVOSufafnJt2rcBVLu8z+/fb5R2VWXtdxswj50vD8md/OXKv2q1vO8n0gn3Zvn3n tqyf0BF31uEHQ46ZyefIWL6T717tOBrh6z3HMmPjPu1drzayVuVOuC2Q+ry7d9/NfbH5q+2y Xe5xLux5uX6OYOOsKT93WnZFzpC7tfTEXC2x2J/rs0/dDVViKc5INNRiLipOBADdy/5uLQMA AA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrNIsWRmVeSWpSXmKPExsVy+t/xe7pRve1xBlNuKVisPzOP0eLNgyYW i3eftjNZfHpwgsWBxePXgqWsHov3vGTyOHZzGrvHxnc7mAJYovRsivJLS1IVMvKLS2yVog0t jPQMLS30jEws9QyNzWOtjEyV9O1sUlJzMstSi/TtEvQyDs/qYi84J1Gxd91r5gbGB8JdjJwc EgImEveu/WXvYuTiEBJYyigxs+sGWxcjB1BCRuLDJQGIGmGJP9e62CBqXjNK3Jq1mBkkISwQ KPF123+wZhGBVkaJezOOsoEkmAUUJT5tm80C0bGMSaJ/3j2wBJuArcSRmV9ZQWxeATeJljen wCaxCKhIvL69lhHEFhWIlehv3s0IUSMocXLmExYQmxMo3v3xBtQCM4l5mx8yQ9jyEs1bZ0PZ 4hK3nsxnmsAoNAtJ+ywkLbOQtMxC0rKAkWUVo0hqaXFuem6xoV5xYm5xaV66XnJ+7iZGYERt O/Zz8w7GSxuDDzEKcDAq8fAaiLfHCbEmlhVX5h5ilOBgVhLhdZzRGifEm5JYWZValB9fVJqT WnyI0RTouYnMUqLJ+cBozyuJNzQ1NLewNDQ3Njc2s1AS5+0QOBgjJJCeWJKanZpakFoE08fE wSnVwDjbjPmz9ywjRa0PoVxXDNNmZVhf1p4UEWx6zyc0mWex9fuk9kNcf7wv6qy7bdNRc2vN mf2SnSJhpyZmVWvGbjnWmn544dLQxLmLYh5F/t1zfMclpbN6T1lP7Pjlk/y97nvg6sVLqg4k NzXPrQ14s+vz7ziztlw219qnels2PXzP5vTz/g2Zq8xKLMUZiYZazEXFiQCnbfFkvgIAAA== X-CMS-MailID: 20200403192410eucas1p10813861a502d1075eb8a69a5735dee29 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20200312151709eucas1p2df38aed23b7445d3db7d4d3ea8fe3222 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200312151709eucas1p2df38aed23b7445d3db7d4d3ea8fe3222 References: <20200312151654.7218-1-l.wojciechow@partner.samsung.com> <20200312151654.7218-6-l.wojciechow@partner.samsung.com> Subject: Re: [dpdk-dev] [PATCH 05/13] app/test: introduce librte_security tests X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Dear Akhil, W dniu 01.04.2020 o 19:09, Akhil Goyal pisze: > Hi Lukasz, > > >> This patch introduces set of unit tests of librte_security API functions. >> Tests are added to dpdk-test application and can be run with >> "security_autotest" runtime command. >> >> This is the first patch in the series of patches as adding all test cases >> for all API functions in a single patch would make it unreadable. >> >> This patch defines structure of the file and necessary test framework >> initialization. It also contains first subset of unit tests for >> rte_security_session_create API function. >> >> Structure of the tests file is following: >> - macros for making tests more readable; >> - mockup structures and functions for rte_security_ops; >> - test suite and test cases setup and teardown functions; >> - tests functions; >> - declaration of testcases. >> >> Signed-off-by: Lukasz Wojciechowski >> Change-Id: I3a4585f56ef1a75b2984fcea3a3e4a30e4c2d8a6 >> --- > This patchset has a lot of repeated(for each API) tests just to check the input parameters to > Rte_security APIs. I am not sure what value addition is done to separate out each API as a separate > Negative Test. Instead a single case can be added to test all APIs with inappropriate arguments. > We should add more positive cases with proper session parameters. > > Thomas, > Do we allow these type of test cases in other modules? > > Regards, > Akhil As I already replied to you and Thomas, my primary intention was to make fixes to rte_security lib. And as I did, I wanted to cover them also with unit tests. And as these are unit tests, there is plenty of them and all they do is to verify input parameters and check if proper functions are running and the code exists function in proper places with proper return values. So they verify the flow inside each API function. In my opinion it is best to have a single testcase to check single function flow with set conditions. So if anything fails in the future, you will know exactly what and why. As the unit tests verify flow of the function, usualy they can fail in many ways, but the "proper" path to execute a function is only one, so there are much less positive testcases. Maybe more positive testcases you can see in the last patch containing tests for rte_security_capability_get. There are many testcases showing matches of capabilities to different patterns. What you would like to have are functional tests not only for librte_security but together with its usage. I agree that would be nice to have such tests also, but those wouldn't test rte_security by itself, they would test its usage and that's completely different thing and that's not what these patches provide. I'll check more modules to see how the tests look like there and I'll take a look at eventdev-tests, that Thomas mentioned. Best regards Lukasz -- Lukasz Wojciechowski Principal Software Engineer Samsung R&D Institute Poland Samsung Electronics Office +48 22 377 88 25 l.wojciechow@partner.samsung.com