From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 56E842030 for ; Thu, 20 Jul 2017 14:28:08 +0200 (CEST) Received: by mail-wm0-f44.google.com with SMTP id g127so25468518wmd.0 for ; Thu, 20 Jul 2017 05:28:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=upXNwOWMLS5pXTfuuzSjGfpcxjhglW1u3Vhnc22FCpY=; b=VLVH2lYRACPqAnT22ChubXq48haBNjhv6U2mvYZnKtJb2K7k2/saTfSr7ynhhNGXlQ 455cH2Sz5ANS1SUbJPu2TjP0k4yifBKF0003UWmcJCrWl4p43XxejKJdJRoVHIWYp1eV xjkBiRDcigu3MiwVX/Plgm4mDCu6ucF6ZnCr0AP86YKEozCB5RHOtyJnZVV1umF9ahH5 uYRA4fCT+AvHLxBVN/+ZphZrYgWuafLVsh/oXncVqYTrofPJda7fhZVGLM28u87ud9a8 tMQlnC7zmUDeNicg8Q+iHN2so4pAucMN/zaaeZgGi9y6ESJMkdNndG7S9ooxUjAcJ4eN qn7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=upXNwOWMLS5pXTfuuzSjGfpcxjhglW1u3Vhnc22FCpY=; b=eL0RT8Yx6YER0384bJRZnb4gVe5q+SJoMB/KtykJxPxlbqUEL6ku9FLFTGK6cjH5Nz Lksrkp+QlzzCL88JrGYBE5cFUxp0fUFg+PD+mYIIKfmnKWieq7EqOSjDIedTvIymEiZD WN26yX1iHbRitsazJQC8/3aWA6jn2d67+K8dJbutYzI1+QAbO6FCaAMvO1GHXQuNm7yh 26od+W5iYHLOXh3eMT7tX1XQEjMEtBDHJCrPWXWKCOUUxos8YPlMzfFpcXsVsSSE/t8i t6CL034zlZ5uaTUzHZ4rwqX+2ei3Kwznkv8Gi4GhWezcnQyPsatVS0dwEm0muiouLxjE c2/A== X-Gm-Message-State: AIVw110aUK5wOaUyGmeQWJfoi2JAHVEPC52l8zsGN2p3FMPKLY4pile/ fwwD+Hz5q74rvUq8rDc= X-Received: by 10.28.147.137 with SMTP id v131mr2138644wmd.98.1500553687376; Thu, 20 Jul 2017 05:28:07 -0700 (PDT) Received: from bidouze.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id i67sm5326794wri.61.2017.07.20.05.28.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 20 Jul 2017 05:28:06 -0700 (PDT) From: Gaetan Rivet To: dev@dpdk.org Cc: Gaetan Rivet Date: Thu, 20 Jul 2017 14:27:53 +0200 Message-Id: X-Mailer: git-send-email 2.1.4 Subject: [dpdk-dev] [PATCH] net/failsafe: fix build error on BSD 10 / GCC 4.8 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Jul 2017 12:28:08 -0000 ctype.h is not compilable in BSD 10 on GCC 4.8 in C11 mode. == Build drivers/net/failsafe CC failsafe.o In file included from /usr/include/_ctype.h:94:0, from /usr/include/ctype.h:46, from /root/dpdk.org/build/include/rte_common.h:50, from /root/dpdk.org/build/include/rte_memory.h:57, from /root/dpdk.org/build/include/rte_malloc.h:45, from /root/dpdk.org/drivers/net/failsafe/failsafe.c:35: /usr/include/runetype.h:92:22: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'const' extern _Thread_local const _RuneLocale *_ThreadRuneLocale; ^ /usr/include/runetype.h: In function '__getCurrentRuneLocale': /usr/include/runetype.h:96:6: error: '_ThreadRuneLocale' undeclareds (first use in this function) if (_ThreadRuneLocale) ^ /usr/include/runetype.h:96:6: note: each undeclared identifier is reported only once for each function it appears in /root/dpdk.org/mk/internal/rte.compile-pre.mk:138: recipe for target 'failsafe.o' failed The fix is to put GCC in gnu99 mode instead. Fixes: a46f8d584eb8 ("net/failsafe: add fail-safe PMD") Signed-off-by: Gaetan Rivet --- drivers/net/failsafe/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/failsafe/Makefile b/drivers/net/failsafe/Makefile index 32aaaa2..d516d36 100644 --- a/drivers/net/failsafe/Makefile +++ b/drivers/net/failsafe/Makefile @@ -50,7 +50,7 @@ SRCS-$(CONFIG_RTE_LIBRTE_PMD_FAILSAFE) += failsafe_flow.c # No exported include files # Basic CFLAGS: -CFLAGS += -std=c11 -Wextra +CFLAGS += -std=gnu99 -Wextra CFLAGS += -O3 CFLAGS += -I. CFLAGS += -D_DEFAULT_SOURCE -- 2.1.4