From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Nic Chautru <nicolas.chautru@intel.com>,
dev@dpdk.org, thomas@monjalon.net
Cc: trix@redhat.com, mdr@ashroe.eu, bruce.richardson@intel.com,
hemant.agrawal@nxp.com, david.marchand@redhat.com,
stephen@networkplumber.org, hernan.vargas@intel.com
Subject: Re: [PATCH v4 12/14] baseband/acc: add device status and vf2pf comms
Date: Fri, 23 Sep 2022 11:23:10 +0200 [thread overview]
Message-ID: <c76c3b0f-fe8e-a7ae-d847-477474e9c5d6@redhat.com> (raw)
In-Reply-To: <1663806460-45162-13-git-send-email-nicolas.chautru@intel.com>
On 9/22/22 02:27, Nic Chautru wrote:
> Add support to expose the device status seen from the
> host through v2pf mailbox communication.
>
> Signed-off-by: Nic Chautru <nicolas.chautru@intel.com>
> ---
> drivers/baseband/acc/rte_acc200_pmd.c | 61 +++++++++++++++++++++++++----------
> 1 file changed, 44 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/baseband/acc/rte_acc200_pmd.c b/drivers/baseband/acc/rte_acc200_pmd.c
> index b8b621a..3c2931b 100644
> --- a/drivers/baseband/acc/rte_acc200_pmd.c
> +++ b/drivers/baseband/acc/rte_acc200_pmd.c
> @@ -201,23 +201,47 @@
> rte_bbdev_log_debug(
> "%s Config LLR SIGN IN/OUT %s %s QG %u %u %u %u %u AQ %u %u %u %u %u Len %u %u %u %u %u\n",
> (d->pf_device) ? "PF" : "VF",
> - (acc_conf->input_pos_llr_1_bit) ? "POS" : "NEG",
> - (acc_conf->output_pos_llr_1_bit) ? "POS" : "NEG",
> - acc_conf->q_ul_4g.num_qgroups,
> - acc_conf->q_dl_4g.num_qgroups,
> - acc_conf->q_ul_5g.num_qgroups,
> - acc_conf->q_dl_5g.num_qgroups,
> - acc_conf->q_fft.num_qgroups,
> - acc_conf->q_ul_4g.num_aqs_per_groups,
> - acc_conf->q_dl_4g.num_aqs_per_groups,
> - acc_conf->q_ul_5g.num_aqs_per_groups,
> - acc_conf->q_dl_5g.num_aqs_per_groups,
> - acc_conf->q_fft.num_aqs_per_groups,
> - acc_conf->q_ul_4g.aq_depth_log2,
> - acc_conf->q_dl_4g.aq_depth_log2,
> - acc_conf->q_ul_5g.aq_depth_log2,
> - acc_conf->q_dl_5g.aq_depth_log2,
> - acc_conf->q_fft.aq_depth_log2);
> + (acc200_conf->input_pos_llr_1_bit) ? "POS" : "NEG",
> + (acc200_conf->output_pos_llr_1_bit) ? "POS" : "NEG",
> + acc200_conf->q_ul_4g.num_qgroups,
> + acc200_conf->q_dl_4g.num_qgroups,
> + acc200_conf->q_ul_5g.num_qgroups,
> + acc200_conf->q_dl_5g.num_qgroups,
> + acc200_conf->q_fft.num_qgroups,
> + acc200_conf->q_ul_4g.num_aqs_per_groups,
> + acc200_conf->q_dl_4g.num_aqs_per_groups,
> + acc200_conf->q_ul_5g.num_aqs_per_groups,
> + acc200_conf->q_dl_5g.num_aqs_per_groups,
> + acc200_conf->q_fft.num_aqs_per_groups,
> + acc200_conf->q_ul_4g.aq_depth_log2,
> + acc200_conf->q_dl_4g.aq_depth_log2,
> + acc200_conf->q_ul_5g.aq_depth_log2,
> + acc200_conf->q_dl_5g.aq_depth_log2,
> + acc200_conf->q_fft.aq_depth_log2);
> +}
> +
> +static inline void
> +acc200_vf2pf(struct acc_device *d, unsigned int payload)
> +{
> + acc_reg_write(d, HWVfHiVfToPfDbellVf, payload);
> +}
> +
> +/* Request device status information */
> +static inline uint32_t
> +acc200_device_status(struct rte_bbdev *dev)
> +{
> + struct acc_device *d = dev->data->dev_private;
> + uint32_t reg, time_out = 0;
> + if (d->pf_device)
> + return RTE_BBDEV_DEV_NOT_SUPPORTED;
> + acc200_vf2pf(d, ACC_VF2PF_STATUS_REQUEST);
> + reg = acc_reg_read(d, HWVfHiPfToVfDbellVf);
> + while ((time_out < ACC200_STATUS_TO) && (reg == RTE_BBDEV_DEV_NOSTATUS)) {
> + usleep(ACC200_STATUS_WAIT); /*< Wait or VF->PF->VF Comms */
> + reg = acc_reg_read(d, HWVfHiPfToVfDbellVf);
> + time_out++;
> + }
> + return reg;
Please add new lines for clarity.
> }
>
> /* Checks PF Info Ring to find the interrupt cause and handles it accordingly */
> @@ -537,6 +561,7 @@
>
> /* Mark as configured properly */
> d->configured = true;
> + acc200_vf2pf(d, ACC_VF2PF_USING_VF);
>
> rte_bbdev_log_debug(
> "ACC200 (%s) configured sw_rings = %p, sw_rings_iova = %#"
> @@ -1047,6 +1072,8 @@
>
> /* Read and save the populated config from ACC200 registers */
> fetch_acc200_config(dev);
> + /* Check the status of device */
> + dev_info->device_status = acc200_device_status(dev);
>
> /* Exposed number of queues */
> dev_info->num_queues[RTE_BBDEV_OP_NONE] = 0;
With cosmetics fixed:
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
next prev parent reply other threads:[~2022-09-23 9:23 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-22 0:27 From: Nic Chautru <nicolas.chautru@intel.com> Nic Chautru
2022-09-22 0:27 ` [PATCH v4 01/14] baseband/acc100: remove unused registers Nic Chautru
2022-09-22 0:37 ` Chautru, Nicolas
2022-09-22 13:08 ` Maxime Coquelin
2022-09-22 13:09 ` Maxime Coquelin
2022-09-22 0:27 ` [PATCH v4 02/14] baseband/acc100: refactor to segregate common code Nic Chautru
2022-09-22 13:15 ` Maxime Coquelin
2022-09-22 0:27 ` [PATCH v4 03/14] baseband/acc: rename directory from acc100 to acc Nic Chautru
2022-09-22 13:17 ` Maxime Coquelin
2022-09-22 18:06 ` Chautru, Nicolas
2022-09-22 0:27 ` [PATCH v4 04/14] baseband/acc: introduce PMD for ACC200 Nic Chautru
2022-09-22 14:01 ` Maxime Coquelin
2022-09-22 0:27 ` [PATCH v4 05/14] baseband/acc: add HW register definitions " Nic Chautru
2022-09-22 14:04 ` Maxime Coquelin
2022-09-22 0:27 ` [PATCH v4 06/14] baseband/acc: add info get function " Nic Chautru
2022-09-22 14:11 ` Maxime Coquelin
2022-09-22 18:20 ` Chautru, Nicolas
2022-09-22 0:27 ` [PATCH v4 07/14] baseband/acc: add queue configuration " Nic Chautru
2022-09-22 14:30 ` Maxime Coquelin
2022-09-22 18:51 ` Chautru, Nicolas
2022-09-22 0:27 ` [PATCH v4 08/14] baseband/acc: add LDPC processing functions Nic Chautru
2022-09-23 8:29 ` Maxime Coquelin
2022-09-23 21:55 ` Chautru, Nicolas
2022-09-27 13:12 ` Maxime Coquelin
2022-09-22 0:27 ` [PATCH v4 09/14] baseband/acc: add LTE " Nic Chautru
2022-09-23 8:59 ` Maxime Coquelin
2022-09-23 22:21 ` Chautru, Nicolas
2022-09-27 13:33 ` Maxime Coquelin
2022-09-22 0:27 ` [PATCH v4 10/14] baseband/acc: add support for FFT operations Nic Chautru
2022-09-23 9:05 ` Maxime Coquelin
2022-09-23 22:31 ` Chautru, Nicolas
2022-09-22 0:27 ` [PATCH v4 11/14] baseband/acc: support interrupt Nic Chautru
2022-09-23 9:17 ` Maxime Coquelin
2022-09-23 22:58 ` Chautru, Nicolas
2022-09-22 0:27 ` [PATCH v4 12/14] baseband/acc: add device status and vf2pf comms Nic Chautru
2022-09-23 9:23 ` Maxime Coquelin [this message]
2022-09-24 0:04 ` Chautru, Nicolas
2022-09-22 0:27 ` [PATCH v4 13/14] baseband/acc: add PF configure companion function Nic Chautru
2022-09-23 9:26 ` Maxime Coquelin
2022-09-24 0:20 ` Chautru, Nicolas
2022-09-27 13:56 ` Maxime Coquelin
2022-09-22 0:27 ` [PATCH v4 14/14] baseband/acc: simplify meson dependency Nic Chautru
2022-09-23 11:41 ` From: Nic Chautru <nicolas.chautru@intel.com> Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c76c3b0f-fe8e-a7ae-d847-477474e9c5d6@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=hernan.vargas@intel.com \
--cc=mdr@ashroe.eu \
--cc=nicolas.chautru@intel.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).