From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 07D97A04CC; Fri, 15 Nov 2019 18:11:59 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E4B252AB; Fri, 15 Nov 2019 18:11:57 +0100 (CET) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id A6328235 for ; Fri, 15 Nov 2019 18:11:55 +0100 (CET) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us2.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 1501D8006D; Fri, 15 Nov 2019 17:11:54 +0000 (UTC) Received: from [192.168.1.192] (188.242.181.57) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 15 Nov 2019 17:11:34 +0000 To: Stephen Hemminger CC: Ajit Khaparde , Somnath Kotur , Rahul Lakkireddy , Wenzhuo Lu , John Daley , Hyong Youb Kim , Qi Zhang , Xiao Wang , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , Beilei Xing , Jingjing Wu , Qiming Yang , Konstantin Ananyev , Shijith Thotton , Srisivasubramanian Srinivasan , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , Stephen Hemminger , "K. Y. Srinivasan" , Haiyang Zhang , Alejandro Lucero , Rasesh Mody , "Shahed Shaikh" , Jerin Jacob , "Maciej Czekaj" , Yong Wang , References: <1573749654-30038-1-git-send-email-arybchenko@solarflare.com> <20191114085614.5fbaeaf9@hermes.lan> <94cfd18c-5906-a4b7-e9aa-06db327af30b@solarflare.com> <20191115083553.0469a4a2@hermes.lan> From: Andrew Rybchenko Message-ID: Date: Fri, 15 Nov 2019 20:11:25 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191115083553.0469a4a2@hermes.lan> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [188.242.181.57] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-25044.003 X-TM-AS-Result: No-6.702600-8.000000-10 X-TMASE-MatchedRID: hls5oAVArl/4ECMHJTM/ufZvT2zYoYOwC/ExpXrHizxcpms3pMhT0V1o 7wPE6VhYMnzrIbW+DFzNKcBEANQ7gR6fVTIELQp78pRHzcG+oi1KgIbix5+XxEFungmhsSsCi83 62cmVmYDxdUjf0kJGdJ8xc1an3KaqHzpIYp97uNYylU6xjA3vw8GcvcBoab2jCXjDiV/HPZw2Co lXkFDPBrLFzVWms74CoDLidlyRHpwDpmiSD/gHb7RjNHAQ1DONWw/S0HB7eoMNndh54x9s7LHgx jbumUkv7Oh9VcwIBVORk6XtYogiau9c69BWUTGwRjjVhf+j/wp0ys7vJzQj/Cq2rl3dzGQ1imkn +s9We/F0rMn6yvk3G4eS2Us7bBJPMC7R5xrmdGnM22egoBvJIV+rsOixKPY1tuBbtYj+pFjni+6 QMF+VO4aWoOEeKpZ/5EMuxQW2NrAGxECHxaZMBwbZYBYdvap6SswcLuSaZJZzlLqE1zO6+EMMpr cbiest X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--6.702600-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-25044.003 X-MDID: 1573837915-wjZ0feaMtxgD Subject: Re: [dpdk-dev] [PATCH 1/3] drivers/net: fix RSS hash offload set if Rx mode is RSS only X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/15/19 7:35 PM, Stephen Hemminger wrote: > On Fri, 15 Nov 2019 12:41:16 +0300 > Andrew Rybchenko wrote: > >> Hi Stephen, >> >> On 11/14/19 7:56 PM, Stephen Hemminger wrote: >>> On Thu, 14 Nov 2019 16:40:50 +0000 >>> Andrew Rybchenko wrote: >>> >>>> By default RSS hash delivery (offload) is bound to RSS mode and >>>> it is incorrect to advertise it as enabled if Rx multi-queue mode >>>> has no RSS. >>>> >>>> Fixes: 8b945a7f7dcb ("drivers/net: update Rx RSS hash offload capabilities") >>>> >>>> Signed-off-by: Andrew Rybchenko >>> If you have to change so many drivers, why not just handle it in >>> common rte_ethdev code? >> rte_ethdev cannot set the offload itself since it has no knowledge that >> the offload cannot be disabled. >> rte_ethdev can blacklist the automatically set offloads in the case of >> non-RSS Rx multi-queue mode, but I don't like it since it adds to many >> layers where we change offloads. >> That's why I prefer this way. >> >> Andrew. > Makes sense, just concerned that other (or new) drivers will > have same issue. Yes, that's true, we should try to find a better solution, but I don't see any better solution right now. I'll keep it in my head.