From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5E0BEA00C3; Fri, 17 Jun 2022 17:37:04 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F3B4A42B7E; Fri, 17 Jun 2022 17:37:03 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id B9CE440F19 for ; Fri, 17 Jun 2022 17:37:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655480222; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AbJ4m0x5ZYBBQwnsuI7Y2yeeCPyFVH+EiJid8hkNQfo=; b=gFqvofsmIfVsMTBgZ5xT28zBC1r5QeGsvjtq+SjY3wdgdWN6Ulo6MDTatWYo+0YNzwg80I 9lPAGNhgaCI0kxKYdzDVo0dd+ZI4t8nx9eyIVzmhVaW4RnYi/P92xRhhKEExv0Cao9rg6+ OIHz7WbR2vUhrJzKA1xVbB+2xcWxtWQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-633-QfKqPkKPN5KGoC-pwH9rfg-1; Fri, 17 Jun 2022 11:36:59 -0400 X-MC-Unique: QfKqPkKPN5KGoC-pwH9rfg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 59A8C905185; Fri, 17 Jun 2022 15:36:58 +0000 (UTC) Received: from [10.39.208.34] (unknown [10.39.208.34]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 90F981121314; Fri, 17 Jun 2022 15:36:56 +0000 (UTC) Message-ID: Date: Fri, 17 Jun 2022 17:36:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v2 02/15] vdpa/mlx5: support pre create virtq resource To: Li Zhang , orika@nvidia.com, viacheslavo@nvidia.com, matan@nvidia.com, shahafs@nvidia.com Cc: dev@dpdk.org, thomas@monjalon.net, rasland@nvidia.com, roniba@nvidia.com, Yajun Wu References: <20220408075606.33056-1-lizh@nvidia.com> <20220616023012.16013-1-lizh@nvidia.com> <20220616023012.16013-3-lizh@nvidia.com> From: Maxime Coquelin In-Reply-To: <20220616023012.16013-3-lizh@nvidia.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/16/22 04:29, Li Zhang wrote: > From: Yajun Wu > > The motivation of this change is to reduce vDPA device queue creation > time by create some queue resource in vDPA device probe stage. s/create/creating/ > > In VM live migration scenario, this can reduce 0.8ms for each queue > creation, thus reduce LM network downtime. > > To create queue resource(umem/counter) in advance, we need to know > virtio queue depth and max number of queue VM will use. > > Introduce two new devargs: queues(max queue pair number) and queue_size > (queue depth). Two args must be both provided, if only one argument > provided, the argument will be ignored and no pre-creation. > > The queues and queue_size must also be identical to vhost configuration > driver later receive. Otherwise either the pre-create resource is wasted > or missing or the resource need destroy and recreate(in case queue_size > mismatch). > > Pre-create umem/counter will keep alive until vDPA device removal. > > Signed-off-by: Yajun Wu > Acked-by: Matan Azrad > --- > doc/guides/vdpadevs/mlx5.rst | 14 +++++++ > drivers/vdpa/mlx5/mlx5_vdpa.c | 75 ++++++++++++++++++++++++++++++++++- > drivers/vdpa/mlx5/mlx5_vdpa.h | 2 + > 3 files changed, 89 insertions(+), 2 deletions(-) > Reviewed-by: Maxime Coquelin Thanks, Maxime