From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id A9438432E6;
	Fri, 10 Nov 2023 12:44:05 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 96A3F40E5E;
	Fri, 10 Nov 2023 12:44:05 +0100 (CET)
Received: from agw.arknetworks.am (agw.arknetworks.am [79.141.165.80])
 by mails.dpdk.org (Postfix) with ESMTP id 7059640291
 for <dev@dpdk.org>; Fri, 10 Nov 2023 12:44:04 +0100 (CET)
Received: from debian (unknown [78.109.65.227])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by agw.arknetworks.am (Postfix) with ESMTPSA id 7CFA9E0582;
 Fri, 10 Nov 2023 15:44:03 +0400 (+04)
DKIM-Filter: OpenDKIM Filter v2.11.0 agw.arknetworks.am 7CFA9E0582
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arknetworks.am;
 s=default; t=1699616644;
 bh=MiEXsBwIIKjw3+5SzfT0M9s6YiEvuXmTOf9QH9wIAuw=;
 h=Date:From:To:cc:Subject:In-Reply-To:References:From;
 b=jeMNeFCPHwkYyiAaqglmlcNnTFmQj0CYhOvDcRk+TPi3qlSF9e2pvpsuBBP7YKuDA
 juxhk1L/RbuSXjVZO7s9Og+rcW/8ETdHYhUeYKA7H+7CmWmcnOYafLOrhBJHzzb6vY
 fTxXTbGQH6TZyoVQLS65IyExAM8jONekarVSNWzW1edYJ+YsgfhVPXRae32b60d6h9
 bABTUGhSuXQi1huakpsjMTzlO/ElvjuMheLYvguH5EHw5wRueVGbq5rciGT9ZQrKz1
 iCkUxQ/LnJNNY6FOaMcLKon4O1Z0nzED4yMspEC3oCrjSJyNuN/jHWDvAvo8KrXVr/
 eFDinHH0tOrvQ==
Date: Fri, 10 Nov 2023 15:44:00 +0400 (+04)
From: Ivan Malov <ivan.malov@arknetworks.am>
To: Chengwen Feng <fengchengwen@huawei.com>
cc: thomas@monjalon.net, ferruh.yigit@amd.com, 
 Aman Singh <aman.deep.singh@intel.com>, 
 Yuying Zhang <yuying.zhang@intel.com>, Wenxuan Wu <wenxuanx.wu@intel.com>, 
 Yuan Wang <yuanx.wang@intel.com>, 
 Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>, 
 Xuan Ding <xuan.ding@intel.com>, dev@dpdk.org
Subject: Re: [PATCH v2 14/16] app/testpmd: verify strdup return value
In-Reply-To: <20231110100117.8350-15-fengchengwen@huawei.com>
Message-ID: <c7c92c5b-745b-004a-59dc-d5d6a4772a32@arknetworks.am>
References: <20231110100117.8350-1-fengchengwen@huawei.com>
 <20231110100117.8350-15-fengchengwen@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII; format=flowed
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

Hi,

On Fri, 10 Nov 2023, Chengwen Feng wrote:

> Add verify strdup return value logic.
>
> Fixes: 52e2e7edcf48 ("app/testpmd: add protocol-based buffer split")
> Cc: stable@dpdk.org
>
> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
> ---
> app/test-pmd/cmdline.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
> index 912bf3355c..904c04d466 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -3528,6 +3528,8 @@ parse_hdrs_list(const char *str, const char *item_name, unsigned int max_items,
>
> 	nb_item = 0;
> 	char *str2 = strdup(str);
> +	if (str2 == NULL)
> +		return nb_item;
> 	cur = strtok_r(str2, ",", &tmp);
> 	while (cur != NULL) {
> 		parsed_items[nb_item] = get_ptype(cur);
> -- 
> 2.17.1
>
>

Acked-by: Ivan Malov <ivan.malov@arknetworks.am>

Thank you.