From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 02521A0C47; Thu, 14 Oct 2021 14:32:56 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D6A674112E; Thu, 14 Oct 2021 14:32:55 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 96B6640041 for ; Thu, 14 Oct 2021 14:32:53 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10136"; a="214828565" X-IronPort-AV: E=Sophos;i="5.85,372,1624345200"; d="scan'208";a="214828565" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Oct 2021 05:32:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,372,1624345200"; d="scan'208";a="491965749" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga008.jf.intel.com with ESMTP; 14 Oct 2021 05:32:48 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 14 Oct 2021 05:32:48 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 14 Oct 2021 05:32:47 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 14 Oct 2021 05:32:47 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.168) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 14 Oct 2021 05:32:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B5SzoBnpbBuWHWAdwFKk2//jv+djTxceLbbYQseN5cMh8fMwvGkh7hi5BthRR2RohUdQcS5xxts7NaGRw7S8DxXNle80HAyMKkJr+uXYmB8ZDHURhqICnGQYTlXTvZMZqaeOOC2nAAuyD3RY//GzhW6NEZ3AiRmH9mpkLGo5AY/p5P6boOcZueuM5mtuESfju2BuqXiqn/LCo3zCzwHH6xRJBwKc+OP8Bt8S7za3FawBICSNXEkR68VUjkxkRJpPfFriQTSnyamA3b7Ps8qLEhNpeM7a19AYWIOl0Be7LNKXCiqiH1wcyUUMxUxZvWjSwl67cygHfWMkal9g7bsKwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PFQJUgJwAlBoxNRuFvYS7qckUAxme5DlM9M/gW7QnNU=; b=cAG9HgyYhUBeTGvvFa7ewb96WIbR4uk4T9Y+RlolAciDw4IWnrkSOWSB86nBbM0D3oTE2zo06ohfg27/ZvlIMqrQc7iyUO5dmRPdfkCMAAx4eYPT9pElnKh0jeBKe/DBXDhg9CWcHgs/OgCKOvRvrpkcIGDgtqZJcNGQwsf2ju8ojPyQBemb3+dp7Z2olrCU0SPpPoH8Pn3ZYCKU8tV3XuqRnzDl4QUVCSlP7I2D4JQfxzV3YzrT8oJVpBGu8h/Oh6AHHEIoU7WL1HPzGKlBbvnu/65G5XXXLqtZmp3k3BSXdVezke+kRHji5/ExVOLW1+8x4dKsTPFas6aVQ07w3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PFQJUgJwAlBoxNRuFvYS7qckUAxme5DlM9M/gW7QnNU=; b=zi0kZHhkyI+zxl5ba7/0MoCBrrOYX5uQmd7Lu0xleB1+pOcUWSf5xCw5lI9DplIeC1sJFZ6YOue4/CsGoGW6u9EDvg8fEuQZxWdZYTQV8xvM2B+rOJgEy92hrdYW4aXSPdtgvA/Pxk3DwGNwY5nYClTVdqgBA8LrYOuu/J6dCa0= Authentication-Results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4982.namprd11.prod.outlook.com (2603:10b6:510:37::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Thu, 14 Oct 2021 12:32:44 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%5]) with mapi id 15.20.4608.017; Thu, 14 Oct 2021 12:32:44 +0000 Message-ID: Date: Thu, 14 Oct 2021 13:32:37 +0100 Content-Language: en-US To: Gregory Etelson , NBU-Contact-Thomas Monjalon , Slava Ovsiienko , "Ajit Khaparde" , Andrew Rybchenko , Akhil Goyal CC: "dev@dpdk.org" , Matan Azrad , "Raslan Darawsheh" , "olivier.matz@6wind.com" , Ray Kinsella References: <20210527152858.13312-1-getelson@nvidia.com> <20211013171354.27817-1-getelson@nvidia.com> <20211013171354.27817-2-getelson@nvidia.com> <10613924.v4J3Eeda0m@thomas> <96917f0b-6666-a268-2682-9c41a5d37ef8@intel.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB6PR0501CA0009.eurprd05.prod.outlook.com (2603:10a6:4:8f::19) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6PR0501CA0009.eurprd05.prod.outlook.com (2603:10a6:4:8f::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend Transport; Thu, 14 Oct 2021 12:32:42 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 531f9bff-a6a8-46e7-811d-08d98f0eb8eb X-MS-TrafficTypeDiagnostic: PH0PR11MB4982: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4941; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GK7N6uXdqVC+kfWD7CnRDL9Bh7EPmj1sYpQjAoUEqAXev7YbkOJPIWYRXDX30Dub4im0LS0BQOe6wsIRAa+tJpNNKCylYTR/tm1dzZ/bH9YvAeQy+v+bXdBCDGkqn7qaxkQamvk937zyzrIARZuoZCsoGRfXOKvXsEDRFJ4rd3IvtGnlRX9ogatNHnO4KMegy9fAI5cDb5RwZDWmDL9aOcGaGWIh8Ll8aqowsNsLnFTnClVJNvLVDDJfi+SdDlTMp/PooHs3ffntRJg1FoFadhDxPw4BSWlYaIYhO3mWOiWsskoDPR/0yp22fhqoX+B4sK9Q/Zpsl/Y44I1Yp1sUG4FrrzmyGj25mPSQ/fRf9z4VoK5c43qYFuUabfphoyUv1gXdoXfKpWyrF9Ui8AYz2Hk0GzDlskDn2izGiVSbVi2WX28Tbd9ENJAyYzdle07LkKIjocFPNQ+JB/3nvJlCGSkcLwQ31GZX0xr9K+RhvH3CtO/KaBPbPb/vgsQ3Y76BDGjsJ2PJdbV4ccwmKIkwg+RujmhgNOwOfsfeCQ21fNnwvFY3tZ3I6DWFwJtUhleuNNmMvuNnIbiPM5irjw7n6fz08+LNmKt2BwvvMupbYrhuukImfl+JSjcocDcC4yKlTIR0bxklY3NEmojxNac+EFEmvp6sD8MWEsjG594JFz3K3GaFXvrmnFEnCk19jOEJGjbi2aUg/8PcxBzypgxirQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(8676002)(2616005)(956004)(6486002)(53546011)(16576012)(7416002)(5660300002)(110136005)(4326008)(36756003)(31686004)(186003)(508600001)(44832011)(83380400001)(26005)(66476007)(316002)(2906002)(6666004)(54906003)(86362001)(66946007)(66556008)(38100700002)(31696002)(8936002)(82960400001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MUdaSVVPUGhzVEljaGl4K3o2YUFwMC8vclIrNXB2cE14QUNkcnphVEpCMVlv?= =?utf-8?B?b1BsUitPdkUzTk0xcjErU3VPVkVkcXVQMEZtOHBYbUIxTSsrNmRwVTd5MW9n?= =?utf-8?B?L1pmUlNNQWJOWXVRVzlNVi9kQ3hETCtaNE5pWmswelJCOVYybUp0amlpSWhY?= =?utf-8?B?clFjMG0rSjFQd0JRWmFuODVZVWNwUTVyT0JGVFBkem1PSkNvYTlNSTR4RWNp?= =?utf-8?B?eUYvYW9tZnM0TUtBSmlzKzdIeDlvRWE0dlIwbERZbm5BK1BVYUlleXJiN05j?= =?utf-8?B?ekZsUDFZY2l5VG1IZ01QbHdIeGpvRSs4THAwR1U3dHVEb1RsdWYwQzZBRE56?= =?utf-8?B?Um94S1JiNitTZjhhcVdweWZKWTlKOTI3R3hBNUxBcVRPSlI3RW1GVlVpTlRp?= =?utf-8?B?RE9hV0VMcUpFckh1cGJGbFZydFpIWWlsWExqd0hlTkNpTDMvWW8yQ21LOTZm?= =?utf-8?B?NzM1RVNUVGg0Tk5rYnBoYllDTmphenZRMFp5VjJxUlZnYVRrcVBTa2VkL0Fi?= =?utf-8?B?dXJnRWJyZ1lCaGZDYUw1d2NHTnpXUy8xVWFBeGdOTlZjVG9FcnNwR3k1bVBm?= =?utf-8?B?NHR5a3dnNkN3WnFTRjhRQU1zR2ZvVkpLSG44T0N6SktVR0VRd0dmQzFTdDd0?= =?utf-8?B?cUNJM3lZNjRJbHQzaVZUd25yR2xFSnVPSUYyYUdxanBYZktka1FIRk1UZHZz?= =?utf-8?B?MkJxRFZ1Qll4ZHNxYUhLVjB5WGNBQkRqNWp5OFhEVndXeXdVY0ppdzdOYi9r?= =?utf-8?B?T1Z0WU1FSWV3aG50aTdJQlJtcDF2V3NBME9wc3ZhK1Z6bytldldTdWhydWM4?= =?utf-8?B?aGtGUGdsUFhsVnlaanpqcjBDQVMzb2JWQjFvY0RWRit4SmN4TEw5eTRLcUxr?= =?utf-8?B?MTgwWlY1S2d0SENCSWYvZVVFbFVUb2lvWVlkRHp0SVB2N1crMTJ0WTE2NzVJ?= =?utf-8?B?ZUY3QXFYOUt5ZWhaYXAzNTZ4WVQ1cUxmYVczTUJLN2R2TnlNRVcwWGF0d08z?= =?utf-8?B?UnlKQ3Q4cEE4NVBzRHJMNmk0NzQ1UWQ2NjlvUXBqb0FOWkN0RUhaclg1cjQ1?= =?utf-8?B?VjFRdEJjbEhZcDhwZ1RvdWdrZkUrQzRsTmcrcTNOL2JLb3dKVktyWWJOa3N3?= =?utf-8?B?ZFVYaDh3MGRReE9FZHNPSVBFMnhBd1haWTYvdklRb3pUYmhwbGFOVE9PektC?= =?utf-8?B?Z1kvV2tkNkN0bVQveDJqZVNiV21rM0ZRT0VibDV4ZTc3RUJTekgzVFdBaXcw?= =?utf-8?B?OWE4SEJoM0hpZERWZ0FKaWpOWlN0TDJJNkNwSVdUeWhDM1o1ZHV4TVU1NFEy?= =?utf-8?B?a0xxMmI2THVvdjhkbXV1cXlVc2oxK2NZNWNiR09ES3FnTURzeTltejhsQUha?= =?utf-8?B?UjhPNVNkaHBRYmJocnF2K1RIb3E4aCtxMndtam5oeUpYeTdIbFBCakJsOGZk?= =?utf-8?B?WmFIbEkrSFZCNEc4NDlYa3RnV09EakZnSjNYWjZWQkVGWVh2U2JoelJFNFdI?= =?utf-8?B?RkNOWGxQMUZ5aTZYL1gzQ3Z1OFhnR0h3cTMvRWdRMnJLZ0VxVHhVdUd1blBH?= =?utf-8?B?b2NyRHVSWlRtVXJTK245b2gxdlpneFk1ejNYc2RlRnJlendQcHhxWWxKMnI0?= =?utf-8?B?cHFPbFhnemxsbHBHU3U4K1FxcHliVUFKU2cwbm1WRHYzcXdXclFHUEZDQy9Z?= =?utf-8?B?S2lYbzdqSEZWSHdhRERBQUs2VE9yYVZoMGh1aURmYkw4WUduRng5dUMxUE5m?= =?utf-8?Q?c+SvO1HLm0nG1Oivw17X7Oc0OCnw8n2T4ZHhtAx?= X-MS-Exchange-CrossTenant-Network-Message-Id: 531f9bff-a6a8-46e7-811d-08d98f0eb8eb X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2021 12:32:44.6920 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WZB5AWgZVHoJWba8h6L01nSEFZxRcoO6P+3Gr2fI1zWQo8w1gQuuYrDALoxHvIzELuKztiloEkUIKzpeVs3Sgg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4982 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v6 1/2] net: fix IPv4 change announce X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/14/2021 1:21 PM, Gregory Etelson wrote: > Hello Ferruh, > >> On 10/14/2021 9:37 AM, Thomas Monjalon >> wrote: >>> 13/10/2021 19:13, Gregory Etelson: >>>> IPv4 header encodes fragment information >> into 16 bits field. >>>> 3 bits hold flags and remaining 13 bits are for >> fragment offset. >>>> 13 bits bit-field cannot be defined both for big >> and little endian >>>> systems. >>>> >>>> The patch removes IPv4 fragments union >> announce. >>>> >>>> Fixes: f7383e7c7ec1 ("net: announce changes >> in IPv4 header access") >>>> >>>> Signed-off-by: Gregory Etelson >> >>> >>> OK to drop this announce. >>> There is no implementation anyway, >>> it will be back in one year if there is a solution. >>> >> >> If there is an option to have it back, why not >> keep it in the deprecation >> notice, this ensures we won't forgot it. >> > > It doesn't look that 3/13 bits split can be implemented as > > #if RTE_BYTE_ORDER == RTE_LITTLE_ENDIAN > /* LE bit-fields */ > # elif RTE_BYTE_ORDER == RTE_BIG_ENDIAN > /* BE bit-fields */ > #endif > > The minimal bits ratio for that option is 4/12. > I got your point, no objection from me there. So we want to completely abandon the change, and I expect people who acked the deprecation notice at first place would like to ack dismissing it. >>> Acked-by: Thomas Monjalon >> >>> >>> >