Re: 答复: [PATCH v6 08/17] net/r8169: add support for phy configuration

[Ferruh Yigit <ferruh.yigit@amd.com>]

On 11/11/2024 8:18 AM, 王颢 wrote:
> Dear Ferruh,
> 
> Regarding the commit message, I will think about how to write it.
> 
> I’m sorry, but for the registers in the PMD that do not use macro definitions, most of them are company confidential and their meanings will not be disclosed to the public. This part will be maintained by us.
> 

I understand, but this is conflicting with open sourcing the driver,
after patch is merged it becomes responsibility of the community, of
course primarily we will rely on you to maintain the driver, but for the
cases like refactoring, or users fixing defects etc, community members
may needs to update the driver code, and this requires for us to
understand the code.

Overall, I think there is a value to have the driver in DPDK, so please
continue upstreaming, but please try to explain and clarify the code as
much as possible.


> Best Regards,
> Howard Wang
> 
> -----邮件原件-----
> 发件人: Ferruh Yigit <ferruh.yigit@amd.com> 
> 发送时间: 2024年11月11日 8:17
> 收件人: 王颢 <howard_wang@realsil.com.cn>; dev@dpdk.org
> 抄送: pro_nic_dpdk@realtek.com
> 主题: Re: [PATCH v6 08/17] net/r8169: add support for phy configuration
> 
> 
> External mail.
> 
> 
> 
> On 11/8/2024 12:11 PM, Howard Wang wrote:
>> This patch contains phy config, ephy config and so on.
>>
>> Signed-off-by: Howard Wang <howard_wang@realsil.com.cn>
>>
> 
> <...>
> 
>> @@ -62,6 +62,12 @@ rtl_dev_start(struct rte_eth_dev *dev)
>>       struct rtl_hw *hw = &adapter->hw;
>>       int err;
>>
>> +     rtl_powerup_pll(hw);
>> +
>> +     rtl_hw_ephy_config(hw);
>> +
>> +     rtl_hw_phy_config(hw);
>> +
>>       rtl_hw_config(hw);
>>
>>       /* Initialize transmission unit */ @@ -74,6 +80,8 @@ 
>> rtl_dev_start(struct rte_eth_dev *dev)
>>               goto error;
>>       }
>>
>> +     rtl_mdio_write(hw, 0x1F, 0x0000);
>> +
>>
> 
> It is very hard know what code like above does, which makes harder for anyone to read and understand your code, can you please either create macros for registers or comment as much as possible, so others can improve/fix your code when required.
>