From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AD52B45CE7; Mon, 11 Nov 2024 10:21:18 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8E09440E0C; Mon, 11 Nov 2024 10:21:18 +0100 (CET) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2046.outbound.protection.outlook.com [40.107.93.46]) by mails.dpdk.org (Postfix) with ESMTP id 090EA40E01 for ; Mon, 11 Nov 2024 10:21:17 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=G3NhvCFlxOiRVo/bjqbohVKb//Q9OIr2HRwWyjI15uZf6JxpwKFoVs/azcV7CcAbpxXJHou0/9AgNYes+lEVaFpKR3SCp1mk7j0iaECOpefvv2SUl5N63n6vnMpNfPiGPSJZWXSVgNWgLQYyyZ73eBXUeLGNCS6+3VgG/VagSWE/6jDlg2jelrk9kUaPEZH5x8h/71wN5nGvUYUXFggDxhDHcEv6iO4FBr1Ipo2M+/9GduzEkgmgWUudFLO4vMZ4C3fs2TImBHa40rDCAakEgaMy9KPqfpflfQKyBGWKAQlTzQaHnZYqMNbTblY5FuisjQrTdaaVCYRN3mGJ8hFL9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5xaThLGuFZR+QXryL8IBV80o+DxJvF9Gn/Jr7MPncS0=; b=o9iNBmQHLqmwO4IcXHaeHRbxFSiZcsCIBWGNekKFY3KUkfBb/4KwXY6AcgAuW6b+TfVbitPRiuKfPzSRL39WIt0aDW8VVKamwq+KGnp35CqJwOMSfgiLRiWepOYHfMmrVDgWoVoAOQkO+BO5ctT3V7lPh3hg9B5tOZHibm+4rK4a2pB14gQwrcg9aTkA+2etrClcx0qvhemKwiOY+J7IITCEJow/C+9aXWJq7Cks8Ht7YaEPXz/WuC5SduDtA1U4KDTn7CuRTYPpeLe/tPB461Pb9bZQlQY1PFcyZ6RSm7Y3bq2vl5xs+Y2iNkB7/dHDE7gzdIyrSJ5Z1ccvcFUrZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5xaThLGuFZR+QXryL8IBV80o+DxJvF9Gn/Jr7MPncS0=; b=YcBXqfRZbA2krgh0TAaxNAFN7FvApXM3V7+dNbMUAPZkQKld/d63ZxTZf/25uBd43TwYDQ8y9WvtGSA6f5i8dgyZzD3WkukUWsaG52fRzSMhmxJbWH4YheVzWXX1cBgnQXCWryaKnWrqbW2r2fFo9sAPGsJWWYRJ7S3bPwZr+cg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) by SN7PR12MB7785.namprd12.prod.outlook.com (2603:10b6:806:346::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.27; Mon, 11 Nov 2024 09:21:13 +0000 Received: from SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055]) by SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055%3]) with mapi id 15.20.8137.027; Mon, 11 Nov 2024 09:21:13 +0000 Message-ID: Date: Mon, 11 Nov 2024 09:21:09 +0000 User-Agent: Mozilla Thunderbird Subject: =?UTF-8?B?UmU6IOetlOWkjTogW1BBVENIIHY2IDA4LzE3XSBuZXQvcjgxNjk6IGFk?= =?UTF-8?Q?d_support_for_phy_configuration?= To: =?UTF-8?B?546L6aKi?= , "dev@dpdk.org" Cc: "pro_nic_dpdk@realtek.com" References: <20241108121123.248797-1-howard_wang@realsil.com.cn> <20241108121123.248797-9-howard_wang@realsil.com.cn> <606cd6b0-6c68-4dd0-aa1b-e9b7fb1c3ee1@amd.com> <9b59f9b4ca364500afe34cc0cf0485f5@realsil.com.cn> Content-Language: en-US From: Ferruh Yigit In-Reply-To: <9b59f9b4ca364500afe34cc0cf0485f5@realsil.com.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DU7P191CA0028.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:54e::19) To SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR12MB8830:EE_|SN7PR12MB7785:EE_ X-MS-Office365-Filtering-Correlation-Id: 6c76ceb8-5d3b-4d0a-71b7-08dd02323035 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?MEdFakJQMEFYa1lYK05Kdk5XNFQwWE1DcStpZ0p6RVAvZGI4MWU3MnE5TENr?= =?utf-8?B?WDBhRnFTK2J2NlFXRjNaNXRvK3pDd3daNExhTVovOVNLREplZnI0Z0txSm9a?= =?utf-8?B?eXZmUmpaM1NHWVNJaU1GbFZGZGxEQTJKb0hxMnpYUXFxdEpzVGNhc0hvNGl2?= =?utf-8?B?N1dLM2Q2Tk5hYmw4djZyMG1NMmlOL2d4SzMxWUh5UHUvL2dOUVNVcm9GL0po?= =?utf-8?B?U3VvUEZYSjVRZWovc3dtRFNHTFB5dWFQQVlpcDBYa0NIN2xWT3lwVm5xWG5P?= =?utf-8?B?UHZ3MU8wZGdDZFp2b2dYbE5MVXRBd1NQR21WdXh3VXpTSkJIQ1F0Q0Q2RnJm?= =?utf-8?B?ZVdPMmUvZ1huWEY5R3dpWlNkUk5hRm9LZlE1OE5iMnpNRUVhaXJZN1Z1VkhR?= =?utf-8?B?WXJ1Uk50N0FNUGtkT2MrQm9IQk5KK3R6b1ZhczY2cE1aTTJnK25sYmNMK3NM?= =?utf-8?B?M1kwdG9rQmpQSTB0NGVEblVmL29rbjNUUm9iODlHOEZDSzZhOVdBTS9SWDB2?= =?utf-8?B?Y1IrUXNyRXc2NS9hZTE4ajltN0dDbkhaalZ2amNoN292dzZmZlp0UVRhOUFj?= =?utf-8?B?emJWT21uMkZpSHdncngvVkY1UHVHcGd3RTBuOXF3OVMydlFhUzhwTnpmaGNS?= =?utf-8?B?OXJLc1lQMkJqd2xqV0N3aGNPbE1SWU9sMUdQTGlQalI2d2w1NEdjaWVQcHE3?= =?utf-8?B?OTdYdFFGd2JkVlZ6SnA0cUtObFVzN01qSkNoOWlyNC84VWpVdi9OQkNFNUFU?= =?utf-8?B?dk16MmNnRkt3T25ib3AzeFI4V0lvbVNLRURaRDN3citpQXF4VEdua3l2THZF?= =?utf-8?B?SnN1WExQRVFnWGtEa1JRaVhHZkFpUUpWb0JEeUQxUTJEWWdkVE9tdzE1bGJ1?= =?utf-8?B?cE9kMElPRTI5aFJ0bWZOWW52ZkZqQlpuQVhobkNMdWMyOGpMUGJmQWpCR2hU?= =?utf-8?B?QkE5MHZjVkFWUFJCY2VBQTUxL01pOVNqYTFHUmM5SlYweFlZcTVuOUplOXFW?= =?utf-8?B?Wktxajkxdnc3ZjZ4VDlHUU94c0ZOMWVBUmh4aEFqaXd5alJ0TkpoRC83aEdH?= =?utf-8?B?MTBqcVRDOVU1ME1kbFhRYTNJbDZHTHIxS2ExVWVnTm5kdWl1bFFyQlVQcUVO?= =?utf-8?B?WURIUW4zV1g0RmZNQW9FTDdZWFBIbW9SRHRyL2hBQnV0WWEzanZYd3NMRlJZ?= =?utf-8?B?TlFVZ09hVWRoOUI5NHZWMEdnOXVUUjltbVdDNlhUQ016bXhubzUxSEF1Vm9q?= =?utf-8?B?QWNUSVVyU2tqRUdtMDZiSlR0alAwd3p2WnhaQVAzM3E0dis1S0xaclN6SzFa?= =?utf-8?B?OWlMRytkbGcwSjlBdWlXb0ZNelVqSGxDbU0wbEF3c1hMdkgrSlpTSTJOVGE2?= =?utf-8?B?VmZjZTZOelFwdFhTa0dRdXNnOTNyZy94S2xMblY5TjJNVnM2c2J5dExZMUhw?= =?utf-8?B?NDNZTU5RS21jK1NYVU9pQnBqUGJPdGl6WjJPQWorUkExUHhuRlljUWVQMGhF?= =?utf-8?B?Ymo3RCtlVzFaV0RLaitCRTdPOC83TGhYOE1abUtaRk9QSVhjYi9wRFhWcUgr?= =?utf-8?B?QnNzeGRhNWlIeVFpWEdvQS90WmgwNGE1ak9OSG02MDZCZGZic2tvK240TW43?= =?utf-8?B?VXZKMU1SVjRQVFZpR1NtTHNzRDUzbTJxQkgvaVdoYm1yanFzTkhOZ2JJY3M3?= =?utf-8?B?OCtxWG9SR0pEaFZ6SlYvZE1SYW1nRVpiK1NyWmZXSk1xY1NwZGt2V1IxZmdL?= =?utf-8?Q?ID4F67cW6z/4ix5Z2llIiiuW22N9iyQKq+xwJMt?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ2PR12MB8830.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZC9UWUNrQTBvMDJaU25jMGVISTJmcVZ0cnpTSVAvZW1MQmRzNnpmbmdGMml6?= =?utf-8?B?RWtzN055cC9CRzRnNnlxMzNRQi9tc0RMUy9lSE03ZUxaOStad0tsQmhxeXpH?= =?utf-8?B?U2Fyb2JiZlQ0aFFpelg4UkpPVUtRMmw3SEdsV3VuNW1TdlkxSlczcTNBQU5k?= =?utf-8?B?YzdSZmFVekdSN1NnSWxyeGlCT2NVTWVGaWp5U1ROcmNlWjVEVlN5Y1NrbmlF?= =?utf-8?B?aXJBbWVNVmxJWVhUdm1YMFZwdk92dkliUkpOZEM1b3V3VExWNDRCdkJaKytU?= =?utf-8?B?QlJsMU9KdGY0K2R1Wmlva08vK29MeGhFZ05Za1R1d3YzeW5Cd3MyaWROVGNj?= =?utf-8?B?RU1XYjVPaG8vbVlrM3g3K3FNUmhBVEwrTnpVS3QrZ1JrREphT0xuOUpKOFV5?= =?utf-8?B?eFROWWVpdkJBYTg4QUtNWkRTN2cxdVNwQ3BlWG5NaGhwZlRLK2pRM0RoS3pH?= =?utf-8?B?bStGN0haemlIVGlzemFHOEl1RmRGKzlvempPWUpIb2RMblRscERNQjMvZWNv?= =?utf-8?B?NTE4Zm5lTU11ck1mdlFjMzk2elUxM2dMNkhESWRTM1BCblk0aXVKeVJlUmd3?= =?utf-8?B?bnppNG9IbWpoT1BmR2VOb2hlVTNIZzFsZjA2K3hXNE1QVjNxd1lHSTEwejEz?= =?utf-8?B?c1JtejQ5dmJNVVA4TnNXemFRQkdteFA0MDg1TGxQSUJKZjRZYzAwRGRLNUFt?= =?utf-8?B?Q3ZQbHFZYjRiUDM2cVlySVEzZkJRc0lJZVp5UjUvRUZmemV4MVduV0szdW9h?= =?utf-8?B?NThyK2U3OXlGaVBjTWRlSDAyMW8yWFcwMUpLMllCaldPdHJOYlg3dVlwWTJO?= =?utf-8?B?eHQwbE42OUcrTDNvWkJvTUpoSmtRS3MyQkFGaG10WkxTcGEyTXVXd1FmRTJ4?= =?utf-8?B?b3llSmpweTZVcnBhTXg2ZlVaSnhnakNaMVZpcW1rbkxuNnRPS1ZEcXNMVzBF?= =?utf-8?B?Q2dhcm43NXBRL3pqUkxUZitSbk5BcWYwVDQ3K05rMzdrbExkM2E3Ujh0RWxl?= =?utf-8?B?ZXBmVDRhRFhPZm9TR2U1a1U0UkZkSDZRd2k4MmpQQkVBZ21YMVhuZVJNTTZI?= =?utf-8?B?QTVEK1dEdE92TWk5VlBlQU5Fb2lCT1BmT1VHQmJNSzNoZmJLWE1iNC9ndjE1?= =?utf-8?B?RVVrZGM0cjlHNU41Tm1qWS9wNnMvbGJDT2kvTXZHeHdaQzZtalhIWHNKd1ly?= =?utf-8?B?ekNQZXcyb1lQbklLTDVCakE0b2UwRlp5ZlZZTFExekJEbDBBdUVPdDRtTUpG?= =?utf-8?B?UXBnRUdKUzd3bW43MldUNmdVS2R5T2NGS2hNZ1ZBV0hJMnBybSt0UUFNNFhk?= =?utf-8?B?cWhjSXRtRzFXSm5mZWhtSDA2NnlQNkJWSnpNMUpLcUFJTXFUVXdYNmRWUVhC?= =?utf-8?B?WVFldkdrQnA2aTVGN0svRGNrWGM5eEpVQkFxVzJuNFFQRDlHbng3RmFWV2pQ?= =?utf-8?B?RDBncVkrUS9HWURlSDZMbkExUGRsVXRHQzVkUi9zOVBzZFdHaTZXbm8wZHo3?= =?utf-8?B?WVFKMXRDN1F6L05DejhCTTFMSXhHTWo1aStKa0dyS2M4MXZkRWl3UXo5Rm03?= =?utf-8?B?RkF3QlluOUZxSlp6TFVDeVdPcGVLYmRCTWpiNGJDOWFNUzkxbUVLMjVDaWtq?= =?utf-8?B?eXY0bXJKbHo0T050Z1pHeDhQdEhhZEFCQ052WGlXMC82Y3VjNlV6YjY3VGFM?= =?utf-8?B?eHVSV1pKV2YvOHRPN2pwQ0pGeEFadGVySUxvQTN2K2k3Z01QVVpheGpYc0xo?= =?utf-8?B?TnBSc0ZVRVBjV1UvOEhVL3NPaGZ2cFZRMzZwTHM1MHBxTzhsMzdFUHN2R0xr?= =?utf-8?B?K2QzeW14MGNJeUlFcU1TV3I4WStWTVJvdlkrSHJOdDBlZjA3Z0cxV3FocmRD?= =?utf-8?B?aTFkT1pRQjdWbTE3WklHMGM3OFQ5ZnN5KzJGSm9ZNlBWRGlxVm5zeGdHaExZ?= =?utf-8?B?cjZiRHh4TDh1QWhHY3VwNVhGUWs4Z0ViZWJDN2JLd1J3Q2tlRTkvbzdFc2w2?= =?utf-8?B?WnY2VlA4RHM2bDlmZk9DM2lZdi9GSm9va0s4ckw5S2E1RCtTWGRZOTZDakZ1?= =?utf-8?B?OTdrQlNzS2h4bmhuNkFpTU9BVS9qUzRzRWRiSExaZ0V2aXFhV1ZlYzhZeE9W?= =?utf-8?Q?uQcwuJMlSJx7ixu8WXgZS1+Jg?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6c76ceb8-5d3b-4d0a-71b7-08dd02323035 X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB8830.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2024 09:21:13.7736 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: m8yT4Ipg1zBIdZ+het6So8HUd5LduVJgfczEUq9r3FV1nfBzLk5+xBXy7YrsHV1R X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7785 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/11/2024 8:18 AM, 王颢 wrote: > Dear Ferruh, > > Regarding the commit message, I will think about how to write it. > > I’m sorry, but for the registers in the PMD that do not use macro definitions, most of them are company confidential and their meanings will not be disclosed to the public. This part will be maintained by us. > I understand, but this is conflicting with open sourcing the driver, after patch is merged it becomes responsibility of the community, of course primarily we will rely on you to maintain the driver, but for the cases like refactoring, or users fixing defects etc, community members may needs to update the driver code, and this requires for us to understand the code. Overall, I think there is a value to have the driver in DPDK, so please continue upstreaming, but please try to explain and clarify the code as much as possible. > Best Regards, > Howard Wang > > -----邮件原件----- > 发件人: Ferruh Yigit > 发送时间: 2024年11月11日 8:17 > 收件人: 王颢 ; dev@dpdk.org > 抄送: pro_nic_dpdk@realtek.com > 主题: Re: [PATCH v6 08/17] net/r8169: add support for phy configuration > > > External mail. > > > > On 11/8/2024 12:11 PM, Howard Wang wrote: >> This patch contains phy config, ephy config and so on. >> >> Signed-off-by: Howard Wang >> > > <...> > >> @@ -62,6 +62,12 @@ rtl_dev_start(struct rte_eth_dev *dev) >> struct rtl_hw *hw = &adapter->hw; >> int err; >> >> + rtl_powerup_pll(hw); >> + >> + rtl_hw_ephy_config(hw); >> + >> + rtl_hw_phy_config(hw); >> + >> rtl_hw_config(hw); >> >> /* Initialize transmission unit */ @@ -74,6 +80,8 @@ >> rtl_dev_start(struct rte_eth_dev *dev) >> goto error; >> } >> >> + rtl_mdio_write(hw, 0x1F, 0x0000); >> + >> > > It is very hard know what code like above does, which makes harder for anyone to read and understand your code, can you please either create macros for registers or comment as much as possible, so others can improve/fix your code when required. >