DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] kni: add ability to set min/max MTU
@ 2019-09-19 11:22 Igor Ryzhov
  2019-10-11 16:16 ` Ferruh Yigit
  2019-10-25 18:30 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
  0 siblings, 2 replies; 11+ messages in thread
From: Igor Ryzhov @ 2019-09-19 11:22 UTC (permalink / raw)
  To: dev

Starting with kernel version 4.10, there are new min/max MTU values in
net_device structure, which are set to ETH_MIN_MTU and ETH_DATA_LEN by
default. We should be able to change these values to allow MTU more than
1500 to be set on KNI.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
---
 examples/kni/main.c                               | 3 +++
 kernel/linux/kni/compat.h                         | 4 ++++
 kernel/linux/kni/kni_misc.c                       | 8 ++++++++
 lib/librte_eal/linux/eal/include/rte_kni_common.h | 2 ++
 lib/librte_kni/rte_kni.c                          | 2 ++
 lib/librte_kni/rte_kni.h                          | 2 ++
 6 files changed, 21 insertions(+)

diff --git a/examples/kni/main.c b/examples/kni/main.c
index 4710d7176..c22a7c18d 100644
--- a/examples/kni/main.c
+++ b/examples/kni/main.c
@@ -907,6 +907,9 @@ kni_alloc(uint16_t port_id)
 
 			rte_eth_dev_get_mtu(port_id, &conf.mtu);
 
+			conf.min_mtu = dev_info.min_mtu;
+			conf.max_mtu = dev_info.max_mtu;
+
 			memset(&ops, 0, sizeof(ops));
 			ops.port_id = port_id;
 			ops.change_mtu = kni_change_mtu;
diff --git a/kernel/linux/kni/compat.h b/kernel/linux/kni/compat.h
index 562d8bf94..fe0ee55e7 100644
--- a/kernel/linux/kni/compat.h
+++ b/kernel/linux/kni/compat.h
@@ -89,6 +89,10 @@
 #define HAVE_TRANS_START_HELPER
 #endif
 
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(4, 10, 0)
+#define HAVE_MIN_MAX_MTU
+#endif
+
 /*
  * KNI uses NET_NAME_UNKNOWN macro to select correct version of alloc_netdev()
  * For old kernels just backported the commit that enables the macro
diff --git a/kernel/linux/kni/kni_misc.c b/kernel/linux/kni/kni_misc.c
index 2b75502a8..aeb275329 100644
--- a/kernel/linux/kni/kni_misc.c
+++ b/kernel/linux/kni/kni_misc.c
@@ -390,6 +390,14 @@ kni_ioctl_create(struct net *net, uint32_t ioctl_num,
 	net_dev->max_mtu = net_dev->mtu;
 #endif
 
+#ifdef HAVE_MIN_MAX_MTU
+	if (dev_info.min_mtu)
+		net_dev->min_mtu = dev_info.min_mtu;
+
+	if (dev_info.max_mtu)
+		net_dev->max_mtu = dev_info.max_mtu;
+#endif
+
 	ret = register_netdev(net_dev);
 	if (ret) {
 		pr_err("error %i registering device \"%s\"\n",
diff --git a/lib/librte_eal/linux/eal/include/rte_kni_common.h b/lib/librte_eal/linux/eal/include/rte_kni_common.h
index 37d9ee8f0..70992d835 100644
--- a/lib/librte_eal/linux/eal/include/rte_kni_common.h
+++ b/lib/librte_eal/linux/eal/include/rte_kni_common.h
@@ -120,6 +120,8 @@ struct rte_kni_device_info {
 	/* mbuf size */
 	unsigned mbuf_size;
 	unsigned int mtu;
+	unsigned int min_mtu;
+	unsigned int max_mtu;
 	uint8_t mac_addr[6];
 };
 
diff --git a/lib/librte_kni/rte_kni.c b/lib/librte_kni/rte_kni.c
index 4b51fb4fe..521db27c4 100644
--- a/lib/librte_kni/rte_kni.c
+++ b/lib/librte_kni/rte_kni.c
@@ -252,6 +252,8 @@ rte_kni_alloc(struct rte_mempool *pktmbuf_pool,
 	dev_info.group_id = conf->group_id;
 	dev_info.mbuf_size = conf->mbuf_size;
 	dev_info.mtu = conf->mtu;
+	dev_info.min_mtu = conf->min_mtu;
+	dev_info.max_mtu = conf->max_mtu;
 
 	memcpy(dev_info.mac_addr, conf->mac_addr, RTE_ETHER_ADDR_LEN);
 
diff --git a/lib/librte_kni/rte_kni.h b/lib/librte_kni/rte_kni.h
index 5699a6443..b22446fa7 100644
--- a/lib/librte_kni/rte_kni.h
+++ b/lib/librte_kni/rte_kni.h
@@ -70,6 +70,8 @@ struct rte_kni_conf {
 	uint8_t force_bind : 1; /* Flag to bind kernel thread */
 	uint8_t mac_addr[RTE_ETHER_ADDR_LEN]; /* MAC address assigned to KNI */
 	uint16_t mtu;
+	uint16_t min_mtu;
+	uint16_t max_mtu;
 };
 
 /**
-- 
2.23.0


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [dpdk-dev] [PATCH] kni: add ability to set min/max MTU
  2019-09-19 11:22 [dpdk-dev] [PATCH] kni: add ability to set min/max MTU Igor Ryzhov
@ 2019-10-11 16:16 ` Ferruh Yigit
  2019-10-16  6:40   ` David Marchand
  2019-10-25 18:30 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
  1 sibling, 1 reply; 11+ messages in thread
From: Ferruh Yigit @ 2019-10-11 16:16 UTC (permalink / raw)
  To: Igor Ryzhov, dev

On 9/19/2019 12:22 PM, Igor Ryzhov wrote:
> Starting with kernel version 4.10, there are new min/max MTU values in
> net_device structure, which are set to ETH_MIN_MTU and ETH_DATA_LEN by
> default. We should be able to change these values to allow MTU more than
> 1500 to be set on KNI.
> 
> Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [dpdk-dev] [PATCH] kni: add ability to set min/max MTU
  2019-10-11 16:16 ` Ferruh Yigit
@ 2019-10-16  6:40   ` David Marchand
  2019-10-16 10:43     ` Ferruh Yigit
  0 siblings, 1 reply; 11+ messages in thread
From: David Marchand @ 2019-10-16  6:40 UTC (permalink / raw)
  To: Ferruh Yigit, Igor Ryzhov; +Cc: dev

On Fri, Oct 11, 2019 at 6:16 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> On 9/19/2019 12:22 PM, Igor Ryzhov wrote:
> > Starting with kernel version 4.10, there are new min/max MTU values in
> > net_device structure, which are set to ETH_MIN_MTU and ETH_DATA_LEN by
> > default. We should be able to change these values to allow MTU more than
> > 1500 to be set on KNI.
> >
> > Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

I intend to change the title as "kni: fix mtu setting with kernels >= 4.10".
Does it sound ok to you?

Would it make sense to backport this patch?


--
David Marchand


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [dpdk-dev] [PATCH] kni: add ability to set min/max MTU
  2019-10-16  6:40   ` David Marchand
@ 2019-10-16 10:43     ` Ferruh Yigit
  2019-10-16 10:55       ` David Marchand
  0 siblings, 1 reply; 11+ messages in thread
From: Ferruh Yigit @ 2019-10-16 10:43 UTC (permalink / raw)
  To: David Marchand, Igor Ryzhov; +Cc: dev

On 10/16/2019 7:40 AM, David Marchand wrote:
> On Fri, Oct 11, 2019 at 6:16 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>>
>> On 9/19/2019 12:22 PM, Igor Ryzhov wrote:
>>> Starting with kernel version 4.10, there are new min/max MTU values in
>>> net_device structure, which are set to ETH_MIN_MTU and ETH_DATA_LEN by
>>> default. We should be able to change these values to allow MTU more than
>>> 1500 to be set on KNI.
>>>
>>> Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
>>
>> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> I intend to change the title as "kni: fix mtu setting with kernels >= 4.10".
> Does it sound ok to you?

I am not quite sure it is a fix, this patch enables application to pass min/max
MTU values for kni netdev but existing code is not doing anything wrong.

> 
> Would it make sense to backport this patch?
> 

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [dpdk-dev] [PATCH] kni: add ability to set min/max MTU
  2019-10-16 10:43     ` Ferruh Yigit
@ 2019-10-16 10:55       ` David Marchand
  2019-10-16 14:47         ` David Marchand
  0 siblings, 1 reply; 11+ messages in thread
From: David Marchand @ 2019-10-16 10:55 UTC (permalink / raw)
  To: Ferruh Yigit; +Cc: Igor Ryzhov, dev

On Wed, Oct 16, 2019 at 12:43 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> On 10/16/2019 7:40 AM, David Marchand wrote:
> > On Fri, Oct 11, 2019 at 6:16 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> >>
> >> On 9/19/2019 12:22 PM, Igor Ryzhov wrote:
> >>> Starting with kernel version 4.10, there are new min/max MTU values in
> >>> net_device structure, which are set to ETH_MIN_MTU and ETH_DATA_LEN by
> >>> default. We should be able to change these values to allow MTU more than
> >>> 1500 to be set on KNI.
> >>>
> >>> Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
> >>
> >> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
> >
> > I intend to change the title as "kni: fix mtu setting with kernels >= 4.10".
> > Does it sound ok to you?
>
> I am not quite sure it is a fix, this patch enables application to pass min/max
> MTU values for kni netdev but existing code is not doing anything wrong.

To me, starting 4.10, we can't set the mtu to something greater than
1500 on a kni netdev, since netdev uses the ETH_DATA_LEN default value
and will refuse a bigger mtu before even calling the change mtu ndo.
Did I understand something wrong?


-- 
David Marchand


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [dpdk-dev] [PATCH] kni: add ability to set min/max MTU
  2019-10-16 10:55       ` David Marchand
@ 2019-10-16 14:47         ` David Marchand
  2019-10-16 14:59           ` Ferruh Yigit
  0 siblings, 1 reply; 11+ messages in thread
From: David Marchand @ 2019-10-16 14:47 UTC (permalink / raw)
  To: Ferruh Yigit, Igor Ryzhov; +Cc: dev

On Wed, Oct 16, 2019 at 12:55 PM David Marchand
<david.marchand@redhat.com> wrote:
>
> On Wed, Oct 16, 2019 at 12:43 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> >
> > On 10/16/2019 7:40 AM, David Marchand wrote:
> > > On Fri, Oct 11, 2019 at 6:16 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> > >>
> > >> On 9/19/2019 12:22 PM, Igor Ryzhov wrote:
> > >>> Starting with kernel version 4.10, there are new min/max MTU values in
> > >>> net_device structure, which are set to ETH_MIN_MTU and ETH_DATA_LEN by
> > >>> default. We should be able to change these values to allow MTU more than
> > >>> 1500 to be set on KNI.
> > >>>
> > >>> Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
> > >>
> > >> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > >
> > > I intend to change the title as "kni: fix mtu setting with kernels >= 4.10".
> > > Does it sound ok to you?
> >
> > I am not quite sure it is a fix, this patch enables application to pass min/max
> > MTU values for kni netdev but existing code is not doing anything wrong.
>
> To me, starting 4.10, we can't set the mtu to something greater than
> 1500 on a kni netdev, since netdev uses the ETH_DATA_LEN default value
> and will refuse a bigger mtu before even calling the change mtu ndo.
> Did I understand something wrong?

- As discussed on irc and after looking deeper into the code.
The support for jumbo frames was already present and should be working
with the current code.
So I agree this does not qualify as a fix, sorry for the noise.

- On the other hand, we could refactor this patch to make use of/merge
with the existing HAVE_MAX_MTU_PARAM pre-existing macro without
introducing a new one.

- The commit title/log is still a bit cryptic to me, in which case
would an application pass a min_mtu/max_mtu?


Thanks.
-- 
David Marchand


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [dpdk-dev] [PATCH] kni: add ability to set min/max MTU
  2019-10-16 14:47         ` David Marchand
@ 2019-10-16 14:59           ` Ferruh Yigit
  0 siblings, 0 replies; 11+ messages in thread
From: Ferruh Yigit @ 2019-10-16 14:59 UTC (permalink / raw)
  To: David Marchand, Igor Ryzhov; +Cc: dev

On 10/16/2019 3:47 PM, David Marchand wrote:
> On Wed, Oct 16, 2019 at 12:55 PM David Marchand
> <david.marchand@redhat.com> wrote:
>>
>> On Wed, Oct 16, 2019 at 12:43 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>>>
>>> On 10/16/2019 7:40 AM, David Marchand wrote:
>>>> On Fri, Oct 11, 2019 at 6:16 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>>>>>
>>>>> On 9/19/2019 12:22 PM, Igor Ryzhov wrote:
>>>>>> Starting with kernel version 4.10, there are new min/max MTU values in
>>>>>> net_device structure, which are set to ETH_MIN_MTU and ETH_DATA_LEN by
>>>>>> default. We should be able to change these values to allow MTU more than
>>>>>> 1500 to be set on KNI.
>>>>>>
>>>>>> Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
>>>>>
>>>>> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
>>>>
>>>> I intend to change the title as "kni: fix mtu setting with kernels >= 4.10".
>>>> Does it sound ok to you?
>>>
>>> I am not quite sure it is a fix, this patch enables application to pass min/max
>>> MTU values for kni netdev but existing code is not doing anything wrong.
>>
>> To me, starting 4.10, we can't set the mtu to something greater than
>> 1500 on a kni netdev, since netdev uses the ETH_DATA_LEN default value
>> and will refuse a bigger mtu before even calling the change mtu ndo.
>> Did I understand something wrong?
> 
> - As discussed on irc and after looking deeper into the code.
> The support for jumbo frames was already present and should be working
> with the current code.
> So I agree this does not qualify as a fix, sorry for the noise.
> 
> - On the other hand, we could refactor this patch to make use of/merge
> with the existing HAVE_MAX_MTU_PARAM pre-existing macro without
> introducing a new one.

+1 to this, I missed the existing HAVE_MAX_MTU_PARAM macro

> 
> - The commit title/log is still a bit cryptic to me, in which case
> would an application pass a min_mtu/max_mtu?
> 
> 
> Thanks.
> 


^ permalink raw reply	[flat|nested] 11+ messages in thread

* [dpdk-dev] [PATCH v2] kni: add ability to set min/max MTU
  2019-09-19 11:22 [dpdk-dev] [PATCH] kni: add ability to set min/max MTU Igor Ryzhov
  2019-10-11 16:16 ` Ferruh Yigit
@ 2019-10-25 18:30 ` Ferruh Yigit
  2019-10-25 18:32   ` Ferruh Yigit
  2019-10-27 10:12   ` David Marchand
  1 sibling, 2 replies; 11+ messages in thread
From: Ferruh Yigit @ 2019-10-25 18:30 UTC (permalink / raw)
  To: Ferruh Yigit; +Cc: dev, David Marchand, Igor Ryzhov

From: Igor Ryzhov <iryzhov@nfware.com>

Starting with kernel version 4.10, there are new min/max MTU values in
net_device structure, which are set to ETH_MIN_MTU and ETH_DATA_LEN by
default. We should be able to change these values to allow MTU more than
1500 to be set on KNI.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
 examples/kni/main.c                               | 3 +++
 kernel/linux/kni/kni_misc.c                       | 6 ++++++
 lib/librte_eal/linux/eal/include/rte_kni_common.h | 2 ++
 lib/librte_kni/rte_kni.c                          | 2 ++
 lib/librte_kni/rte_kni.h                          | 2 ++
 5 files changed, 15 insertions(+)

diff --git a/examples/kni/main.c b/examples/kni/main.c
index c576fc767..5f713e6b2 100644
--- a/examples/kni/main.c
+++ b/examples/kni/main.c
@@ -949,6 +949,9 @@ kni_alloc(uint16_t port_id)
 
 			rte_eth_dev_get_mtu(port_id, &conf.mtu);
 
+			conf.min_mtu = dev_info.min_mtu;
+			conf.max_mtu = dev_info.max_mtu;
+
 			memset(&ops, 0, sizeof(ops));
 			ops.port_id = port_id;
 			ops.change_mtu = kni_change_mtu;
diff --git a/kernel/linux/kni/kni_misc.c b/kernel/linux/kni/kni_misc.c
index 2b75502a8..84ef03b5f 100644
--- a/kernel/linux/kni/kni_misc.c
+++ b/kernel/linux/kni/kni_misc.c
@@ -388,6 +388,12 @@ kni_ioctl_create(struct net *net, uint32_t ioctl_num,
 		net_dev->mtu = dev_info.mtu;
 #ifdef HAVE_MAX_MTU_PARAM
 	net_dev->max_mtu = net_dev->mtu;
+
+	if (dev_info.min_mtu)
+		net_dev->min_mtu = dev_info.min_mtu;
+
+	if (dev_info.max_mtu)
+		net_dev->max_mtu = dev_info.max_mtu;
 #endif
 
 	ret = register_netdev(net_dev);
diff --git a/lib/librte_eal/linux/eal/include/rte_kni_common.h b/lib/librte_eal/linux/eal/include/rte_kni_common.h
index b51fe27bd..46f75a710 100644
--- a/lib/librte_eal/linux/eal/include/rte_kni_common.h
+++ b/lib/librte_eal/linux/eal/include/rte_kni_common.h
@@ -122,6 +122,8 @@ struct rte_kni_device_info {
 	/* mbuf size */
 	unsigned mbuf_size;
 	unsigned int mtu;
+	unsigned int min_mtu;
+	unsigned int max_mtu;
 	uint8_t mac_addr[6];
 };
 
diff --git a/lib/librte_kni/rte_kni.c b/lib/librte_kni/rte_kni.c
index 0f3648508..7fbcf2201 100644
--- a/lib/librte_kni/rte_kni.c
+++ b/lib/librte_kni/rte_kni.c
@@ -252,6 +252,8 @@ rte_kni_alloc(struct rte_mempool *pktmbuf_pool,
 	dev_info.group_id = conf->group_id;
 	dev_info.mbuf_size = conf->mbuf_size;
 	dev_info.mtu = conf->mtu;
+	dev_info.min_mtu = conf->min_mtu;
+	dev_info.max_mtu = conf->max_mtu;
 
 	memcpy(dev_info.mac_addr, conf->mac_addr, RTE_ETHER_ADDR_LEN);
 
diff --git a/lib/librte_kni/rte_kni.h b/lib/librte_kni/rte_kni.h
index f6b66c33d..f1bb782c6 100644
--- a/lib/librte_kni/rte_kni.h
+++ b/lib/librte_kni/rte_kni.h
@@ -73,6 +73,8 @@ struct rte_kni_conf {
 	uint8_t force_bind : 1; /* Flag to bind kernel thread */
 	uint8_t mac_addr[RTE_ETHER_ADDR_LEN]; /* MAC address assigned to KNI */
 	uint16_t mtu;
+	uint16_t min_mtu;
+	uint16_t max_mtu;
 };
 
 /**
-- 
2.21.0


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [dpdk-dev] [PATCH v2] kni: add ability to set min/max MTU
  2019-10-25 18:30 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
@ 2019-10-25 18:32   ` Ferruh Yigit
  2019-10-27 10:12   ` David Marchand
  1 sibling, 0 replies; 11+ messages in thread
From: Ferruh Yigit @ 2019-10-25 18:32 UTC (permalink / raw)
  Cc: dev, David Marchand, Igor Ryzhov

On 10/25/2019 7:30 PM, Ferruh Yigit wrote:
> From: Igor Ryzhov <iryzhov@nfware.com>
> 
> Starting with kernel version 4.10, there are new min/max MTU values in
> net_device structure, which are set to ETH_MIN_MTU and ETH_DATA_LEN by
> default. We should be able to change these values to allow MTU more than
> 1500 to be set on KNI.
> 
> Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

v2:
Reuse existing 'HAVE_MAX_MTU_PARAM' macro instead of creating new 'HAVE_MIN_MAX_MTU'


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [dpdk-dev] [PATCH v2] kni: add ability to set min/max MTU
  2019-10-25 18:30 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
  2019-10-25 18:32   ` Ferruh Yigit
@ 2019-10-27 10:12   ` David Marchand
  2019-10-27 19:56     ` Igor Ryzhov
  1 sibling, 1 reply; 11+ messages in thread
From: David Marchand @ 2019-10-27 10:12 UTC (permalink / raw)
  To: Ferruh Yigit; +Cc: dev, Igor Ryzhov

On Fri, Oct 25, 2019 at 8:31 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> From: Igor Ryzhov <iryzhov@nfware.com>
>
> Starting with kernel version 4.10, there are new min/max MTU values in
> net_device structure, which are set to ETH_MIN_MTU and ETH_DATA_LEN by
> default. We should be able to change these values to allow MTU more than
> 1500 to be set on KNI.
>
> Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied, thanks.


-- 
David Marchand


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [dpdk-dev] [PATCH v2] kni: add ability to set min/max MTU
  2019-10-27 10:12   ` David Marchand
@ 2019-10-27 19:56     ` Igor Ryzhov
  0 siblings, 0 replies; 11+ messages in thread
From: Igor Ryzhov @ 2019-10-27 19:56 UTC (permalink / raw)
  To: David Marchand; +Cc: Ferruh Yigit, dev

Hi David, Ferruh,

Sorry I was on vacation. Thank you for dealing with this.

Best regards,
Igor

On Sun, Oct 27, 2019 at 1:12 PM David Marchand <david.marchand@redhat.com>
wrote:

> On Fri, Oct 25, 2019 at 8:31 PM Ferruh Yigit <ferruh.yigit@intel.com>
> wrote:
> >
> > From: Igor Ryzhov <iryzhov@nfware.com>
> >
> > Starting with kernel version 4.10, there are new min/max MTU values in
> > net_device structure, which are set to ETH_MIN_MTU and ETH_DATA_LEN by
> > default. We should be able to change these values to allow MTU more than
> > 1500 to be set on KNI.
> >
> > Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
> > Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> Applied, thanks.
>
>
> --
> David Marchand
>
>

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2019-10-27 19:56 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-19 11:22 [dpdk-dev] [PATCH] kni: add ability to set min/max MTU Igor Ryzhov
2019-10-11 16:16 ` Ferruh Yigit
2019-10-16  6:40   ` David Marchand
2019-10-16 10:43     ` Ferruh Yigit
2019-10-16 10:55       ` David Marchand
2019-10-16 14:47         ` David Marchand
2019-10-16 14:59           ` Ferruh Yigit
2019-10-25 18:30 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2019-10-25 18:32   ` Ferruh Yigit
2019-10-27 10:12   ` David Marchand
2019-10-27 19:56     ` Igor Ryzhov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).