Re: [dpdk-dev] [PATCH 00/22] add hns3 ethernet PMD driver

["Wei Hu (Xavier)" <xavier.huwei@huawei.com>]

On 2019/8/30 23:23, Ferruh Yigit wrote:
> On 8/23/2019 2:46 PM, Wei Hu (Xavier) wrote:
>> The Hisilicon Network Subsystem is a long term evolution IP which is
>> supposed to be used in Hisilicon ICT SoCs such as Kunpeng 920.
>>
>> This series add DPDK rte_ethdev poll mode driver for hns3(Hisilicon
>> Network Subsystem 3) network engine.
>>
>> Wei Hu (Xavier) (22):
>>   net/hns3: add hardware registers definition
>>   net/hns3: add some definitions for data structure and macro
>>   net/hns3: register hns3 PMD driver
>>   net/hns3: add support for cmd of hns3 PMD driver
>>   net/hns3: add the initialization of hns3 PMD driver
>>   net/hns3: add support for MAC address related operations
>>   net/hns3: add support for some misc operations
>>   net/hns3: add support for link update operation
>>   net/hns3: add support for flow directory of hns3 PMD driver
>>   net/hns3: add support for RSS of hns3 PMD driver
>>   net/hns3: add support for flow control of hns3 PMD driver
>>   net/hns3: add support for VLAN of hns3 PMD driver
>>   net/hns3: add support for mailbox of hns3 PMD driver
>>   net/hns3: add support for hns3 VF PMD driver
>>   net/hns3: add package and queue related operation
>>   net/hns3: add start stop configure promiscuous ops
>>   net/hns3: add dump register ops for hns3 PMD driver
>>   net/hns3: add abnormal interrupt process for hns3 PMD driver
>>   net/hns3: add stats related ops for hns3 PMD driver
>>   net/hns3: add reset related process for hns3 PMD driver
>>   net/hns3: add multiple process support for hns3 PMD driver
>>   net/hns3: add hns3 build files
>>
> There are some build error for 32-bit [1], I am aware that 32-bit is not in the
> supported arch list, but build error are just related to the log format
> identifiers, it is good practice to use 'PRIx64' and friends which will also fix
> the build issue.
>
> [1]
> In file included from .../drivers/net/hns3/hns3_regs.c:35:
>
>
>
> .../drivers/net/hns3/hns3_regs.c: In function ‘hns3_get_32_bit_regs’:
>
>
>
> .../drivers/net/hns3/hns3_logs.h:16:38: error: format ‘%ld’ expects argument of
> type ‘long int’, but argument 6 has type ‘unsigned int’ [-Werror=format=]
>
>
>    16 |  rte_log(level, hns3_logtype_driver, "%s %s(): " fmt, \
>
>
>
>       |                                      ^~~~~~~~~~~
>
>
>
> .../drivers/net/hns3/hns3_logs.h:20:2: note: in expansion of macro
> ‘PMD_DRV_LOG_RAW’
>
>
>    20 |  PMD_DRV_LOG_RAW(hw, RTE_LOG_ERR, fmt "\n", ## args)
>
>
>
>       |  ^~~~~~~~~~~~~~~
>
>
>
> .../drivers/net/hns3/hns3_regs.c:177:3: note: in expansion of macro ‘hns3_err’
>
>
>
>   177 |   hns3_err(hw, "Failed to allocate %ld bytes needed to "
>
>
>
>       |   ^~~~~~~~
>
>
>
> .../drivers/net/hns3/hns3_regs.c:177:38: note: format string is defined here
>
>
>
>   177 |   hns3_err(hw, "Failed to allocate %ld bytes needed to "
>
>
>
>       |                                    ~~^
>
>
>
>       |                                      |
>
>
>
>       |                                      long int
>
>
>
>       |                                    %d
>
>
Hi, Ferruh Yigit

    Thanks for your suggestion.
    We will fix it in patch V2.

    Regards
Xavier