From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4EC5FA2EDB for ; Mon, 30 Sep 2019 10:39:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 56EE2324D; Mon, 30 Sep 2019 10:39:29 +0200 (CEST) Received: from huawei.com (szxga05-in.huawei.com [45.249.212.191]) by dpdk.org (Postfix) with ESMTP id 3096729C6 for ; Mon, 30 Sep 2019 10:39:27 +0200 (CEST) Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 762F232337FEC7F9EB2F for ; Mon, 30 Sep 2019 16:39:26 +0800 (CST) Received: from [127.0.0.1] (10.177.29.98) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.439.0; Mon, 30 Sep 2019 16:39:19 +0800 To: Ferruh Yigit CC: , , , , , , References: <9559f32e-2a6e-b786-4224-d65adc9df1a7@intel.com> From: "Wangxiaoyun (Cloud, Network Chip Application Development Dept)" Message-ID: Date: Mon, 30 Sep 2019 16:39:17 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <9559f32e-2a6e-b786-4224-d65adc9df1a7@intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.177.29.98] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH v2 12/17] net/hinic: set link down and up X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Thanks for your comments, I have splited this patch into 2 patched, one is for link down and up,the other is for getting fw version. 在 2019/9/27 2:47, Ferruh Yigit 写道: > On 9/25/2019 3:30 PM, Xiaoyun wang wrote: >> This patch supports setting link down and up, >> Also adds support for geting firmware version. >> >> Signed-off-by: Xiaoyun wang > <...> > >> @@ -2751,9 +2832,12 @@ static void hinic_dev_close(struct rte_eth_dev *dev) >> static const struct eth_dev_ops hinic_pmd_ops = { >> .dev_configure = hinic_dev_configure, >> .dev_infos_get = hinic_dev_infos_get, >> + .fw_version_get = hinic_fw_version_get, >> .rx_queue_setup = hinic_rx_queue_setup, >> .tx_queue_setup = hinic_tx_queue_setup, >> .dev_start = hinic_dev_start, >> + .dev_set_link_up = hinic_dev_set_link_up, >> + .dev_set_link_down = hinic_dev_set_link_down, >> .link_update = hinic_link_update, >> .rx_queue_release = hinic_rx_queue_release, >> .tx_queue_release = hinic_tx_queue_release, >> @@ -2785,6 +2869,7 @@ static void hinic_dev_close(struct rte_eth_dev *dev) >> static const struct eth_dev_ops hinic_pmd_vf_ops = { >> .dev_configure = hinic_dev_configure, >> .dev_infos_get = hinic_dev_infos_get, >> + .fw_version_get = hinic_fw_version_get, >> .rx_queue_setup = hinic_rx_queue_setup, >> .tx_queue_setup = hinic_tx_queue_setup, >> .dev_start = hinic_dev_start, >> > Patch is also updating fw version get support, can you please mention from it in > the commit log? Or separate the patch.. > >