From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) by dpdk.org (Postfix) with ESMTP id 639A91066 for ; Tue, 24 Apr 2018 13:29:15 +0200 (CEST) Received: by mail-wm0-f66.google.com with SMTP id o78so197446wmg.0 for ; Tue, 24 Apr 2018 04:29:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=2xCwL7hBcveMFexebCeC56/mZlcIWIEEjoKHQ1LdqNM=; b=EWE8wTaFQ89DPKMP4lj0F4tbYcfF06yxjXd/EUqkhgsnEGrMlY5l6/dZWtFf/kQ7D7 YSa4KvVJKAbbjpLj95v6W60FeijeuBgxQCRncTamP/SGNmHQ/dy6YY6HfiHjdC7LyEAN +W85bl4YP7jVCOglY3doZ9MpJ5Nn/THTRBo9C9e7mA1S4mKeOgU8nO6lXALXWA2/1M5l GcKqmqEhUW2T8m/5mrXjJUDQUzvmIRcC5g3NVyb34yrnRXmuPtcwGWkRqR2jqBrC9LKJ VL47vttWH8ZMK5q5Y2GqSO1Nh9BELsckivygt7vG5MONzeFftL5OAxZhq0gLXR32g/yR 98dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=2xCwL7hBcveMFexebCeC56/mZlcIWIEEjoKHQ1LdqNM=; b=lJp9al4RHq3cxQHH/gdHg1lit0CpWdrl8mH6IY2UBxoeFXqHMbqs9fds6EQOER1AhG sPp896t6KeAbJnldttGQCGbvzwHpxWnK7RYawOuLyIwzugWoLNZmv88BwKrOY/oraAVf Eb2zKQVKTRWSxuDL+dZN3VqtgItJFQ54/GKc/xGM+pPu6weyR5mGgDIGyo4e8M0eT4HR VW5Z90OW5NwDOCRXadX5DvNH3oieHsOunxzbagcEv2mlcrQ6a4rKMUsgfjnpKwJSxvyx 153GfKhqZc6l5FXTIDeengQXXoKBREcLqN7iuJYWBFxP+Gm2M3FHDcCUt2rGsg6Sd2VK SNIQ== X-Gm-Message-State: ALQs6tCHY16D0WznH40FB10b/aMCy1xyojRtf9Z9NzcpeZmMfHr7x9Sg lehkOCEGtmy6RZ0S8i8ikA8EkWXa X-Google-Smtp-Source: AIpwx4/CNdZhNpUFd5JJEnsYVjikswUXxzuIvnQbwMIhiLX3CLuCkK+8t/q9r4gxEzupQxTihzusQA== X-Received: by 10.28.245.16 with SMTP id t16mr12857946wmh.63.1524569354169; Tue, 24 Apr 2018 04:29:14 -0700 (PDT) Received: from bidouze.dev.6wind.com. (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id c21-v6sm12848021wre.43.2018.04.24.04.29.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Apr 2018 04:29:13 -0700 (PDT) From: Gaetan Rivet To: dev@dpdk.org Cc: Gaetan Rivet Date: Tue, 24 Apr 2018 13:28:52 +0200 Message-Id: X-Mailer: git-send-email 2.11.0 In-Reply-To: References: In-Reply-To: References: Subject: [dpdk-dev] [PATCH v1 1/2] eal: list acceptable init priorities X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Apr 2018 11:29:15 -0000 Build a central list to quickly see each used priorities for constructors, allowing to verify that they are both above 100 and in the proper order. Signed-off-by: Gaetan Rivet Acked-by: Neil Horman Acked-by: Shreyansh Jain --- lib/librte_eal/common/eal_common_log.c | 2 +- lib/librte_eal/common/include/rte_bus.h | 2 +- lib/librte_eal/common/include/rte_common.h | 8 +++++++- 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/lib/librte_eal/common/eal_common_log.c b/lib/librte_eal/common/eal_common_log.c index a27192620..36b9d6e08 100644 --- a/lib/librte_eal/common/eal_common_log.c +++ b/lib/librte_eal/common/eal_common_log.c @@ -260,7 +260,7 @@ static const struct logtype logtype_strings[] = { }; /* Logging should be first initializer (before drivers and bus) */ -RTE_INIT_PRIO(rte_log_init, 101); +RTE_INIT_PRIO(rte_log_init, LOG); static void rte_log_init(void) { diff --git a/lib/librte_eal/common/include/rte_bus.h b/lib/librte_eal/common/include/rte_bus.h index 6fb08341a..eb9eded4e 100644 --- a/lib/librte_eal/common/include/rte_bus.h +++ b/lib/librte_eal/common/include/rte_bus.h @@ -325,7 +325,7 @@ enum rte_iova_mode rte_bus_get_iommu_class(void); * The constructor has higher priority than PMD constructors. */ #define RTE_REGISTER_BUS(nm, bus) \ -RTE_INIT_PRIO(businitfn_ ##nm, 110); \ +RTE_INIT_PRIO(businitfn_ ##nm, BUS); \ static void businitfn_ ##nm(void) \ {\ (bus).name = RTE_STR(nm);\ diff --git a/lib/librte_eal/common/include/rte_common.h b/lib/librte_eal/common/include/rte_common.h index 6c5bc5a76..8f04518f7 100644 --- a/lib/librte_eal/common/include/rte_common.h +++ b/lib/librte_eal/common/include/rte_common.h @@ -81,6 +81,12 @@ typedef uint16_t unaligned_uint16_t; */ #define RTE_SET_USED(x) (void)(x) +#define RTE_PRIORITY_LOG 101 +#define RTE_PRIORITY_BUS 110 + +#define RTE_PRIO(prio) \ + RTE_PRIORITY_ ## prio + /** * Run function before main() with low priority. * @@ -102,7 +108,7 @@ static void __attribute__((constructor, used)) func(void) * Lowest number is the first to run. */ #define RTE_INIT_PRIO(func, prio) \ -static void __attribute__((constructor(prio), used)) func(void) +static void __attribute__((constructor(RTE_PRIO(prio)), used)) func(void) /** * Force a function to be inlined -- 2.11.0