From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 533BD1B217 for ; Wed, 10 Oct 2018 08:16:22 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 24CDE140069; Wed, 10 Oct 2018 06:16:21 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 10 Oct 2018 07:16:15 +0100 To: Thomas Monjalon , CC: , References: <20180907233929.21950-1-thomas@monjalon.net> <20181009221732.17377-1-thomas@monjalon.net> From: Andrew Rybchenko Message-ID: Date: Wed, 10 Oct 2018 09:15:33 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <20181009221732.17377-1-thomas@monjalon.net> Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24146.003 X-TM-AS-Result: No-16.290400-8.000000-10 X-TMASE-MatchedRID: hls5oAVArl8OwH4pD14DsPHkpkyUphL9wuIWIvQEbW6vPoND+wakFlPK Q4g0ENBTz0kHebusWqG/OcTZGXKzdinPugGsN3p5bc297PAGtWbhKQh1LCmGBhqB+wKK9uZeyU7 XgTs6W4LuzcUA0q2gBeKOmN63egZIOVzKEd+ERcomEURBmKrZlHzIY7d2+Tz9AnW+Tu2Fi4ZR18 QpzXStTi9BUTTI4YWlioFl5UK3cJ/SduMc6RnI+T5bo3ZLMFMHB+dff70WbjmKS8TZAaVRhHlED b1OO87oNTcc+FGtHL3/voIzhn8wZuVHGbcDbAq6OX/V8P8ail1ZDL1gLmoa/PoA9r2LThYYvJqH 1oJhQIdO3vAB02uLno1i4Y1sFHXY6eH2meetZhP+iW9mqbz4yV1BBlIcMI6294FeMSfM4A3XFuU 573BMh+PsxPHCfQ5vyHjGZoj/JJY= X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--16.290400-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24146.003 X-MDID: 1539152181-kcqPglWN_Y-X Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2] ethdev: complete closing of port X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Oct 2018 06:16:22 -0000 On 10/10/18 1:17 AM, Thomas Monjalon wrote: > After closing a port, it cannot be restarted. > So there is no reason to not free all associated resources. > > The last step was done with rte_eth_dev_detach() which is deprecated. > Instead of blindly removing the associated rte_device, the driver should > check if no more port (ethdev, cryptodev, etc) is open for the device. > > The last ethdev freeing (dev_private and final release), which were done > by rte_eth_dev_detach(), are now done at the end of rte_eth_dev_close(). > > If the driver is trying to free the port again, the function > rte_eth_dev_release_port() will abort with -ENODEV error. > > Signed-off-by: Thomas Monjalon > --- > lib/librte_ethdev/rte_ethdev.c | 6 ++++++ > lib/librte_ethdev/rte_ethdev.h | 3 +-- > 2 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c > index ed83e5954..3062dc711 100644 > --- a/lib/librte_ethdev/rte_ethdev.c > +++ b/lib/librte_ethdev/rte_ethdev.c > @@ -506,6 +506,8 @@ rte_eth_dev_release_port(struct rte_eth_dev *eth_dev) > { > if (eth_dev == NULL) > return -EINVAL; > + if (eth_dev->state == RTE_ETH_DEV_UNUSED) > + return -ENODEV; > > rte_eth_dev_shared_data_prepare(); > > @@ -1441,6 +1443,10 @@ rte_eth_dev_close(uint16_t port_id) > dev->data->nb_tx_queues = 0; > rte_free(dev->data->tx_queues); > dev->data->tx_queues = NULL; > + > + rte_free(dev->data->dev_private); It is used by, for example, PCI device uninit functions. What does guarantee that uninit is done and we can free the private data.