From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B29D0A2EDB for ; Fri, 6 Sep 2019 12:09:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7D2331F2FA; Fri, 6 Sep 2019 12:09:23 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 3009F1F2F8 for ; Fri, 6 Sep 2019 12:09:22 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us3.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 327CD6C0065; Fri, 6 Sep 2019 10:09:21 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 6 Sep 2019 11:09:16 +0100 To: =?UTF-8?Q?Ga=c3=abtan_Rivet?= CC: , Ivan Ilchenko References: <1566915962-5472-1-git-send-email-arybchenko@solarflare.com> <1567755066-31389-1-git-send-email-arybchenko@solarflare.com> <1567755066-31389-15-git-send-email-arybchenko@solarflare.com> <20190906092854.dm7sv4wmfsozw5rs@bidouze.vm.6wind.com> From: Andrew Rybchenko Message-ID: Date: Fri, 6 Sep 2019 13:09:13 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190906092854.dm7sv4wmfsozw5rs@bidouze.vm.6wind.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24892.003 X-TM-AS-Result: No-2.969900-8.000000-10 X-TMASE-MatchedRID: scwq2vQP8OG8rRvefcjeTSZ6hERbr2kdCTT1jRv0OVrk1kyQDpEj8Cj5 3aEB5qDLYgwIeZNpAMO/UScO8V00kiw76RUR9W5CqJSK+HSPY+/DAPSbMWlGt1jBUeMsjed6QBz oPKhLashHecAzvL6zESUuZ45MpXbFPD4d8ZrUDDPHmyDJSEsI20qAhuLHn5fEuSti1BoHqPYTgt 4grpaSCt0bbih1K0zOxIlmjVV6USodqirDt7KDjJ4CIKY/Hg3AWQy9YC5qGvz6APa9i04WGCq2r l3dzGQ1cTPdkLszHJRYvtTjTHJKB0xoI+c4zwhy2VteOYryAVSRjmyBW86AUry1gd0CWY1O4w4j ydV02E9HZTtsK+r0XgnjlB7Ylrja5LW8oUSR0kkGxECHxaZMBwbZYBYdvap6SswcLuSaZJZzlLq E1zO6+EMMprcbiest X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--2.969900-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24892.003 X-MDID: 1567764561-utWbbW_FI_oQ Subject: Re: [dpdk-dev] [PATCH v3 14/54] net/failsafe: check status of getting ethdev info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, On 9/6/19 12:28 PM, Gaëtan Rivet wrote: > Hi Andrew, Ivan, > > On Fri, Sep 06, 2019 at 08:30:26AM +0100, Andrew Rybchenko wrote: >> From: Ivan Ilchenko >> >> rte_eth_dev_info_get() return value was changed from void to >> int, so this patch modify rte_eth_dev_info_get() usage across >> net/failsafe according to its new return type. >> >> Signed-off-by: Ivan Ilchenko >> Signed-off-by: Andrew Rybchenko >> Acked-by: Gaetan Rivet >> --- >> drivers/net/failsafe/failsafe_ops.c | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/net/failsafe/failsafe_ops.c b/drivers/net/failsafe/failsafe_ops.c >> index 96e05d4dc4..b3df626aaa 100644 >> --- a/drivers/net/failsafe/failsafe_ops.c >> +++ b/drivers/net/failsafe/failsafe_ops.c >> @@ -866,6 +866,7 @@ fs_dev_infos_get(struct rte_eth_dev *dev, >> { >> struct sub_device *sdev; >> uint8_t i; >> + int ret; >> >> /* Use maximum upper bounds by default */ >> infos->max_rx_pktlen = UINT32_MAX; >> @@ -933,7 +934,9 @@ fs_dev_infos_get(struct rte_eth_dev *dev, >> FOREACH_SUBDEV_STATE(sdev, i, dev, DEV_PROBED) { >> struct rte_eth_dev_info sub_info; >> >> - rte_eth_dev_info_get(PORT_ID(sdev), &sub_info); >> + ret = rte_eth_dev_info_get(PORT_ID(sdev), &sub_info); >> + if (ret != 0) >> + return; > Similar to the promiscuous thread, I actually forgot about fs_err(); > You should use it here as well. Got it, will fix in the next version.