From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 22447425CA; Mon, 18 Sep 2023 07:09:09 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A69C0402D3; Mon, 18 Sep 2023 07:09:08 +0200 (CEST) Received: from VLXDG1SPAM1.ramaxel.com (email.unionmem.com [221.4.138.186]) by mails.dpdk.org (Postfix) with ESMTP id 797DC40263 for ; Mon, 18 Sep 2023 07:09:05 +0200 (CEST) Received: from V12DG1MBS03.ramaxel.local ([172.26.18.33]) by VLXDG1SPAM1.ramaxel.com with ESMTP id 38I58wjs008015; Mon, 18 Sep 2023 13:08:59 +0800 (GMT-8) (envelope-from wanry@3snic.com) Received: from [10.64.136.151] (10.64.136.151) by V12DG1MBS03.ramaxel.local (172.26.18.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2375.17; Mon, 18 Sep 2023 13:08:57 +0800 Message-ID: Date: Mon, 18 Sep 2023 13:08:57 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 06/32] net/sssnic/base: add message definition and utility To: Stephen Hemminger CC: , , Steven Song References: <20230904045658.238185-1-wanry@3snic.com> <20230904045658.238185-7-wanry@3snic.com> <20230917193119.78ce4cac@hermes.local> From: Renyong Wan In-Reply-To: <20230917193119.78ce4cac@hermes.local> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.64.136.151] X-ClientProxiedBy: V12DG1MBS03.ramaxel.local (172.26.18.33) To V12DG1MBS03.ramaxel.local (172.26.18.33) X-DNSRBL: X-SPAM-SOURCE-CHECK: pass X-MAIL: VLXDG1SPAM1.ramaxel.com 38I58wjs008015 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello, Stephen, data_buf is just used by control plane process, and it will not be used very frequtely, it has a little impact on IO performance. I'm not going to fix it. Thanks. On 2023/9/18 10:31, Stephen Hemminger wrote: > On Mon, 4 Sep 2023 12:56:32 +0800 > wrote: > >> +static int >> +sssnic_msg_buf_alloc(struct sssnic_msg *msg, size_t size) >> +{ >> + msg->data_buf = rte_zmalloc("sssnic_msg_data", size, 1); > Putting message buffer on same NUMA node as device might help > performance on NUMA architecture. -- Regards, Renyong Wan