From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <radu.nicolau@intel.com> Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id A4FF61B1C1 for <dev@dpdk.org>; Wed, 8 Nov 2017 16:40:20 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Nov 2017 07:40:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,364,1505804400"; d="scan'208";a="201432" Received: from rnicolau-mobl.ger.corp.intel.com (HELO [10.237.221.73]) ([10.237.221.73]) by fmsmga001.fm.intel.com with ESMTP; 08 Nov 2017 07:40:17 -0800 To: Thomas Monjalon <thomas@monjalon.net> Cc: dev@dpdk.org, ferruh.yigit@intel.com, wenzhuo.lu@intel.com, konstantin.ananyev@intel.com, pablo.de.lara.guarch@intel.com References: <1510147619-8701-1-git-send-email-radu.nicolau@intel.com> <14408406.FDyP0s16KU@xps> <6923ed2c-e62e-6454-0353-44f0c2afba08@intel.com> <7614729.vlcYnjIi5z@xps> From: Radu Nicolau <radu.nicolau@intel.com> Message-ID: <c8be51c1-90b5-4d8c-e991-e01be380030d@intel.com> Date: Wed, 8 Nov 2017 15:40:17 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <7614729.vlcYnjIi5z@xps> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH] doc: added inline crypto feature X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 08 Nov 2017 15:40:21 -0000 On 11/8/2017 3:13 PM, Thomas Monjalon wrote: > 08/11/2017 15:31, Radu Nicolau: >> On 11/8/2017 2:22 PM, Thomas Monjalon wrote: >>> 08/11/2017 14:26, Radu Nicolau: >>>> + >>>> +Inline crypto >>>> +------------- >>>> + >>>> +Supports inline crypto processing (eg. inline IPsec). See Security library for more details. >>> As there are several types of inline crypto, don't you think it deserves >>> several separate features? >> We don't differentiate in the offload, net, mbuf APIs; it's all >> "security offload". >> rte_security is the one that deals with different kinds of inline >> crypto, but in the NIC section it's all the same. > OK > How can we document which kind of inline crypto is supported with which device? I propose to change "See Security library for more details" to "See Security library and PMD documentation for more details" and update ixgbe.rst with an "inline crypto" section.