From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0DA2CA0507; Thu, 31 Mar 2022 16:47:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A9279410FA; Thu, 31 Mar 2022 16:47:14 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 8D4B84014F for ; Thu, 31 Mar 2022 16:47:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1648738032; x=1680274032; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=7wXEp6a5aHEAfDP3WQxRXGBkh4faYdxmd0aLRtNZS6w=; b=lgC0yB30JtQAopBRg9y5gGweSCNlaGRkJL/2qxs0rkoDoHFqeXjgA1A2 6Pe+RHOlEqVVhyI+HrMpB8Vnrm/gV5Yh2xzrQENL37HpABl/5mRBzC8iH e9+LzEeZGh3EQaOosaWuwrXdTg6ov4NWpzMkhRTihbAF9lY0iM/VputHx yVS+bwvaVepkSdsY4KXDaNV2w/5iuCM/ralS9yfroN0Ciucc1dTBm/D2Z wwniXAAlI8b7nIV6pzfTvl0SpvAB47Tuv7Hpm97KJkrPhm7iNDklgKHxm o2Swh74SEFTDEowmnO9nheKhEdlsyIAG700Kw4U/KkeO8w6WrULE6Ssqm A==; X-IronPort-AV: E=McAfee;i="6200,9189,10302"; a="240447451" X-IronPort-AV: E=Sophos;i="5.90,225,1643702400"; d="scan'208";a="240447451" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Mar 2022 07:47:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,225,1643702400"; d="scan'208";a="566538923" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga008.jf.intel.com with ESMTP; 31 Mar 2022 07:47:11 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 31 Mar 2022 07:47:10 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 31 Mar 2022 07:47:03 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Thu, 31 Mar 2022 07:47:03 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.104) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Thu, 31 Mar 2022 07:47:02 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kIDzWvCZJuD9GalZGzu9N7SpPn/OqC4IcxDo3WAmWsIEgQ1XCQ4rCDY48puvEh2yN4mCiJF15MFV4mw3aKrBEFETXSVgmHep4LnOXzLvYn2DUYHE5KeLFWJ/+nGUwbZxU48BZUDkVMrmclHJnmQPbF6RLOq8iaqDBHbQlobCob+ARAY6A/DrWWCk3WLpdAKY5EdCUzGh6W6BKj8AO4Y3ZrXIbdk5euG9eqF6WF4IVjqSAF0jsrDMp88PfD09CQSeTOkb5k27lz3Zd+1CcREH4+aQiQda4Od0ssFlswP9ptT7XKS5uPuLZ86GTqsvWupDZBcXGYJJC5QDRMwMG3dbZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bmJyJQP8K4H8duuNGIHmS+pOi0aeQO0f79nO7lxuijc=; b=AxXRx2dO0XsgsCWNEmFmJEpfqzApwjpL3/ACqobXl+zK4uP2i7c9Qf09wP3Eq1vsBtEmdce1H+JGXLRS27GUNzydzKbknNU1kpWRpG210eatSMcc7sWZVxewkfzaGXj4WxNYhBh8TD9IML/PLCWsOHdsAP8dUIMQnTEwDM9S0p4R7VDzGzBqP9hp0cNEcmPj6DyAtPvUt028pTItuFjb3Md2YCeYbemIn1hFdb45MxIGv/feXcNl52446/lUVKKsJEAJsLRP14ym3aLRwSg4ZlwGv+tiGEwG3EeZ9c/GWneWs8SNjlNPsD4F3bMO6SVM3DNNlUosMHPUgKEh77zMFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5093.namprd11.prod.outlook.com (2603:10b6:510:3e::23) by BY5PR11MB4133.namprd11.prod.outlook.com (2603:10b6:a03:18f::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.20; Thu, 31 Mar 2022 14:47:01 +0000 Received: from PH0PR11MB5093.namprd11.prod.outlook.com ([fe80::1068:ac4c:532e:d810]) by PH0PR11MB5093.namprd11.prod.outlook.com ([fe80::1068:ac4c:532e:d810%6]) with mapi id 15.20.5123.023; Thu, 31 Mar 2022 14:47:01 +0000 Message-ID: Date: Thu, 31 Mar 2022 15:46:56 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.7.0 Subject: Re: [PATCH] eal/linux: enable the hugepage mem dump Content-Language: en-US To: Li Feng CC: References: <20220308094125.2716847-1-fengli@smartx.com> From: "Burakov, Anatoly" In-Reply-To: <20220308094125.2716847-1-fengli@smartx.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB6PR0301CA0067.eurprd03.prod.outlook.com (2603:10a6:6:30::14) To PH0PR11MB5093.namprd11.prod.outlook.com (2603:10b6:510:3e::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4fba45c1-6ef2-4670-b49c-08da13255097 X-MS-TrafficTypeDiagnostic: BY5PR11MB4133:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yC4kFLrImA0jMDAk/GVdxnebePDvqXYH4vg7n2w7/9EPVJ7DNKXLlp9iwiGJAMBAVOZEnhvNb+2NwY2NObeSgtgbIxFGquaTvIOy0+bs3GwgODsAkriasN2lyIwTU4/EjM7Xsk4bac6T2lH/fxmwmD5ofgdDsMt35Vm8yua8w41SRpad/Ci37EpuCaV2fYesnJP2XZDL4PT1RpJ0qqPiF3LHjDZ+O4J0H91dkkmvlmhFp7OOtgnBqvLMwBVebjc7VOMSrd5JKWJ4ToHQqhA+aQsaPR6B6IQxLMBC9DHg+37Lx2wWcLW9lt2jD71AIyDLfQe3Ny1dt+jwydNGQ6r+FwYL5L1NBDmLD8Gk5+IZhlv6psiOouf7eVzhGw43b2BbEPiMF9a4dnjZcaORoyJxBgZZ25tvvJur+UlWRw/nK2DLBPF/OrmnpJx82bWiJnKBu7GbxBt+YVjnApJDZWFDDqU3dmiMImS8q/tBsHTdKQgIVHaplT739KKGqNWFOyQwUF6Okm6/9OyD87ralIizHVIhR1anD/cg9odOu6Hz1T8KZeEjpxLF13zew06b/J1A6/AuB+1w3Gz9ZkRFNsZgrPy98MbKm3K3y70wRSsn2EPpVCd4/4H2I5qh8tvo6pOpaVzgu6eIgOfkxZ/PDyMf2az8rRDLD1WqBNMOUyIBKhidH8XjEude6e3JhYg286mMwOtV8RXmGzHTBx8uMRZyfu6FGxzA59z18MVZIAwegSg= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5093.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(4326008)(6666004)(26005)(8676002)(6916009)(316002)(186003)(6506007)(2906002)(31696002)(5660300002)(66476007)(66946007)(66556008)(86362001)(83380400001)(2616005)(6512007)(31686004)(6486002)(53546011)(508600001)(8936002)(38100700002)(36756003)(82960400001)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aFQxdjdZVXR0NnJ5eTJadUlKd04yb2JlUUY3WTdKR3ZHL0hGOWl2YTV4YkVS?= =?utf-8?B?WTJGWWZFN1NmNmhIc1RNMEdoSUlFKzY5eVYrYm1jeUZIdmhKa2ZSSFBSQ3pr?= =?utf-8?B?QmNwdEJCMzdGZ3Vxak41YTZLL3UyczlGWC92aFc4MU9FQ1d0RFJIb2NrNlEr?= =?utf-8?B?NXhIQzN4NHFkcjRQTjg2amZpWXF2N0dNcUZpbFJ3Q3FLMjZpWFAvdXBnMzdk?= =?utf-8?B?aEhaYmwvZkIveEk0bjJjbkxqcm9xcFNvelRCOW16SWt5RkRaYWUzQXlWQW5R?= =?utf-8?B?M3RXd2lDN1orOXJDdzVkTXBtNWpaeG1OaFFKZndBeUtjMk5najFCSGF6b0di?= =?utf-8?B?Ylk2YXR1VWc4cmwxOTJrZ25aNnUvVEt5VlZiamV1MDV6allBVFNNWWJjOWlj?= =?utf-8?B?aEJzRzVzNmt0cUw0UkxEMDgrRXdwOERzMFd1ckI0bVVqNDcxNTJwUG1nVmZM?= =?utf-8?B?dXpyVnJFUGNQd1llYnh1YXBBZ29vUmtNeWxRditJT2x5a2pHTGJXaHMvZURG?= =?utf-8?B?MFBuSGRubFYvbk53NDRYNUFKbVc2YmlPMThYeWJmaXpkMnQ2dHU3dmd0R2Y0?= =?utf-8?B?dXBOdGMwd05lcFVKVTM2eG90cVJWVzRySHB0NXo4U0VPdGtDMTl4bUNjN05R?= =?utf-8?B?VGwrQ3U1MTBjZ1g0Q3paWkVrQ0RqRHpSejZXTFZjZ0Z1RXBDb3FGS0htVWRz?= =?utf-8?B?Vk1GVnRRVWtRa0ZYTmtiRFFuRUJsZlNTV2FzMVFybzFHVEFWLzFCVnFJU1Nt?= =?utf-8?B?SVRWOU1vZlpWUG9Jc2NkR05lOGZQbXlTcHRDVUphZ0I3bHFFUkV5K2ZBcVh5?= =?utf-8?B?Z0E1ZFhhWFJSckQvOHBZYWNkV1NTSzdxQnhuR0VabGhkNDlWdGtUckdmMzhV?= =?utf-8?B?czU3MkR3Y29XdExBMTFvUHpMM3dkMDNiSkJqUnVMTE9RQTFpdHV1NkFCVjFn?= =?utf-8?B?Q0JldS9LS285bWh0VDlkcU80ZCtva0h0OWtvZkFWeElPd2oyZHlGaTZKMkhW?= =?utf-8?B?azgyOWQ5R3MvQzFYaXl2N0tUMmxpeUt5aExXNWY1RDRlamNEbWxvaVdKSXU2?= =?utf-8?B?M04wYXcvaGFOdEkzSzEwYTNDUUVGQkVzZmdoOU14RWVSV0RCRjNzdzRrYXJR?= =?utf-8?B?WEk0ayttV1NxT1lFa1FLYjIrWHBQNTQ3V0xzdkdqdGFjbjgraUZyRVFWYlBo?= =?utf-8?B?cmhEcGM0MHN5SkJWcFZmWmJQNGp1MG9vZHA4YVBXV3hTWkZtamV4N3ZOK2NX?= =?utf-8?B?Q0hiVlI3czhFK2ljMUhsVHNwdVk4RStkMXE0cTRqY1cvOE94bzIwYm5FVTNq?= =?utf-8?B?WHdLdDNaMmg4V0RqOVg1cWlYcHIvQ2pZM1BGNy9jWWp4TmhOZFNsd1B1NUQ3?= =?utf-8?B?QTl1RW1rdFlaMXpPNzU3WEFrWVBoRmhJK2tFYU51WWtJMEx6QVBXMm1jdVRR?= =?utf-8?B?QXBWL01nbVdlV3lEVlhvZnBhRFhZRjBTTmxrWGZ1c3Z5WUc2MitReXNrRk1r?= =?utf-8?B?blNHQm1OTXZqcFBVMjM3SE42d0JHV2F2SkhuSUZ6WEFZZnQxK3N2UFpyVm9q?= =?utf-8?B?eGY3WE9OZXhtUG05ajFYbUdwZ1MyVmZMUzROTnB2d3ZObXcyTWt1Qm00MXZX?= =?utf-8?B?cnNQNUtOcWVDeUVzZUtOOFFNd2hhellOZVZ1eEFwTmMyRC9sdWtTT3dLcXpv?= =?utf-8?B?UFdCK0ZPWWpBYWhERFpVU2IvUmMwdEk2Wk5naWd1V3hMZnhIV2YyWUwzMG9t?= =?utf-8?B?NHh1M1E0cTdneUxRU0dGbGxBNVRhNllBdm5obGdvcHlvTUtzb3YwTUtMSm10?= =?utf-8?B?ZHZpaVN3M1lvZDFjd2lyOFRBQVV5VEsxb2V3VENDUGxsdWp0ZTQvUlgydlNr?= =?utf-8?B?VkNxajF2eUFwMGM0VUZPeURzdk9wa3VVcmV0TUhFVXVPUWZDMEQ1K3k5QlNQ?= =?utf-8?B?WXV3UEYraXNwY2hRR0xzSmVTOEpxVlMydUk4U00xQ01xS0JVWnJQMFRDN3RR?= =?utf-8?B?SDAxaWdwMXk4OWF4eTZlNkxoT2QyRmo2dUd6d1p4ZkwvbFZuMHAxelpGWkc5?= =?utf-8?B?bnNMdnlFSWwzaUJyTHUrazRzY0JscmU5SlI1OTl6cXVQWHZ4cGgwMTY2dU5V?= =?utf-8?B?NmlPazNMdHVFeU5yUHJuRzlsM0ZmaTlITWRTTlZHNDRtNGNRRUh6bnFiSUxH?= =?utf-8?B?U3l2Sk9kOGVzRWs4L25GcTF1cis3T2pFYmJtNE14aENsNC9zU0c3REo1SHRy?= =?utf-8?B?TEtYZlVXUzZOcytvOUczbmYwWHI1czY5anZlNGRBRHZ0bFllRXdoWGUzaE5D?= =?utf-8?B?NTBuWFpuNG96czV0enhrSTM1eldmTVpnYVg0VDJUa0NxTjh2Mlc1SVVQdnVP?= =?utf-8?Q?u8kbeHryU7n5seCQ=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 4fba45c1-6ef2-4670-b49c-08da13255097 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5093.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2022 14:47:01.5853 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6E/HwiJ8XgML+FpMCeQG0Y3hmk40NuBMzVvkBXHNFsA5BTmmp/G0iCmieHHrUkWy260rTAs22yqnGt1ji/N1MyiAIF9OglWuGZgxBwSeD7c= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4133 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 08-Mar-22 9:41 AM, Li Feng wrote: > These hugepages include important structures. We should dump these > hugepages into a coredump file for debugging when generating a coredump. > > Signed-off-by: Li Feng > --- > lib/eal/linux/eal_memalloc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/lib/eal/linux/eal_memalloc.c b/lib/eal/linux/eal_memalloc.c > index f8b1588cae..d7c2eb14a1 100644 > --- a/lib/eal/linux/eal_memalloc.c > +++ b/lib/eal/linux/eal_memalloc.c > @@ -623,6 +623,8 @@ alloc_seg(struct rte_memseg *ms, void *addr, int socket_id, > goto resized; > } > > + eal_mem_set_dump(va, alloc_sz, true); > + > /* In linux, hugetlb limitations, like cgroup, are > * enforced at fault time instead of mmap(), even > * with the option of MAP_POPULATE. Kernel will send I am amicable to the idea of including allocated hugepage data in core dumps, but even with that assumption, i think you're setting the dump flag a little too early, and never cleanup if something fails down the line. Perhaps move this to the very end of the function, after we have succeeded in creating a new segment? -- Thanks, Anatoly