From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <radu.nicolau@intel.com> Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 2C8BF374F for <dev@dpdk.org>; Tue, 20 Jun 2017 13:38:16 +0200 (CEST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP; 20 Jun 2017 04:38:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,364,1493708400"; d="scan'208";a="116571449" Received: from rnicolau-mobl.ger.corp.intel.com (HELO [10.237.221.56]) ([10.237.221.56]) by fmsmga005.fm.intel.com with ESMTP; 20 Jun 2017 04:38:13 -0700 To: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "Pattan, Reshma" <reshma.pattan@intel.com>, "Jastrzebski, MichalX K" <michalx.k.jastrzebski@intel.com>, "dev@dpdk.org" <dev@dpdk.org> Cc: "Jain, Deepak K" <deepak.k.jain@intel.com>, "Van Haaren, Harry" <harry.van.haaren@intel.com>, "Azarewicz, PiotrX T" <piotrx.t.azarewicz@intel.com> References: <20170522143202.22424-1-michalx.k.jastrzebski@intel.com> <20170522143202.22424-2-michalx.k.jastrzebski@intel.com> <3AEA2BF9852C6F48A459DA490692831F0113CF3E@irsmsx110.ger.corp.intel.com> <6A0DE07E22DDAD4C9103DF62FEBC09093B5BBD53@shsmsx102.ccr.corp.intel.com> From: Radu Nicolau <radu.nicolau@intel.com> Message-ID: <c8cc74c2-3198-5e52-346e-1a929a3a0aec@intel.com> Date: Tue, 20 Jun 2017 12:38:12 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B5BBD53@shsmsx102.ccr.corp.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH 1/3] drivers/net: add support for IF-MIB and EtherLike-MIB for e1000 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 20 Jun 2017 11:38:17 -0000 Hi, On 5/23/2017 6:53 AM, Lu, Wenzhuo wrote: > Hi Michal, > >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pattan, Reshma >> Sent: Tuesday, May 23, 2017 12:35 AM >> To: Jastrzebski, MichalX K; dev@dpdk.org >> Cc: Jain, Deepak K; Van Haaren, Harry; Azarewicz, PiotrX T >> Subject: Re: [dpdk-dev] [PATCH 1/3] drivers/net: add support for IF-MIB and >> EtherLike-MIB for e1000 >> >> Hi, >> >> Can you add the description to the commit message, describing what has >> been done. >> >> General doubt I have , I see all IF-MIB and Ether-Like-MIB attributes are >> added as Xstats. >> But most of IF-MIB attributes are not stats, instead they are information >> about the interface/port. >> So I guess such attributes should be displayed using separate method? >> Everything being displayed as xstats might not be correct. > The same question as Reshma. Seems most of the added parameters (if not all) are not stats. Yes, they are indeed mostly information rather than actual statistics, but I would say it's a better choice to have them in the xstats rather than add a new API.