From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B2467A04AF; Mon, 4 May 2020 12:17:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0EAF21D483; Mon, 4 May 2020 12:17:00 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id A7B031D407 for ; Mon, 4 May 2020 12:16:57 +0200 (CEST) Received: from mx1-us1.ppe-hosted.com (unknown [10.7.65.64]) by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 0FF6D60067; Mon, 4 May 2020 10:16:57 +0000 (UTC) Received: from us4-mdac16-50.ut7.mdlocal (unknown [10.7.66.17]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 0E5952009B; Mon, 4 May 2020 10:16:57 +0000 (UTC) X-Virus-Scanned: Proofpoint Essentials engine Received: from mx1-us1.ppe-hosted.com (unknown [10.7.65.199]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 51F0F22004D; Mon, 4 May 2020 10:16:56 +0000 (UTC) Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 819BD180058; Mon, 4 May 2020 10:16:55 +0000 (UTC) Received: from [192.168.38.17] (10.17.10.39) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 4 May 2020 11:16:48 +0100 To: Wisam Jaddo , , , , , , References: <20200430093249.6772-2-wisamm@mellanox.com> <20200430103341.1845-1-wisamm@mellanox.com> <20200430103341.1845-2-wisamm@mellanox.com> From: Andrew Rybchenko Autocrypt: addr=arybchenko@solarflare.com; keydata= mQINBF2681gBEACbdTxu8eLL3UX2oAelsnK9GkeaJeUYSOHPJQpV7RL/iaIskqTwBRnhjXt7 j9UEwGA+omnOmqQMpeQTb/F9Ma2dYE+Hw4/t/1KVjxr3ehFaASvwR4fWJfO4e2l/Rk4rG6Yi 5r6CWU2y8su2654Fr8KFc+cMGOAgKoZTZHZsRy5lHpMlemeF+VZkv8L5sYJWPnsypgqlCG3h v6lbtfZs+QqYbFH6bqoZwBAl5irmxywGR7ZJr1GLUZZ1lfdazSY8r6Vz0/Ip/KVxGu2uxo81 QCsAj0ZsQtwji9Sds/prTiPrIjx8Fc/tfbnAuVuPcnPbczwCJACzQr4q26XATL3kVuZhSBWh 4XfO/EAUuEq5AemUG5DDTM87g7Lp4eT9gMZB6P+rJwWPNWTiV3L7Cn+fO+l9mTPnOqdzBgDe OaulKiNSft1o0DY4bGzOmM2ad2cZt0jfnbMPMTE9zsr6+RFa+M8Ct20o6U1MUE4vP6veErMK of4kZ8PdoMM+Sq1hxMPNtlcVBSP9xMmdSZPlfDYI5VWosOceEcz7XZdjBJKdwKuz70V7eac4 ITSxgNFCTbeJ03zL2MR5s0IvD9ghISAwZ6ieCjU5UATn5+63qpD0nVNLsAdb/UpfvQcKAmvj 0fKlxu/PMVkjBa7/4cfNogYOhWDKUO+1pMaFwvb6/XTo6uMpfQARAQABtCxBbmRyZXcgUnli Y2hlbmtvIDxhcnliY2hlbmtvQHNvbGFyZmxhcmUuY29tPokCVAQTAQoAPhYhBP6NPgcKRj/Y X0yXQahue0sAy4m+BQJduvNYAhsDBQkB4TOABQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJ EKhue0sAy4m+t3gP/j1MNc63CEozZo1IZ2UpVPAVWTYbLdPjIRdFqhlwvZYIgGIgIBk3ezKL K0/oc4ZeIwL6wQ5+V24ahuXvvcxLlKxfbJ6lo2iQGC7GLGhsDG9Y2k6sW13/sTJB/XuR2yov k5FtIgJ+aHa1PDZnepnGGOt9ka9n/Jzrc9WKYapOIIyLRe9U26ikoVgyqsD37PVeq5tLWHHA NGTUKupe9G6DFWidxx0KzyMoWDTbW2AWYcEmV2eQsgRT094AZwLFN5ErfefYzsGdO8TAUU9X YTiQN2MvP1pBxY/r0/5UfwV4UKBcR0S3ZvzyvrPoYER2Kxdf/qurx0Mn7StiCQ/JlNZb/GWQ TQ7huduuZHNQKWm7ufbqvKSfbPYvfl3akj7Wl8/zXhYdLqb5mmK45HXrgYGEqPN53OnK2Ngx IgYKEWr05KNv09097jLT5ONgYvszflqlLIzC4dV245g7ucuf9fYmsvmM1p/gFnOJBJL18YE5 P1fuGYNfLP+qp4WMiDqXlzaJfB4JcinyU49BXUj3Utd6f6sNBsO8YWcLbKBV9WmA324S3+wj f4NPRp3A5E+6OmTVMLWire2ZvnYp3YvifUj1r8lhoZ2B2vKuWwiTlHOKYBEjnOQJQnqYZEF0 JQQ1xzVDBQKE01BPlA3vy6BGWe6I4psBVqMOB9lAev/H+xa4u6Z3uQINBF269JsBEAC2KB3W 8JES/fh74avN7LOSdK4QA7gFIUQ4egVL81KnxquLzzilABuOhmZf3Rq6rMHSM8xmUAWa7Dkt YtzXStjEBI/uF0mAR3mMz1RcL2Wp+WD/15HjVpA7hPjXSEsWY0K2ymPerK4yrLcfFTHdMonY JfuACCC9NtOZxrWHOJoUS+RT7AWk80q/6D2iwQ47/2dBTznVG+gSeHSes9l91TB09w6f9JX/ sT+Ud0NQfm7HJ7t2pmGI9O6Po/NLZsDogmnIpJp/WwYOZN9JK7u2FyX2UyRzR8jK42aJkRsh DXs16Cc2/eYGakjrdO3x9a+RoxN7EuFtYhGR1PzMXdUiB5i+FyddYXkYUyO43QE/3VPA5l1v TUOagzZq6aONsdNonGJkV3TIG3JmUNtM+D/+r6QKzmgoJ8w576JxEZI09I/ZFN+g7BnUmlMx 6Z3IUOXVX/SWfGFga0YajwajHz03IBhChEbYbbqndVhmshu2GFURxrfUPYWdDXEqkh+08a5U Didia9jm2Opv4oE1e1TXAePyYJl/Zyps4Cv00GObAxibvMBQCUZQ+IBnNldRBOwXXRQV2xpx P+9iO1VYA/QXn0KqRK+SH1JGRXbJYi42YFaW1gE0EU0fiR2Wb9pK+doNEjjOhlzUGuvOEAUS +4m0m3dlfEvpCV9GMr7ERRpZzh9QkQARAQABiQI8BBgBCgAmFiEE/o0+BwpGP9hfTJdBqG57 SwDLib4FAl269JsCGwwFCQlmAYAACgkQqG57SwDLib7x6g//e+eCtNnJz7qFGbjWRJYNLCe5 gQwkhdyEGk4omr3VmjGj3z9kNFy/muh4pmHUngSAnnpwZggx14N4hhKf9y8G4Dwvsqa6b1zB Jq/c4t/SBDtGW4M/E331N04PaQZpcrbTfp1KqHNknk2N7yOk4CcoLVuIZmA5tPguASV8aAfz ZwhWAwn6vUEw9552eXEAnGFGDTCbyryNwzB5jtVQOEEDjTxcCkpcXMB45Tb1QUslRTu/sBAe HhPCQSUcJHR+KOq+P6yKICGAr291PZd6Qc7C3UyE+A3pY/UfdEVWj0STBWx1qvYLaHLrI4O9 KXDgh7luLjZZafcueCaPYmNo4V2lmNb3+7S4TvqhoZS+wN+9ldRQ4gH3wmRZybN6Y/ZCqxol RaZpE3AqdWsGvIgAkD0FpmtZNii9s2pnrhw0K6S4t4tYgXGTossxNSJUltfFQZdXM1xkZhtv dBZuUEectbZWuviGvQXahOMuH2pM64mx2hpdZzPcI2beeJNHkAsGT2KcaMETgvtHUBFRlLVB YxsUYz3UZmi2JSua4tbcGd6iWVN90eb8CxszYtivfpz6o2nPSjNwg0NaVGSHXjAK0tdByZ9t SkwjC3tEPljVycRSDpbauogOiAkvjENfaPd/H26V5hY822kaclaKDAW6ZG9UKiMijcAgb9u5 CJoOyqE8aGS5Ag0EXbr1RwEQAMXZHbafqmZiu6Kudp+Filgdkj2/XJva5Elv3fLfpXvhVt0Y if5Rzds3RpffoLQZk9nPwK8TbZFqNXPu7HSgg9AY7UdCM94WRFTkUCGKzbgiqGdXZ7Vyc8cy teGW+BcdfQycDvjfy50T3fO4kJNVp2LDNdknPaZVe8HJ80Od63+9ksB6Ni+EijMkh6Uk3ulB CSLnT4iFV57KgU2IsxOQVLnm+0bcsWMcCnGfphkY0yKP+aJ6MfmZkEeaDa7kf24N14ktg50m vOGDitcxA/+XXQXOsOIDJx1VeidxYsQ2FfsKu1G8+G6ejuaLf4rV5MI/+B/tfLbbOdikM5PF pxZVgTir9q13qHumMxdme7w5c7hybW412yWAe9TsrlXktFmFjRSFzAAxQhQSQxArS6db4oBk yeYJ59mW52i4occkimPWSm/raSgdSM+0P6zdWUlxxj+r1qiLgCYvruzLNtp5Nts5tR/HRQjE /ohQYaWDSVJEsc/4eGmgwzHzmvHtXeKkasn01381A1Lv3xwtpnfwERMAhxBZ8EGKEkc5gNdk vIPhknnGgPXqKmE1aWu8LcHiY+RHAF8gYPCDMuwyzBYnbiosKcicuIUp0Fj8XIaPao6F+WTi In4UOrqrYhsaCUvhVjsTBbNphGih9xbFJ8E+lkTLL8P3umtTcMPnpsB4xqcDABEBAAGJBHIE GAEKACYWIQT+jT4HCkY/2F9Ml0GobntLAMuJvgUCXbr1RwIbAgUJCWYBgAJACRCobntLAMuJ vsF0IAQZAQoAHRYhBNTYjdjWgdaEN5MrAN+9UR5r/4d3BQJduvVHAAoJEN+9UR5r/4d3EiQP /3lyby6v49HTU94Q2Fn2Xat6uifR7kWE5SO/1pUwYzx6v+z5K2jqPgqUYmuNoejcGl0CTNhg LbsxzUmAuf1OTAdE+ZYvOAjjKQhY4haxHc4enby/ltnHfWJYWJZ9UN5SsIQLvITvYu6rqthO CYjpXJhwkj3ODmC9H1TrvjrBGc6i7CTnR8RCjMEwCs2LI2frHa4R6imViEr9ScMfUnzdABMQ B0T5MOg8NX92/FRjTldU2KovG0ML9mSveSvVHAoEBLy4UIs5nEDdNiO1opJgKb5CXvWQugub 7AR52phNdKVdEB0S4tigJT4NalyTaPiUhFEm+CzZpMQDJ5E+/OowaPRfN4HeJX+c8sB+vUAZ mkAaG75N+IEk5JKFK9Z+bBYgPgaBDFZYdWDB/TMH0ANt+KI5uYg0i12TB4M8pwKG1DEPUmWc F2YpvB3jnbwzsOpSFiJOOlSs6nOB0Sb5GRtPOO3h6XGj+6mzQd6tcL63c9TrrUkjq7LDkxCz SJ2hTYRC8WNX8Uw9skWo5728JNrXdazEYCenUWmYiKLNKLslXCFodUCRDh/sUiyqRwS7PHEA LYC/UIWLMomI0Yvju3KA5v3RQVXhL+Gx2CzSj3GDz9xxGhJB2LfRfjzPbTR/Z27UpjCkd8z0 Ro3Ypmi1FLQwnRgoOKDbetTAIhugEShaLTITzJAP/iRDJCQsrZah5tE8oIl81qKEmBJEGcdt HYikbpQe7ydcXhqTj7+IECa3O7azI5OhCxUH2jNyonJ/phUslHH2G1TTBZK8y4Hrx5RpuRNS esn3P9uKu9DHqBAL7DMsCPwb2p1VNnapD72DBmRhzS/e6zS2R4+r9yNv03Hv7VCxKkmtE63H qpS//qpjfrtsIcHAjnKDaDtL1LYCtHoweI+DOpKKULSAYp/JE6F8LNibPQ0/P3S5ZIJNC4QZ uESjFOalJwFIqGQdkQB7ltRNJENLrHc+2jKGOuyFHm/Sbvp5EMGdaeQ0+u8CY0P+y6oXenwx 7WrJz/GvbNoFhJoJ6RzxCMQrFgxrssVZ7w5HcUj94lbnJ6osdYE/WpSd50B6jet6LKh5revg u9XI9CoqsPQ1V4wKYYdllPuogCye7KNYNKuiiuSNpaF4gHq1ZWGArwZtWHjgc2v3LegOpRQF SwOskMKmWsUyHIRMG1p8RpkBQTqY2rGSeUqPSvaqjT0nq+SUEM6qxEXD/2Wqri/X6bamuPDb S0PkBvFD2+0zr5Bc2YkMGPBYPNGZiTp3UjmZlLfn3TiBKIC92jherY563CULjSsiBEJCOSvv 4VPLn5aAcfbCXJnE3IGCp/hPl50iQqu7BPOYBbWXeb9ptDjGCAThNxSz0WAXkmcjAFE8gdE6 Znk9 Message-ID: Date: Mon, 4 May 2020 13:16:45 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200430103341.1845-2-wisamm@mellanox.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.17.10.39] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1020-25394.003 X-TM-AS-Result: No-23.066300-8.000000-10 X-TMASE-MatchedRID: CxmI61mtwh/mLzc6AOD8DfHkpkyUphL9NV9S7O+u3KaLpJo1lI9JPSXD Fxgit6TpmASPBg63wn0IMw6sK1dsXxHQbVLgwnYMPwKTD1v8YV4/pOSL72dTf6/Hc9OllBvzilv Ab18i4hPHHgVbmRIf7XxRcXTbsQOLcKE8cHrXBCOxCl9NrK01yExBQtM1e2ykNukyDIB+HboN5/ Na9XIDiJiSIbwYp2UMctFKlWcW3StQpsjiSauwtOqDKkj02EZ1N6i7v/DQHPwi0/kre3Gpupodm frfaL+pLzeCXA/92P18P/Hz+a0ubtWssQsVvEDfRRDrDHhyfDcaJDwYgQY/f09EvF53ySNIqD++ ZEQsJZsC993vQ9JgHmCU654MyWGIhcJKosB9JzgkNyKZAiu8eARryDXHx6oXUYvAleUDiYjLoSk lLumi5t1gDcwhte0zN07fFsycXN3fwK7EOTp9fNB/IoRhBzVHzPMyzZ3J7JXnFbV0/Qg1WndvO8 u+q1pdsTCecWdCeadd4mGONK9Uo9K59TYQRtph1uDM+OtX7BxrTWaGefu3pAQsw9A3PIlLXWjvA 8TpWFhr5ES52HqTuFRvhG2NiJZcR+vpYbhOH1o1UeSqWmPpVeZM8S4DYUopR2YNIFh+clGWbof1 MWFRtaduP8GQpunyWMOXGj3OPvVLF43MnY8dlikOcvAILLFlKPpRNtqt/LVXPwnnY5XL5PsOQKE 3xal1xgY8yx/4w40OmeOLyzLstB4FELx/MQz0dXu122+iJtovV5f7P0HVDH/nRXkdtDN89mZKfm IAS+ZgKqzn+P0vq2/t8FoZRGoOv3Pg+VibUGaeAiCmPx4NwLTrdaH1ZWqC1B0Hk1Q1KyJHtBsf5 /UXJWbyfuMOJ2Z13QfwsVk0UbslCGssfkpInQ== X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--23.066300-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1020-25394.003 X-MDID: 1588587416-pgaCT98xjpjN Subject: Re: [dpdk-dev] [PATCH v4 1/5] app/test-flow-perf: add flow performance skeleton X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/30/20 1:33 PM, Wisam Jaddo wrote: > Add flow performance application skeleton. > > Signed-off-by: Wisam Jaddo > --- > MAINTAINERS | 5 + > app/Makefile | 1 + > app/meson.build | 1 + > app/test-flow-perf/Makefile | 26 +++ > app/test-flow-perf/main.c | 246 +++++++++++++++++++++++++++ > app/test-flow-perf/meson.build | 11 ++ > app/test-flow-perf/user_parameters.h | 16 ++ > config/common_base | 5 + > doc/guides/tools/flow-perf.rst | 69 ++++++++ > doc/guides/tools/index.rst | 1 + > 10 files changed, 381 insertions(+) > create mode 100644 app/test-flow-perf/Makefile > create mode 100644 app/test-flow-perf/main.c > create mode 100644 app/test-flow-perf/meson.build > create mode 100644 app/test-flow-perf/user_parameters.h > create mode 100644 doc/guides/tools/flow-perf.rst > > diff --git a/MAINTAINERS b/MAINTAINERS > index d31a809292..b5632c1bf5 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1504,6 +1504,11 @@ T: git://dpdk.org/next/dpdk-next-net > F: app/test-pmd/ > F: doc/guides/testpmd_app_ug/ > > +Flow performance tool > +M: Wisam Jaddo > +F: app/test-flow-perf > +F: doc/guides/flow-perf.rst > + Shouldn't it be alphabetially sorted? I think by app name. > Compression performance test application > T: git://dpdk.org/next/dpdk-next-crypto > F: app/test-compress-perf/ > diff --git a/app/Makefile b/app/Makefile > index 823771c5fc..bd823f3db7 100644 > --- a/app/Makefile > +++ b/app/Makefile > @@ -9,6 +9,7 @@ DIRS-$(CONFIG_RTE_PROC_INFO) += proc-info > DIRS-$(CONFIG_RTE_LIBRTE_PDUMP) += pdump > DIRS-$(CONFIG_RTE_LIBRTE_ACL) += test-acl > DIRS-$(CONFIG_RTE_LIBRTE_CMDLINE) += test-cmdline > +DIRS-$(CONFIG_RTE_TEST_FLOW_PERF) += test-flow-perf > DIRS-$(CONFIG_RTE_LIBRTE_FIB) += test-fib > DIRS-$(CONFIG_RTE_LIBRTE_PIPELINE) += test-pipeline > DIRS-$(CONFIG_RTE_LIBRTE_IPSEC) += test-sad > diff --git a/app/meson.build b/app/meson.build > index 0f7fe94649..e26f5b72f5 100644 > --- a/app/meson.build > +++ b/app/meson.build > @@ -14,6 +14,7 @@ apps = [ > 'test-compress-perf', > 'test-crypto-perf', > 'test-eventdev', > + 'test-flow-perf', I think 'l' goes after 'i'. > 'test-fib', > 'test-pipeline', > 'test-pmd', > diff --git a/app/test-flow-perf/Makefile b/app/test-flow-perf/Makefile > new file mode 100644 > index 0000000000..45b1fb1464 > --- /dev/null > +++ b/app/test-flow-perf/Makefile > @@ -0,0 +1,26 @@ > +# SPDX-License-Identifier: BSD-3-Clause > +# Copyright 2020 Mellanox Technologies, Ltd > + > +include $(RTE_SDK)/mk/rte.vars.mk > + > +ifeq ($(CONFIG_RTE_TEST_FLOW_PERF),y) > + > +# > +# library name > +# > +APP = flow_perf > + > +CFLAGS += -DALLOW_EXPERIMENTAL_API > +CFLAGS += -O3 > +CFLAGS += $(WERROR_FLAGS) > +CFLAGS += -Wno-deprecated-declarations > +CFLAGS += -Wno-unused-function Why is unused function warning disabled? > + > +# > +# all source are stored in SRCS-y > +# > +SRCS-y += main.c > + > +include $(RTE_SDK)/mk/rte.app.mk > + > +endif > diff --git a/app/test-flow-perf/main.c b/app/test-flow-perf/main.c > new file mode 100644 > index 0000000000..156b9ef553 > --- /dev/null > +++ b/app/test-flow-perf/main.c > @@ -0,0 +1,246 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * > + * This file contain the application main file > + * This application provides the user the ability to test the > + * insertion rate for specific rte_flow rule under stress state ~4M rule/ > + * > + * Then it will also provide packet per second measurement after installing > + * all rules, the user may send traffic to test the PPS that match the rules > + * after all rules are installed, to check performance or functionality after > + * the stress. > + * > + * The flows insertion will go for all ports first, then it will print the > + * results, after that the application will go into forwarding packets mode > + * it will start receiving traffic if any and then forwarding it back and > + * gives packet per second measurement. > + * > + * Copyright 2020 Mellanox Technologies, Ltd > + */ > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include It looks like many-many above headers are actulally unused. Please, remove unused headers. > + > +#include "user_parameters.h" > + > +static uint32_t nb_lcores; > +static struct rte_mempool *mbuf_mp; > + > +static void usage(char *progname) > +{ > + printf("\nusage: %s", progname); Is \n missing at the end of format string? > +} > + > +static void > +args_parse(int argc, char **argv) > +{ > + char **argvopt; > + int opt; > + int opt_idx; > + static struct option lgopts[] = { > + /* Control */ > + { "help", 0, 0, 0 }, > + }; > + > + argvopt = argv; > + > + while ((opt = getopt_long(argc, argvopt, "", > + lgopts, &opt_idx)) != EOF) { > + switch (opt) { > + case 0: > + if (!strcmp(lgopts[opt_idx].name, "help")) { > + usage(argv[0]); > + rte_exit(EXIT_SUCCESS, "Displayed help\n"); > + } > + break; > + default: > + usage(argv[0]); > + printf("Invalid option: %s\n", argv[optind]); I think it is more friendly to log errors to stderr and log invalid option message first before usage. > + rte_exit(EXIT_SUCCESS, "Invalid option\n"); > + break; > + } > + } > +} > + > +static void > +init_port(void) > +{ > + int ret; > + uint16_t i, j; > + uint16_t port_id; > + uint16_t nr_ports = rte_eth_dev_count_avail(); > + struct rte_eth_hairpin_conf hairpin_conf = { > + .peer_count = 1, > + }; > + struct rte_eth_conf port_conf = { > + .rxmode = { > + .split_hdr_size = 0, I think it is not required, since compiler will do it for you anyway having below initialization. > + }, > + .rx_adv_conf = { > + .rss_conf.rss_hf = > + ETH_RSS_IP | > + ETH_RSS_UDP | May be it is better to remove ETH_RSS_UDP by default, since it is less common that RSS for TCP because of possible fragmentation and packets from the same stream delivered to different CPU cores. > + ETH_RSS_TCP, > + } > + }; > + struct rte_eth_txconf txq_conf; > + struct rte_eth_rxconf rxq_conf; > + struct rte_eth_dev_info dev_info; > + > + if (nr_ports == 0) > + rte_exit(EXIT_FAILURE, "Error: no port detected\n"); Please, add empty line here to logically separate above error from pool creation. Right now it looks misleading. > + mbuf_mp = rte_pktmbuf_pool_create("mbuf_pool", > + TOTAL_MBUF_NUM, MBUF_CACHE_SIZE, > + 0, MBUF_SIZE, > + rte_socket_id()); > + > + if (mbuf_mp == NULL) > + rte_exit(EXIT_FAILURE, "Error: can't init mbuf pool\n"); > + > + for (port_id = 0; port_id < nr_ports; port_id++) { > + ret = rte_eth_dev_info_get(port_id, &dev_info); > + if (ret != 0) > + rte_exit(EXIT_FAILURE, > + "Error during getting device (port %u) info: %s\n", The line looks long. More than 80 symbols. Please, use just one TAB to indent relative to rte_exit(). It will make the line a bit shorter. > + port_id, strerror(-ret)); > + > + port_conf.txmode.offloads &= dev_info.tx_offload_capa; Taking into account that txmode.offloads are 0 above, it looks strange. May be it is added to early in the patch series? > + printf(":: initializing port: %d\n", port_id); > + ret = rte_eth_dev_configure(port_id, RXQs + HAIRPIN_QUEUES, > + TXQs + HAIRPIN_QUEUES, &port_conf); RXQs and TXQs are bad since mixing upper and lower cases letters is bad. Macros are in upper case typically. May be RXQ_NUM? Or NR_RXQ (however, it will be very easy to missread as NR_RXD and vise versa, so not good)? > + if (ret < 0) > + rte_exit(EXIT_FAILURE, > + ":: cannot configure device: err=%d, port=%u\n", Too long line, decrease indent > + ret, port_id); > + > + rxq_conf = dev_info.default_rxconf; > + rxq_conf.offloads = port_conf.rxmode.offloads; Same here. Also it should take supported offloads into account. > + for (i = 0; i < RXQs; i++) { > + ret = rte_eth_rx_queue_setup(port_id, i, NR_RXD, > + rte_eth_dev_socket_id(port_id), > + &rxq_conf, > + mbuf_mp); > + if (ret < 0) > + rte_exit(EXIT_FAILURE, > + ":: Rx queue setup failed: err=%d, port=%u\n", Too long line, decrease indent > + ret, port_id); > + } > + > + txq_conf = dev_info.default_txconf; > + txq_conf.offloads = port_conf.txmode.offloads; Same here. Also it should take supported offloads into account. > + > + for (i = 0; i < TXQs; i++) { > + ret = rte_eth_tx_queue_setup(port_id, i, NR_TXD, > + rte_eth_dev_socket_id(port_id), > + &txq_conf); > + if (ret < 0) > + rte_exit(EXIT_FAILURE, > + ":: Tx queue setup failed: err=%d, port=%u\n", Too long line, decrease indent > + ret, port_id); > + } > + > + ret = rte_eth_promiscuous_enable(port_id); > + if (ret != 0) > + rte_exit(EXIT_FAILURE, > + ":: promiscuous mode enable failed: err=%s, port=%u\n", Too long line, decrease indent > + rte_strerror(-ret), port_id); > + > + for (i = RXQs, j = 0; i < RXQs + HAIRPIN_QUEUES; i++, j++) { > + hairpin_conf.peers[0].port = port_id; > + hairpin_conf.peers[0].queue = j + TXQs; > + ret = rte_eth_rx_hairpin_queue_setup(port_id, i, > + NR_RXD, &hairpin_conf); > + if (ret != 0) > + rte_exit(EXIT_FAILURE, > + ":: Hairpin rx queue setup failed: err=%d, port=%u\n", > + ret, port_id); > + } > + > + for (i = TXQs, j = 0; i < TXQs + HAIRPIN_QUEUES; i++, j++) { > + hairpin_conf.peers[0].port = port_id; > + hairpin_conf.peers[0].queue = j + RXQs; > + ret = rte_eth_tx_hairpin_queue_setup(port_id, i, > + NR_TXD, &hairpin_conf); > + if (ret != 0) > + rte_exit(EXIT_FAILURE, > + ":: Hairpin tx queue setup failed: err=%d, port=%u\n", > + ret, port_id); > + } > + > + ret = rte_eth_dev_start(port_id); > + if (ret < 0) > + rte_exit(EXIT_FAILURE, > + "rte_eth_dev_start:err=%d, port=%u\n", > + ret, port_id); > + > + printf(":: initializing port: %d done\n", port_id); > + } > +} > + > +int > +main(int argc, char **argv) > +{ > + uint16_t lcore_id; > + uint16_t port; > + uint16_t nr_ports; > + int ret; > + struct rte_flow_error error; > + > + nr_ports = rte_eth_dev_count_avail(); Before EAL init? It is defintely unclear. If it is done by purpose, please, add a comment to explain why. > + ret = rte_eal_init(argc, argv); > + if (ret < 0) > + rte_exit(EXIT_FAILURE, "EAL init failed\n"); > + > + argc -= ret; > + argv += ret; > + > + if (argc > 1) > + args_parse(argc, argv); > + > + init_port(); > + > + nb_lcores = rte_lcore_count(); > + > + if (nb_lcores <= 1) > + rte_exit(EXIT_FAILURE, "This app needs at least two cores\n"); > + > + RTE_LCORE_FOREACH_SLAVE(lcore_id) > + > + if (rte_eal_wait_lcore(lcore_id) < 0) > + break; Break what? Is it compile tested? > + > + for (port = 0; port < nr_ports; port++) { > + rte_flow_flush(port, &error); > + rte_eth_dev_stop(port); > + rte_eth_dev_close(port); > + } > + return 0; > +} > diff --git a/app/test-flow-perf/meson.build b/app/test-flow-perf/meson.build > new file mode 100644 > index 0000000000..ec9bb3b3aa > --- /dev/null > +++ b/app/test-flow-perf/meson.build > @@ -0,0 +1,11 @@ > +# SPDX-License-Identifier: BSD-3-Clause > +# Copyright(c) 2020 Mellanox Technologies, Ltd > + > +# meson file, for building this example as part of a main DPDK build. > +# > +# To build this example as a standalone application with an already-installed > +# DPDK instance, use 'make' > + > +sources = files( > + 'main.c', > +) > diff --git a/app/test-flow-perf/user_parameters.h b/app/test-flow-perf/user_parameters.h > new file mode 100644 > index 0000000000..56ec7f47b5 > --- /dev/null > +++ b/app/test-flow-perf/user_parameters.h > @@ -0,0 +1,16 @@ > +/* SPDX-License-Identifier: BSD-3-Claus > + * > + * This file will hold the user parameters values > + * > + * Copyright 2020 Mellanox Technologies, Ltd > + */ > + > +/** Configuration **/ > +#define RXQs 4 > +#define TXQs 4 > +#define HAIRPIN_QUEUES 4 It makes it Mellanox-speicific from the first patch since only mlx5 supports hairpin queues. Such things should be specified using parameters from the very beginning. > +#define TOTAL_MBUF_NUM 32000 > +#define MBUF_SIZE 2048 > +#define MBUF_CACHE_SIZE 512 > +#define NR_RXD 256 > +#define NR_TXD 256 > diff --git a/config/common_base b/config/common_base > index 14000ba07e..eaaeaaaee2 100644 > --- a/config/common_base > +++ b/config/common_base > @@ -1124,3 +1124,8 @@ CONFIG_RTE_APP_CRYPTO_PERF=y > # Compile the eventdev application > # > CONFIG_RTE_APP_EVENTDEV=y > + > +# > +# Compile the rte flow perf application > +# > +CONFIG_RTE_TEST_FLOW_PERF=y CONFIG_RTE_APP_FLOW_PERF to follow naming conventions. > diff --git a/doc/guides/tools/flow-perf.rst b/doc/guides/tools/flow-perf.rst > new file mode 100644 > index 0000000000..30ce1b6cc0 > --- /dev/null > +++ b/doc/guides/tools/flow-perf.rst > @@ -0,0 +1,69 @@ > +.. SPDX-License-Identifier: BSD-3-Clause > + Copyright 2020 Mellanox Technologies, Ltd > + > +RTE Flow performance tool > +========================= > + > +Application for rte_flow performance testing. > + > + > +Compiling the Application > +========================= > +The ``test-flow-perf`` application is compiled as part of the main compilation > +of the DPDK libraries and tools. > + > +Refer to the DPDK Getting Started Guides for details. > +The basic compilation steps are: > + > +#. Set the required environmental variables and go to the source directory: > + > + .. code-block:: console > + > + export RTE_SDK=/path/to/rte_sdk > + cd $RTE_SDK > + > +#. Set the compilation target. For example: > + > + .. code-block:: console > + > + export RTE_TARGET=x86_64-native-linux-gcc > + > +#. Build the application: > + > + .. code-block:: console > + > + make install T=$RTE_TARGET > + > +#. The compiled application will be located at: > + > + .. code-block:: console > + > + $RTE_SDK/$RTE_TARGET/app/flow-perf > + > + > +Running the Application > +======================= > + > +EAL Command-line Options > +------------------------ > + > +Please refer to :doc:`EAL parameters (Linux) <../linux_gsg/linux_eal_parameters>` > +or :doc:`EAL parameters (FreeBSD) <../freebsd_gsg/freebsd_eal_parameters>` for > +a list of available EAL command-line options. > + > + > +Flow performance Options > +------------------------ > + > +The following are the command-line options for the flow performance application. > +They must be separated from the EAL options, shown in the previous section, with > +a ``--`` separator: > + > +.. code-block:: console > + > + sudo ./test-flow-perf -n 4 -w 08:00.0,dv_flow_en=1 -- > + > +The command line options are: > + > +* ``--help`` > + Display a help message and quit. > diff --git a/doc/guides/tools/index.rst b/doc/guides/tools/index.rst > index 782b30864e..7279daebc6 100644 > --- a/doc/guides/tools/index.rst > +++ b/doc/guides/tools/index.rst > @@ -16,3 +16,4 @@ DPDK Tools User Guides > cryptoperf > comp_perf > testeventdev > + flow-perf > I think above should be alphabetically sorted as well.