From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 81AF5A00E6 for ; Wed, 12 Jun 2019 16:18:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5F2531C5AE; Wed, 12 Jun 2019 16:18:48 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 461621C5A0; Wed, 12 Jun 2019 16:18:47 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Jun 2019 07:18:46 -0700 X-ExtLoop1: 1 Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.99]) ([10.237.220.99]) by fmsmga005.fm.intel.com with ESMTP; 12 Jun 2019 07:18:45 -0700 To: Herakliusz Lipiec Cc: dev@dpdk.org, stable@dpdk.org References: <20190612133323.43530-1-herakliusz.lipiec@intel.com> From: "Burakov, Anatoly" Message-ID: Date: Wed, 12 Jun 2019 15:18:44 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190612133323.43530-1-herakliusz.lipiec@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] app/test: fix autotest_runner crash X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12-Jun-19 2:33 PM, Herakliusz Lipiec wrote: > On some systems when dpdk test is executed with make test command > autotest_runner crashes in first_cpu_on_node. This happens when list > of available cpus contains something that is not a cpu as first element. > Fixed by removing all non-cpu values from list of available cpus. > > Bugzilla ID: 253 > Fixes: 22dcd9a4d90f ("test: parallelize unit tests") > Cc: anatoly.burakov@intel.com > Cc: stable@dpdk.org > Signed-off-by: Herakliusz Lipiec > --- > app/test/autotest_runner.py | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/app/test/autotest_runner.py b/app/test/autotest_runner.py > index b72716e1e..7aece8905 100644 > --- a/app/test/autotest_runner.py > +++ b/app/test/autotest_runner.py > @@ -43,11 +43,10 @@ def get_numa_nodes(): > # find first (or any, really) CPU on a particular node, will be used to spread > # processes around NUMA nodes to avoid exhausting memory on particular node > def first_cpu_on_node(node_nr): > - cpu_path = glob.glob("/sys/devices/system/node/node%d/cpu*" % node_nr)[0] > - cpu_name = os.path.basename(cpu_path) > - m = re.match(r"cpu(\d+)", cpu_name) > - return int(m.group(1)) > - This is an unnecessary whitespace change. > + cpu_path = glob.glob("/sys/devices/system/node/node%d/cpu*" % node_nr) > + r = re.compile(r"cpu(\d+)") > + cpu_name = filter(None ,map(r.match, map(os.path.basename, cpu_path))) Typo, should be "None, map" rather than "None ,map". Also, perhaps splitting this on multiple lines would benefit readability, like this: cpu_name = filter(None, map(r.match, map(os.path.basename, cpu_path) ) ) No preference though, can be left as is. > + return int(next(iter(cpu_name)).group(1)) IMO too much going on on one line, maybe leave the return as it was and just fix the match? As in, m = next(iter(cpu_name)) return int(m.group(1)) Also probably needs a comment explaining why iter() is there - namely, that return value from a filter is a list in Python 2, but a generator in Python 3, and next() only works with generators. Otherwise, Reviewed-by: Anatoly Burakov > > pool_child = None # per-process child > > -- Thanks, Anatoly