From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1C8384594E; Tue, 10 Sep 2024 04:54:43 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BCD444021F; Tue, 10 Sep 2024 04:54:42 +0200 (CEST) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id 8EC0140151 for ; Tue, 10 Sep 2024 04:54:40 +0200 (CEST) Received: from mail.maildlp.com (unknown [172.19.162.254]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4X2pDX4rCjzyRNY; Tue, 10 Sep 2024 10:53:32 +0800 (CST) Received: from dggpeml500024.china.huawei.com (unknown [7.185.36.10]) by mail.maildlp.com (Postfix) with ESMTPS id CBBB2180100; Tue, 10 Sep 2024 10:54:37 +0800 (CST) Received: from [10.67.121.161] (10.67.121.161) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 10 Sep 2024 10:54:37 +0800 Subject: Re: [PATCH v3 04/26] config: add separate defines for max Rx and Tx queues To: Bruce Richardson , CC: , , References: <20240812132910.162252-1-bruce.richardson@intel.com> <20240814104933.14062-1-bruce.richardson@intel.com> <20240814104933.14062-5-bruce.richardson@intel.com> From: fengchengwen Message-ID: Date: Tue, 10 Sep 2024 10:54:37 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20240814104933.14062-5-bruce.richardson@intel.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.121.161] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpeml500024.china.huawei.com (7.185.36.10) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2024/8/14 18:49, Bruce Richardson wrote: > Rather than having a single define for maximum queues per ethernet port, > we can set the max values for Rx queues and Tx queue independently. This > allows future memory saving for apps which only need large numbers of Rx > queues or only large numbers of Tx queues. > > Signed-off-by: Bruce Richardson > Acked-by: Morten Brørup > --- > config/rte_config.h | 2 ++ > doc/guides/rel_notes/release_24_11.rst | 6 ++++++ > 2 files changed, 8 insertions(+) > > diff --git a/config/rte_config.h b/config/rte_config.h > index d67ff77c71..2c11b4eeec 100644 > --- a/config/rte_config.h > +++ b/config/rte_config.h > @@ -65,6 +65,8 @@ > > /* ether defines */ > #define RTE_MAX_QUEUES_PER_PORT 1024 > +#define RTE_MAX_ETHPORT_RX_QUEUES 1024 > +#define RTE_MAX_ETHPORT_TX_QUEUES 1024 The Rx Queues != Tx Queues is not a mainstream scenario (at least from most of DPDK user as I know), rename it (not separate Rx/Tx) with eth meaning and make it as a compile option is enough. > #define RTE_ETHDEV_QUEUE_STAT_CNTRS 16 /* max 256 */ > #define RTE_ETHDEV_RXTX_CALLBACKS 1 > #define RTE_MAX_MULTI_HOST_CTRLS 4 > diff --git a/doc/guides/rel_notes/release_24_11.rst b/doc/guides/rel_notes/release_24_11.rst > index 0ff70d9057..3725c056ba 100644 > --- a/doc/guides/rel_notes/release_24_11.rst > +++ b/doc/guides/rel_notes/release_24_11.rst > @@ -55,6 +55,12 @@ New Features > Also, make sure to start the actual text at the margin. > ======================================================= > > +* **New configuration settings for Rx and Tx Ethernet Queues.** > + > + New defines have been added to DPDK to allow independent tracking of the maximum number of Rx and Tx queues. > + These defines as ``RTE_MAX_ETHPORT_RX_QUEUES`` and ``RTE_MAX_ETHPORT_TX_QUEUES``, > + and should be used in place of the older macro ``RTE_MAX_QUEUES_PER_PORT``. > + > > Removed Items > ------------- >