From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AFBC145FCD; Fri, 3 Jan 2025 03:51:44 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 76862402BD; Fri, 3 Jan 2025 03:51:44 +0100 (CET) Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2079.outbound.protection.outlook.com [40.107.247.79]) by mails.dpdk.org (Postfix) with ESMTP id 33E8A402B1 for ; Fri, 3 Jan 2025 03:51:43 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=sPSKN8jwpak2zezNV0tpZueqDhwlPUqJ6vLotfjvlx8ioH1HNM5ScGv/z3qKYpKY4seX297xEsQxFpoVOCO/vec7RG/BbRqz0eHink+CQxxbNKSCVWHLt6c5M6hFqijo0nqbQo1WbMCaQZWM1gWwnk19fCSJUTm48pDfsDTUNfXD6wtpEeAUQgX/6j/E0ks7+hwMzol+7W6vk4eORHWk5j02TV/nicpLhWBAWxeDUFuwZqAzEBnau4Ah4IN20PuVJfw6emi0kOFr8dv0uTeQ2i9keZN7fWVl7wPMnRfuMj1pjKXwlbJdCqeswkTGN4QmQDGm2sgi12Gk4VNtUSjY/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=k6kqdaHSiuDFVi8QzuhMU7kxC85LMeRo3ylGhRV49PQ=; b=t2kwlmRegurfgjo0uEF/n/2SkbSOEtCd+zdhvrgft18+sBHZz9gueV7lzNg/FNdDDxO6Cj3mEHEPK4YrKO0nJmjHNgkcknDtz5eVvB2Spp+kgWj6Ti50gzoUZEEulk76Z8Vs1UB3hLcGHPiny6Em+G2FyZD/SV/GvRAxLrw+WnWBH+67rQHUTOGcLtU4atVIH1tp2OkVvn1cFR+6q7WS7U0z2qK31plUa1rQzGjXDqyKfevFuWYPvMeAhSl4/6a28rv1OxfQUoLEcyqUCGE4NCIgM50ImRke9wZiNyc1SqLhO4XhV1rQ4YvFWsgkmcZIlmdFmR9XsFThBvYjDMh4zw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nokia-sbell.com; dmarc=pass action=none header.from=nokia-sbell.com; dkim=pass header.d=nokia-sbell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nokia-sbell.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k6kqdaHSiuDFVi8QzuhMU7kxC85LMeRo3ylGhRV49PQ=; b=WXmvt864q0OwQmgCERO0M007RTaQTPbvPnru+92Zjv1dY6Jp8pSq4w7R+5Gwo+sUSIs1tYLtGuKX5kHvby/pbeDbYCDXgsNGlEwYceYGZo23yVXHpeycIjFFAicQYTJwxbUM5XfY+Y2WjFtVV47ozW7EO+vHQ1UaYve4YgjtJLtWR/AlhnbqtKLzRgzZ4aiNoOv1YGYJMyK+EDOOiFrz7zhnSI2+K7C1tf98jq4s6XE9t8bWuyuCPNwBDPWZrpj5p+KT9hN6zl59tmQvzmFIAK+5wxFVjBihJK28l0iDPLTmeozFwJeN0OSSZV3uncsmAZrEYGai2isf0jhQRbjgog== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nokia-sbell.com; Received: from VI1PR07MB9898.eurprd07.prod.outlook.com (2603:10a6:800:119::6) by VI1PR0701MB6799.eurprd07.prod.outlook.com (2603:10a6:800:190::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8314.14; Fri, 3 Jan 2025 02:51:36 +0000 Received: from VI1PR07MB9898.eurprd07.prod.outlook.com ([fe80::1928:4afb:4eee:1f21]) by VI1PR07MB9898.eurprd07.prod.outlook.com ([fe80::1928:4afb:4eee:1f21%5]) with mapi id 15.20.8314.013; Fri, 3 Jan 2025 02:51:36 +0000 Content-Type: multipart/alternative; boundary="------------glTeU56xfU3WqJ7niQkgZdkO" Message-ID: Date: Fri, 3 Jan 2025 10:51:26 +0800 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] net/mlx5: improve socket file path To: Bruce Richardson , Stephen Hemminger Cc: Dariusz Sosnowski , Viacheslav Ovsiienko , Bing Zhao , Ori Kam , Suanming Mou , Matan Azrad , dev@dpdk.org References: <20241213092444.2987-1-ming.1.yang@nokia-sbell.com> <20241213091239.7934b8b4@hermes.local> Content-Language: en-US From: Yang Ming In-Reply-To: X-ClientProxiedBy: MAXPR01CA0103.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:5d::21) To VI1PR07MB9898.eurprd07.prod.outlook.com (2603:10a6:800:119::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI1PR07MB9898:EE_|VI1PR0701MB6799:EE_ X-MS-Office365-Filtering-Correlation-Id: 6f28dea8-8ab9-4931-2c61-08dd2ba18a3d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024|8096899003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?R1V1elltVm94YmpzbG5HMHBEMlZJWGMrb3BadXF3d2UwYkhVZXo0MXVsc3d3?= =?utf-8?B?RmF4VVFIM2R0ZUQ2cVBxL3pFOS80by8vRitSWHE3bmo3Um9CTjhNMktlaGg4?= =?utf-8?B?OW83T3RrSU1HSFhDTm83RjdhK1lTWk5IdldkK0d6Y1NiSWlpZERHanVSdmhw?= =?utf-8?B?N25UdTMwanFIcC8rMzFBSkg4a2lEbW9nZ0FtbEV1SHBoUjFlRXVrZWZ0VzY1?= =?utf-8?B?MHArL0M3R0E1VWxlbEVDOTAxWkVybzNlRGMrWnZVTGZQZ2FwbGlENG1LTW5u?= =?utf-8?B?bnJOdVhJTkNsVTY1cDI1YlVlaWJKU2ZJRWxVZHN4MmNaTVFacjh1SVlCQkVB?= =?utf-8?B?Ry8rME5mY3NteTFJQnpJTjdya2xRR1N1ZDZxbi8zZlRodThjL2VuV2toK1I0?= =?utf-8?B?TlNkZG5KNUZHcVI2dzh1ZE1NSlVmcEFmaXEvbnkvZWlIeHE1a0UxYk1qOHg2?= =?utf-8?B?M1lWOUhZQ1gxelZsQzVCWG5LeFJBdEMxclE1U2xEZlpLSUZNQWdHd0dzcW9H?= =?utf-8?B?cHpPM3diSE15YUw2S1pSZ0owMVg1QlpKUC95bTdPTUhVRmwzYjZaOUFFa2pj?= =?utf-8?B?cngybUVXVjFMbjVVbEQwLzFQam1Xcys5ZWZvOUpvbTlZZGtSZUJnUzhPM2Vp?= =?utf-8?B?SlFlZC9qWElZblVIZzRvVGtGWjNZNHpJdVhRdnBNQW9EZHRQL1F0ZElzdytH?= =?utf-8?B?S0xLcEpsTzJrNnFxbWJHK0ZyeEVLMU1MQ0tiN281TEVlYk5MaUhoSXlaUUty?= =?utf-8?B?Qnd4eUNpU1NGNHh4NmhLTFdQR0NtU1I5b3U5MG14SnJub3h2RWkxOWlsYjNE?= =?utf-8?B?T3pGUyt4TlRTZkFtVmNrTitVcFYyblpyMnFWOGw0TWJvT2s0YjZLRGozaitl?= =?utf-8?B?d2VtOGxNcXA4TzZId3lISDNvZnV6eDVmM1N2K1BwMy9PNW1VRkkxbUxETGtX?= =?utf-8?B?N2pEbDFmSjdENklnanVvS3R5QnJSdnQyek9Kck9ZOFlkSXF6T1FMS3orczc1?= =?utf-8?B?cnBnQlFKTGx1VEZpUmRtNGNFY3oveFlXMFY5SjZTMUljOUM3eEhTY0JzZ3Jo?= =?utf-8?B?M0lWbVBnRjdHSUVQNm5QQys0TmRUWkIyenpxQnA5U0lhMmV3RmlTWDVSV0s5?= =?utf-8?B?dGtpUitVbXE5WTRTWUhFK1h1ampRV01iejdIUlFYcGtialdsY1JFSnMrUnMy?= =?utf-8?B?SzBQZjZMZW5zUVY3UndwL3RzL0l0L3lrcHhGankrakxHM3VjZis2eVVqcjJ5?= =?utf-8?B?M0NiNVZUZFNJU2NHeVlvVi9zd1RraHJNQjZDU3ZVVmJ5aGVPZ1JnL0JBaTZ4?= =?utf-8?B?RXljN3RVRVpNTTRoN2QrdThRaGtMaUswc1JCRC9UakRyNHk3SmFTSG13aEg1?= =?utf-8?B?b0l1ZGpyZXhSb0V2TktkY0UrWGlBSm11MEUycTBhUStLSXBRb09qMHQwOUVS?= =?utf-8?B?dzNLZUdEY2thVUtOQ01FVG85MVd5YW01ejNOSnVXUVJuQlBmb2xhQjNZRXRr?= =?utf-8?B?YnBmLzNQcnlvTEFvdFcvWTNMSDJnVUZjZ0l4blVtWEhJcTlrN1dMcVNLcFZt?= =?utf-8?B?dmNQZlBpcW05czZhVDBjWU9mbVNPdU9TNE1xYW05d3N0czZhbUYwYlg2NUJH?= =?utf-8?B?ZDU4eHV1UjFHcGg2U3pLSE5GcloraHl5dFpIS1h2YTBYSk9HL05jRHpRMVRY?= =?utf-8?B?czhOSlMzUXNmdS9IMzBKWGhzMXpwN0hZdDhVL3BWR0Z2QkFQZlYrczN1Rk5r?= =?utf-8?B?TG9PcEg5U1lIN2xLeWZsdUlCcnNHalhUQmNERTEyallpNWxUdlc5UG02YjNG?= =?utf-8?B?dWY5emVKSllBUTkzRUoyazVLWVBHckIrcjVFRW1STnA1ZkJlZHZiWS9CV3M0?= =?utf-8?Q?LY4/1eeuWfkxC?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR07MB9898.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024)(8096899003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U0dtTXdPZk1ldlhQZ3U0anJRN2FYNjNxQlcrZVdjRkcxWU83R2xjL1o0Rlo4?= =?utf-8?B?dmZHOWhRbjVZakxub0NxUnM4b0xGbHYrZ1ErbE95QVUwZnlLdzRNK1ZOdDcw?= =?utf-8?B?ZUhULzFjK09rWnZXOFkyNjJlZEZZNDBDckpjWGxhNjVPcEpudlVMYXVFd0U0?= =?utf-8?B?bHFyRURENjVXYXNpUU13ZFJtSjNHZ2hpcUxKZy9hSjlKWXhPYStOQXRid1pk?= =?utf-8?B?aWdVODVuNFhmamxpcXdDUWZMUXlGNHg0MG9wV0xOZ2dRR1NvNnhaM0Njd3E4?= =?utf-8?B?TWtZYUs1NmUxcmU0T1UxeERYZFh0OFNjeFUzeUwwS0pSRkNGU21EenVHTGdp?= =?utf-8?B?TnRnRm0zVFEwdHovRkd3ZkNYd2tyOTRLV1JjSUMreGszN3JaWjFIWnB3RlA3?= =?utf-8?B?QkNzeVNFWTdVRzg0aThZdXEwUnBybGZRRTZwMm5UaDJxcEJNUjdUWlN1YmZq?= =?utf-8?B?SWtoUVQveU5yMWJvSHFSYWdoN1VPOGxMOTNnN2Y0NndTQzlxeXhwQTYyYkZK?= =?utf-8?B?S04wMS9rSDRhZXNlVUN4R2o4bGY3L0NReHJpbDJPWUNtT1RWa0UydHd5N1Mx?= =?utf-8?B?cUl0bDNDRHJmdktPaEJrTlRyL3d0NGVJYTdOTHFKVmZ6aFd0VHBSZllleGc4?= =?utf-8?B?RmFBWEZaMTNULytleGtkZ0ZBRjd1ZTZRU0gvTUVnWWJSMzZUUmRMZ0I3NzRM?= =?utf-8?B?MlZ0SERqaHJhWVF4U3VLeE5uN2xhakpsTjQ2UFEvNUpGWVUwd3hmTThMTnZs?= =?utf-8?B?Tk5yRHBEWUVUMkdhMzMzMmtjWFRCQ1lkLzlJWnhqSEhodzdjZDNpNFBjQ3FU?= =?utf-8?B?UDdEWkl3WS80NWVQUmJ6bERHUXcvR0RKQUJRSlhVdDNCVWN3TTVnWjZZRmpr?= =?utf-8?B?ZU5pYjFkeEFHOFhiangxdUdJeit0TzY5QlAyYlBISXNReW1xcFZodm1ySTF5?= =?utf-8?B?NVZIMGdjcy9UWmlNZ3A5VHowS3E4bTVwNmJXdC9aR1dQWWlOb2tTa0VDTjJq?= =?utf-8?B?YnZyL3NxOE1XbTFKYXlzMnllc05ESU5aVENPS3VtQWxobDNlUXNNcGFHVmcz?= =?utf-8?B?Z2lVcjIrV1B6ZHhPQlJVejUvd2ZsS1R1cWRldzJKYnRCOTd2ZDUwbzQ3a0or?= =?utf-8?B?VEJhSEhKT1N4SUJlVVNEYklJRDQ5Nm1sWCtJeTJ2NDVKUnd5bEU0Q282VzBi?= =?utf-8?B?MzlsNE5sV0ZURkhmZFg0N2hjYkNHY1VCNllkWVgwQjNhT1d6VHNwUVRiSW02?= =?utf-8?B?cjA4LzZ4RVdaelgrWUkwTHpIZXZZc1d1QXNsQnpKY2g3T0thZmg2bnBrL3dp?= =?utf-8?B?dHp4eFdPT09LWTlKRDJKbmR6ZGtQb1J1cU5hNkUrU0hKTzFsSXIrRWNhKzhJ?= =?utf-8?B?T093ek1LMit2eFJQSDFJRmFET05kWlRGcDNoNjJLVEtjV3BpOTdZNDVlWm16?= =?utf-8?B?SUVQQVlNMmxLelVkaFI2Wk9DM1V5V0FHbXlobFNsNmhNZlZ2ZWxKck5KTjkx?= =?utf-8?B?OGN6NWg0MnF6OVRDckVXTGtxRXlFWXY5ZllJeUEzbTlINWwzT1k1enBLUExV?= =?utf-8?B?QlhORWhjbFFSN2t3Y3grZFZGTWxxUDUzb2ZHVFAyTU1MbkpXVkI0Z2Qrc2pv?= =?utf-8?B?aTBXbVQ5czNlMzd3TVd1V2EzdW1aSVpQbGdTUjJkY3NNckJ6V3kzenJJSXRv?= =?utf-8?B?cklseHpQQi9acGhtZjJ6VWZzTUV4bXZVb2pUZEg3cUZCa0dYWXd5Y2kzU0FE?= =?utf-8?B?K1ZxK2lYK3V0NWZMQjQ3TkQyMmplUVh0ek9HanlGRGF3QlFmUWtFY0JPUkNH?= =?utf-8?B?a09sYklnbWxCYnZmK0R2NENRNnVYaENMalp6VXhXMUlEUllPOFBOSG5lVXRJ?= =?utf-8?B?aTlUR0JUVUxKdkZ6OHZjTEJRZy9RVzJiU3RqUmVNczArYWxDdkVVNW5yOUVl?= =?utf-8?B?SHRmWDhubzJyb2pDNHZUTjlmdEdBSDVVanFJbk1xYWhCVHVUT1A2NEJ1a3Fv?= =?utf-8?B?ZUl2NmhZRndYNDR4dXE4WjczbjVkc0NWQlIvd1lrNWZMTjNTbS93aU1RSC9z?= =?utf-8?B?RHMxV1lTeG1UMUhhZEhCalcvMHdncWRQQ0w2TTZzNVI4dmozYUR1M3ZJcDFE?= =?utf-8?B?TTJkU0tVZUhiQTJzSmZHaGk5cWpDRm4yTUZpQlRXa3ZVdmFiZHYxSVE1M3FW?= =?utf-8?B?MGc9PQ==?= X-OriginatorOrg: nokia-sbell.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6f28dea8-8ab9-4931-2c61-08dd2ba18a3d X-MS-Exchange-CrossTenant-AuthSource: VI1PR07MB9898.eurprd07.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2025 02:51:36.6534 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5d471751-9675-428d-917b-70f44f9630b0 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: K5842U8Vijm2zZ3WVt3+W5hY3poCxSTFC/UgrkCW7ZPrAxq1UBVjobEKx6rTW3BJIIRECTbTWafRGZwvXcGn157NPLiBO5fVKDQh0L6Wy0U= X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0701MB6799 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --------------glTeU56xfU3WqJ7niQkgZdkO Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2024/12/14 01:16, Bruce Richardson wrote: > On Fri, Dec 13, 2024 at 09:12:39AM -0800, Stephen Hemminger wrote: >> On Fri, 13 Dec 2024 17:24:42 +0800 >> Yang Ming wrote: >> >>> 1. /var/tmp is hard code which is not a good style >>> 2. /var/tmp may be not allowed to be written via container's >>> read only mode. >>> >>> Signed-off-by: Yang Ming >> Since this is a unix domain socket, why not use abstract socket >> that doesn't have to be associated with filesystem? > In general, I think we should avoid abstract sockets in DPDK. Primary > reason is that they are linux-specific. Last time I checked other unixes, > like BSD, don't support them. A secondary concern is that having a > filesystem path allows permission checks, so for e.g. telemetry sockets, > only users with appropriate permissions can connect. With an abstract socket > we'd have to open up the area of user authentication. > > /Bruce > Hi Stephen & Bruce, I'm not sure whether abstract socket is a good idea. Maybe it can be improved further or step by step. But we don't need to discuss it for this commit. We do this improvement because "/var/tmp" and "/var/log" can't be write in Readonly mode of container except that we add /var/ specfic for DPDK application in container's setting. But nearly all DPDK modules have already used common runtime path returned from `rte_eal_get_runtime_dir()`. Why not we apply this common path for Mellanox NIC? --------------glTeU56xfU3WqJ7niQkgZdkO Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit


On 2024/12/14 01:16, Bruce Richardson wrote: 
On Fri, Dec 13, 2024 at 09:12:39AM -0800, Stephen Hemminger wrote:

On Fri, 13 Dec 2024 17:24:42 +0800
Yang Ming <ming.1.yang@nokia-sbell.com> wrote:


1. /var/tmp is hard code which is not a good style
2. /var/tmp may be not allowed to be written via container's
read only mode.

Signed-off-by: Yang Ming <ming.1.yang@nokia-sbell.com>

Since this is a unix domain socket, why not use abstract socket
that doesn't have to be associated with filesystem?

In general, I think we should avoid abstract sockets in DPDK. Primary
reason is that they are linux-specific. Last time I checked other unixes,
like BSD, don't support them. A secondary concern is that having a
filesystem path allows permission checks, so for e.g. telemetry sockets,
only users with appropriate permissions can connect. With an abstract socket
we'd have to open up the area of user authentication.

/Bruce

Hi Stephen & Bruce,

I'm not sure whether abstract socket is a good idea. Maybe it can be improved further or step by step. But we don't need to discuss it for this commit. 
We do this improvement because "/var/tmp" and "/var/log" can't be write in Readonly mode of container except that we add /var/ specfic for DPDK application in container's setting. But nearly all DPDK modules have already used common runtime path returned from `rte_eal_get_runtime_dir()`. Why not we apply this common path for Mellanox NIC?


--------------glTeU56xfU3WqJ7niQkgZdkO--