From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 99047A0547; Thu, 29 Apr 2021 11:16:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8526541125; Thu, 29 Apr 2021 11:16:29 +0200 (CEST) Received: from mailgw02.pantheon.sk (mailgw01.pantheon.sk [46.229.239.26]) by mails.dpdk.org (Postfix) with ESMTP id 973D44067E for ; Thu, 29 Apr 2021 11:16:28 +0200 (CEST) Received: from mailgw02.pantheon.sk (localhost.localdomain [127.0.0.1]) by mailgw02.pantheon.sk (Proxmox) with ESMTP id 563A5185416; Thu, 29 Apr 2021 11:16:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; h=cc:cc:content-transfer-encoding:content-type:content-type :date:from:from:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=dkim; bh=e80VB/1l4fsTBImEUCyq pBxk8EAEVUGnfMZ/qxUFx8g=; b=YQh32pAQRWOIE4oZLCKPDtih0cdfCv7Jy4xD fCeG1+DybPpZK9Wnxg1p2gzzG2bcX3BVeoWR7Jglm1KwMke+2Q7Foi3SaOpUvXE/ 3qqmZGmXsiqUltRHkF8v2ep0WNk8N8WVnU511/G8H45ZHrLQMXl9ruxOlQOxquAk /2ezbeumoJhaEBTf7QGdpm7Pm2mFL+KS2Jz3EkAXWeNuo3ws11FY0VjDlEmIlFZd KmFqOOz5NvWPBPpfF2ORPZoQQaA60hEaNdpaKOY8a0IVIOo9S5Bg0b9JUS+L+0vc nFmEpoHc6fzmpwadxmM8cFDEMCxjRbb1gYITcYljWlGZ/8+tqA== From: =?iso-8859-2?Q?Juraj_Linke=B9?= To: Thierry Herbelot , "dev@dpdk.org" CC: Thomas Monjalon , Honnappa Nagarahalli , Ruifeng Wang Thread-Topic: [PATCH-V2] config/arm: restore support for Qualcomm servers Thread-Index: AQHXPM6hl004rMF5IUqX5nF5P3/UUKrLNi3w Date: Thu, 29 Apr 2021 09:16:26 +0000 Message-ID: References: <20210428160807.17191-1-thierry.herbelot@6wind.com> <20210429080644.11423-1-thierry.herbelot@6wind.com> In-Reply-To: <20210429080644.11423-1-thierry.herbelot@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.101.4.10] Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH-V2] config/arm: restore support for Qualcomm servers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thierry Herbelot > Sent: Thursday, April 29, 2021 10:07 AM > To: dev@dpdk.org > Cc: Thierry Herbelot ; Thomas Monjalon > ; Juraj Linke=B9 ; Honna= ppa > Nagarahalli ; Ruifeng Wang > > Subject: [PATCH-V2] config/arm: restore support for Qualcomm servers >=20 > From the documentation: > "The SoC configuration is a combination of implementer and CPU part numbe= r > configuration and SoC-specific configuration." >=20 > Align Qualcomm SoC configuration with the configuration of other server S= oCs > (eMAG, Kunpeng 9x0): add a soc configuration to the existing implementer > configuration. >=20 > Fixes: f2340c858046 ("config/arm: add platform config option") >=20 Since this is just adding new soc configuration, I don't think it's actuall= y fixing anything. > Signed-off-by: Thierry Herbelot > -- > V2: > - use the right original commit in Fixes > --- > config/arm/meson.build | 8 ++++++++ > 1 file changed, 8 insertions(+) >=20 > diff --git a/config/arm/meson.build b/config/arm/meson.build index > 22cd81319c06..4518b7e877b3 100644 > --- a/config/arm/meson.build > +++ b/config/arm/meson.build > @@ -298,6 +298,13 @@ soc_octeontx2 =3D { > 'numa': false > } >=20 > +soc_qualcomm =3D { > + 'description': 'Qualcomm Centriq 2400', > + 'implementer': '0x51', > + 'part_number': '0xc00', > + 'numa': false > +} > + > soc_stingray =3D { > 'description': 'Broadcom Stingray', > 'implementer': '0x41', > @@ -334,6 +341,7 @@ socs =3D { > 'n1sdp': soc_n1sdp, > 'n2': soc_n2, > 'octeontx2': soc_octeontx2, > + 'qualcomm': soc_qualcomm, Now that I'm looking at this change, I see that you've added the qualcomm s= oc here and it's not added to the docs in this patch, but rather the patch = which fixes the docs. I think you should move the qualcomm doc addition to = this patch (and the other patch would just have the fixes). > 'stingray': soc_stingray, > 'thunderx2': soc_thunderx2, > 'thunderxt88': soc_thunderxt88 > -- > 2.29.2 >=20