From: Anatoly Burakov <anatoly.burakov@intel.com>
To: dev@dpdk.org, Tyler Retzlaff <roretzla@linux.microsoft.com>
Subject: [PATCH v1 2/4] lcore: rename socket ID to NUMA ID
Date: Tue, 26 Nov 2024 13:14:48 +0000 [thread overview]
Message-ID: <c94dbc97f5239de755a980cfb6b406cd9fdcf871.1732626792.git.anatoly.burakov@intel.com> (raw)
In-Reply-To: <cover.1732626792.git.anatoly.burakov@intel.com>
Rename socket ID to NUMA ID in internal lcore structure. This does not
change any user facing API's, although it does alter a couple of log
messages.
In particular, telemetry API and lcore dump API changes have been omitted
as there may be consumers of these API that depend on specifics of messages
generated by these API's.
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
lib/eal/common/eal_common_lcore.c | 10 +++++-----
lib/eal/common/eal_common_thread.c | 12 ++++++------
lib/eal/common/eal_private.h | 2 +-
3 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/lib/eal/common/eal_common_lcore.c b/lib/eal/common/eal_common_lcore.c
index 2ff9252c52..ba8fce6607 100644
--- a/lib/eal/common/eal_common_lcore.c
+++ b/lib/eal/common/eal_common_lcore.c
@@ -115,7 +115,7 @@ unsigned int rte_get_next_lcore(unsigned int i, int skip_main, int wrap)
unsigned int
rte_lcore_to_socket_id(unsigned int lcore_id)
{
- return lcore_config[lcore_id].socket_id;
+ return lcore_config[lcore_id].numa_id;
}
static int
@@ -173,17 +173,17 @@ rte_eal_cpu_init(void)
config->lcore_role[lcore_id] = ROLE_RTE;
lcore_config[lcore_id].core_role = ROLE_RTE;
lcore_config[lcore_id].core_id = eal_cpu_core_id(lcore_id);
- lcore_config[lcore_id].socket_id = socket_id;
+ lcore_config[lcore_id].numa_id = socket_id;
EAL_LOG(DEBUG, "Detected lcore %u as "
- "core %u on socket %u",
+ "core %u on NUMA node %u",
lcore_id, lcore_config[lcore_id].core_id,
- lcore_config[lcore_id].socket_id);
+ lcore_config[lcore_id].numa_id);
count++;
}
for (; lcore_id < CPU_SETSIZE; lcore_id++) {
if (eal_cpu_detected(lcore_id) == 0)
continue;
- EAL_LOG(DEBUG, "Skipped lcore %u as core %u on socket %u",
+ EAL_LOG(DEBUG, "Skipped lcore %u as core %u on NUMA node %u",
lcore_id, eal_cpu_core_id(lcore_id),
eal_cpu_socket_id(lcore_id));
}
diff --git a/lib/eal/common/eal_common_thread.c b/lib/eal/common/eal_common_thread.c
index a53bc639ae..aa98bdc3ff 100644
--- a/lib/eal/common/eal_common_thread.c
+++ b/lib/eal/common/eal_common_thread.c
@@ -24,13 +24,13 @@
RTE_DEFINE_PER_LCORE(unsigned int, _lcore_id) = LCORE_ID_ANY;
RTE_DEFINE_PER_LCORE(int, _thread_id) = -1;
-static RTE_DEFINE_PER_LCORE(unsigned int, _socket_id) =
+static RTE_DEFINE_PER_LCORE(unsigned int, _numa_id) =
(unsigned int)SOCKET_ID_ANY;
static RTE_DEFINE_PER_LCORE(rte_cpuset_t, _cpuset);
unsigned rte_socket_id(void)
{
- return RTE_PER_LCORE(_socket_id);
+ return RTE_PER_LCORE(_numa_id);
}
static int
@@ -66,8 +66,8 @@ thread_update_affinity(rte_cpuset_t *cpusetp)
{
unsigned int lcore_id = rte_lcore_id();
- /* store socket_id in TLS for quick access */
- RTE_PER_LCORE(_socket_id) =
+ /* store numa_id in TLS for quick access */
+ RTE_PER_LCORE(_numa_id) =
eal_cpuset_socket_id(cpusetp);
/* store cpuset in TLS for quick access */
@@ -76,7 +76,7 @@ thread_update_affinity(rte_cpuset_t *cpusetp)
if (lcore_id != (unsigned)LCORE_ID_ANY) {
/* EAL thread will update lcore_config */
- lcore_config[lcore_id].socket_id = RTE_PER_LCORE(_socket_id);
+ lcore_config[lcore_id].numa_id = RTE_PER_LCORE(_numa_id);
memmove(&lcore_config[lcore_id].cpuset, cpusetp,
sizeof(rte_cpuset_t));
}
@@ -256,7 +256,7 @@ static int control_thread_init(void *arg)
/* Set control thread socket ID to SOCKET_ID_ANY
* as control threads may be scheduled on any NUMA node.
*/
- RTE_PER_LCORE(_socket_id) = SOCKET_ID_ANY;
+ RTE_PER_LCORE(_numa_id) = SOCKET_ID_ANY;
params->ret = rte_thread_set_affinity_by_id(rte_thread_self(), cpuset);
if (params->ret != 0) {
rte_atomic_store_explicit(¶ms->status,
diff --git a/lib/eal/common/eal_private.h b/lib/eal/common/eal_private.h
index bb315dab04..22531a2b19 100644
--- a/lib/eal/common/eal_private.h
+++ b/lib/eal/common/eal_private.h
@@ -30,7 +30,7 @@ struct lcore_config {
volatile int ret; /**< return value of function */
volatile RTE_ATOMIC(enum rte_lcore_state_t) state; /**< lcore state */
- unsigned int socket_id; /**< physical socket id for this lcore */
+ unsigned int numa_id; /**< NUMA node ID for this lcore */
unsigned int core_id; /**< core number on socket for this lcore */
int core_index; /**< relative index, starting from 0 */
uint8_t core_role; /**< role of core eg: OFF, RTE, SERVICE */
--
2.43.5
next prev parent reply other threads:[~2024-11-26 13:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-26 13:14 [PATCH v1 0/4] Adjust wording for NUMA vs. socket ID in DPDK Anatoly Burakov
2024-11-26 13:14 ` [PATCH v1 1/4] eal: update socket ID API documentation Anatoly Burakov
2024-11-26 13:14 ` Anatoly Burakov [this message]
2024-11-26 13:14 ` [PATCH v1 3/4] eal: rename socket ID to NUMA ID in internal config Anatoly Burakov
2024-11-26 13:14 ` [PATCH v1 4/4] eal: rename --socket-mem/--socket-limit Anatoly Burakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c94dbc97f5239de755a980cfb6b406cd9fdcf871.1732626792.git.anatoly.burakov@intel.com \
--to=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=roretzla@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).