Re: [PATCH v2] net/mvneta: fix possible out-of-bounds write

[fengchengwen <fengchengwen@huawei.com>]

On 2024/10/10 2:00, Stephen Hemminger wrote:
> On Wed, 9 Oct 2024 06:08:45 +0000
> Chengwen Feng <fengchengwen@huawei.com> wrote:
> 
>> The mvneta_ifnames_get() function will save 'iface' value to ifnames,
>> it will out-of-bounds write if passed many iface pairs (e.g.
>> 'iface=xxx,iface=xxx,...').
>>
>> Fixes: 4ccc8d770d3b ("net/mvneta: add PMD skeleton")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
>> Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>
>>
>> ---
>> v2: add error log which address Stephen's comment.
>>
>> ---
>>  drivers/net/mvneta/mvneta_ethdev.c | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/net/mvneta/mvneta_ethdev.c b/drivers/net/mvneta/mvneta_ethdev.c
>> index 3841c1ebe9..e641f19266 100644
>> --- a/drivers/net/mvneta/mvneta_ethdev.c
>> +++ b/drivers/net/mvneta/mvneta_ethdev.c
>> @@ -91,6 +91,11 @@ mvneta_ifnames_get(const char *key __rte_unused, const char *value,
>>  {
>>  	struct mvneta_ifnames *ifnames = extra_args;
>>  
>> +	if (ifnames->idx >= NETA_NUM_ETH_PPIO) {
>> +		MVNETA_LOG(ERROR, "Detect too many ifnames!");
>> +		return -EINVAL;
>> +	}
>> +
> 
> Compile fails due to typo. Need to use "ERR," not "ERROR,"

Thanks, already fix in v3

It seemed this driver depend on libmusdk, and unfortunately, I don't have this library locally.