Re: [dpdk-dev] [PATCH v2] eal: fix to set the rte_device ptr's device args before hotplug

[Gaetan Rivet <grive@u256.net>]

On 14/02/2020 07:43, Somnath Kotur wrote:
> As per the comments in this code section, since there is a matching device,
> it is now its responsibility to manage the devargs we've just inserted.
> But the matching device ptr's devargs is still uninitialized or not pointing
> to the newest dev_args that were passed as a parameter to local_dev_probe().
> This is needed particularly in the case when *probe is called again* on an
> already probed device as part of adding a representor port to an OVS switch(OVS-DPDK)
> 
> Fixes: 7e8b26650146 ("eal: fix hotplug add / remove")
> Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com>
> ---
> v1->v2: Incorporated suggestions from Gaetan Rivet
>   drivers/bus/pci/linux/pci.c | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/bus/pci/linux/pci.c b/drivers/bus/pci/linux/pci.c
> index 740a2cd..71b0a30 100644
> --- a/drivers/bus/pci/linux/pci.c
> +++ b/drivers/bus/pci/linux/pci.c
> @@ -377,6 +377,11 @@
>   						 */
>   						RTE_LOG(ERR, EAL, "Unexpected device scan at %s!\n",
>   							filename);
> +					else if (dev2->device.devargs !=
> +						 dev->device.devargs) {
> +						rte_devargs_remove(dev2->device.devargs);
> +						pci_name_set(dev2);
> +					}
>   				}
>   				free(dev);
>   			}
> 

Hi Somnath,

I see that this is already pretty similar in BSD (minus the rte_devargs_remove()),
so if you have tested and validated that this works properly I'm fine with this patch.

This might miss a Cc: stable@dpdk.org, otherwise,

Acked-by: Gaetan Rivet <grive@u256.net>