Re: [dpdk-dev] [PATCH v3 00/22] add hns3 ethernet PMD driver

["Wei Hu (Xavier)" <xavier.huwei@huawei.com>]

Hi, Ferruh Yigit


On 2019/10/11 1:10, Ferruh Yigit wrote:
> On 9/27/2019 7:30 PM, Ferruh Yigit wrote:
>> On 9/26/2019 3:01 PM, Wei Hu (Xavier) wrote:
>>> The Hisilicon Network Subsystem is a long term evolution IP which is
>>> supposed to be used in Hisilicon ICT SoCs such as Kunpeng 920.
>>>
>>> This series add DPDK rte_ethdev poll mode driver for Hisilicon
>>> Network Subsystem 3(hns3) network engine.
>>>
>>> v2 -> v3:
>>> 	1. Resolve the conflict problem when performing git operation
>>> 	   based on the current repository. The conflict occurs in
>>> 	   doc/guides/rel_notes/release_19_11.rst.
>>>
>>> v1 -> v2:
>>> 	1. Address some comments from Jerin Jacob Kollanukkaran,
>>> 	   Stephen Hemminger and Ferruh Yigit.
>>>
>>> Wei Hu (Xavier) (22):
>>>   net/hns3: add build and doc infrastructure
>>>   net/hns3: add hardware registers definition
>>>   net/hns3: add some definitions for data structure and macro
>>>   net/hns3: register hns3 PMD driver and add the log interface
>>>     definition
>>>   net/hns3: add support for cmd of hns3 PMD driver
>>>   net/hns3: add the initialization of hns3 PMD driver
>>>   net/hns3: add support for MAC address related operations
>>>   net/hns3: add support for some misc operations
>>>   net/hns3: add support for link_update operation
>>>   net/hns3: add support for flow directory of hns3 PMD driver
>>>   net/hns3: add support for RSS of hns3 PMD driver
>>>   net/hns3: add support for flow control of hns3 PMD driver
>>>   net/hns3: add support for vlan of hns3 PMD driver
>>>   net/hns3: add support for mailbox of hns3 PMD driver
>>>   net/hns3: add support for hns3 VF PMD driver
>>>   net/hns3: add RX/TX package burst and queue related operation
>>>   net/hns3: add start stop configure promiscuous ops
>>>   net/hns3: add dump register ops for hns3 PMD driver
>>>   net/hns3: add abnormal interrupt process for hns3 PMD driver
>>>   net/hns3: add stats related ops for hns3 PMD driver
>>>   net/hns3: add reset related process for hns3 PMD driver
>>>   net/hns3: add multiple process support for hns3 PMD driver
>> For series,
>> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> Series applied to dpdk-next-net/master, thanks.
>>
>> Please send a web patch to document new device as supported:
>> http://core.dpdk.org/supported/
>> https://git.dpdk.org/tools/dpdk-web/
>> (btw, 'hinic' is also missing there, can you please reach out correct people there)
>>
>>
>> (I did minor update for 32-bits build, please verify, more details on the patch)
>>
> Hi Xavier,
>
> Driver is giving some warnings while compiling the documentation [1], that is
> because some deprecated features has been removed from the feature list [2], can
> you please check it?
>
>
>
> [1]
> Warning generate_overview_table(): Unknown feature 'Flow director' in 'hns3.ini'
> Warning generate_overview_table(): Unknown feature 'Flow director' in 'hns3_vf.ini'
>
> [2]
> Commit 030febb6642c ("doc: remove deprecated ethdev features")
> https://patches.dpdk.org/patch/57282/
>
> .
  I will send a patch to delete 'Flow director' feature in hns3.ini and
hns3_vf.ini.
  Thanks for your comment.

  Regards
Xaiver