From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 082C41396 for ; Thu, 16 Mar 2017 15:53:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1489676008; x=1521212008; h=subject:to:references:cc:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=uc3yaSpsIimtx9hrdz7vKkrlPKx1/8fDl08Q/D1wJSU=; b=AFXOJxzCrit5oC1tNNj53CRUoJTX1g9inO4Ei7eXreZ23x2EWSvfEVOM wAtykHPcI6az4j5YM1y7civNxOEzZg==; Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Mar 2017 07:53:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,172,1486454400"; d="scan'208";a="77803250" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.122]) ([10.237.220.122]) by fmsmga006.fm.intel.com with ESMTP; 16 Mar 2017 07:52:59 -0700 To: Allain Legacy References: <1488414008-162839-1-git-send-email-allain.legacy@windriver.com> <1489432593-32390-1-git-send-email-allain.legacy@windriver.com> <1489432593-32390-5-git-send-email-allain.legacy@windriver.com> Cc: dev@dpdk.org, ian.jolliffe@windriver.com, bruce.richardson@intel.com, john.mcnamara@intel.com, keith.wiles@intel.com, thomas.monjalon@6wind.com, vincent.jardin@6wind.com, jerin.jacob@caviumnetworks.com, stephen@networkplumber.org, 3chas3@gmail.com From: Ferruh Yigit Message-ID: Date: Thu, 16 Mar 2017 14:52:58 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1489432593-32390-5-git-send-email-allain.legacy@windriver.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v4 04/17] net/avp: add PMD version map file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Mar 2017 14:53:28 -0000 On 3/13/2017 7:16 PM, Allain Legacy wrote: > Adds a default ABI version file for the AVP PMD. > > Signed-off-by: Allain Legacy > Signed-off-by: Matt Peters > --- > drivers/net/avp/rte_pmd_avp_version.map | 4 ++++ > 1 file changed, 4 insertions(+) > create mode 100644 drivers/net/avp/rte_pmd_avp_version.map > > diff --git a/drivers/net/avp/rte_pmd_avp_version.map b/drivers/net/avp/rte_pmd_avp_version.map > new file mode 100644 > index 0000000..af8f3f4 > --- /dev/null > +++ b/drivers/net/avp/rte_pmd_avp_version.map > @@ -0,0 +1,4 @@ > +DPDK_17.05 { > + > + local: *; > +}; > Hi Allain, Instead of adding files per patch, may I suggest different ordering: First add skeleton files in a patch, later add functional pieces one by one, like: Merge patch 1/17, 3/17, this patch (4/17), 6/17 (removing SYMLINK), into single patch and make it AVP first patch. This will be skeleton patch. Second patch can be introducing public headers (2/17) and updating Makefile to include them. Third, debug log patch (5/17) Patch 7/17 and later can stay same. What do you think?