From: Andrew Rybchenko <arybchenko@solarflare.com>
To: Tiwei Bie <tiwei.bie@intel.com>
Cc: Maxime Coquelin <maxime.coquelin@redhat.com>,
Zhihong Wang <zhihong.wang@intel.com>, <dev@dpdk.org>,
Dilshod Urazov <Dilshod.Urazov@oktetlabs.ru>, <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 3/3] net/virtio: reject unsupported Rx multi queue modes
Date: Wed, 9 Oct 2019 11:04:38 +0300 [thread overview]
Message-ID: <c9e81a56-337e-7116-fc8c-de00635b6181@solarflare.com> (raw)
In-Reply-To: <20191008054650.GA22478@___>
On 10/8/19 8:46 AM, Tiwei Bie wrote:
> On Tue, Oct 01, 2019 at 04:44:31PM +0100, Andrew Rybchenko wrote:
>> From: Dilshod Urazov <Dilshod.Urazov@oktetlabs.ru>
>>
>> This driver supports none of DCB, RSS or VMDQ modes,
>> therefore must check and return error if configured incorrectly.
>>
>> Fixes: c1f86306a026 ("virtio: add new driver")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Dilshod Urazov <Dilshod.Urazov@oktetlabs.ru>
>> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
>> ---
>> drivers/net/virtio/virtio_ethdev.c | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
>> index 7261109dd..0af4fc392 100644
>> --- a/drivers/net/virtio/virtio_ethdev.c
>> +++ b/drivers/net/virtio/virtio_ethdev.c
>> @@ -2071,6 +2071,13 @@ virtio_dev_configure(struct rte_eth_dev *dev)
>> PMD_INIT_LOG(DEBUG, "configure");
>> req_features = VIRTIO_PMD_DEFAULT_GUEST_FEATURES;
>>
>> + if (rxmode->mq_mode != ETH_MQ_RX_NONE) {
>> + PMD_DRV_LOG(ERR,
>> + "Unsupported Rx multi queue mode %d",
>> + rxmode->mq_mode);
>> + return -EINVAL;
>> + }
> We need similar checks for Tx as well.
OK, I'll add.
However, I'm not 100% sure about RSS. Yes, I know that virtio has
no RSS configuration support, but it looks possible to have multi queue
in vhost-net case.
next prev parent reply other threads:[~2019-10-09 8:04 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 15:44 [dpdk-dev] [PATCH 1/3] net/virtio: reject deferred start Rx queue setup Andrew Rybchenko
2019-10-01 15:44 ` [dpdk-dev] [PATCH 2/3] net/virtio: reject deferred start Tx " Andrew Rybchenko
2019-10-08 5:35 ` Tiwei Bie
2019-10-01 15:44 ` [dpdk-dev] [PATCH 3/3] net/virtio: reject unsupported Rx multi queue modes Andrew Rybchenko
2019-10-08 5:46 ` Tiwei Bie
2019-10-09 8:04 ` Andrew Rybchenko [this message]
2019-10-09 8:43 ` Tiwei Bie
2019-10-09 9:00 ` Andrew Rybchenko
2019-10-09 10:41 ` Tiwei Bie
2019-10-09 11:24 ` Andrew Rybchenko
2019-10-10 7:42 ` Thomas Monjalon
2019-10-10 8:13 ` Andrew Rybchenko
2019-10-10 8:23 ` David Marchand
2019-10-10 8:27 ` Andrew Rybchenko
2019-10-10 9:10 ` Tiwei Bie
2019-10-01 16:29 ` [dpdk-dev] [PATCH 1/3] net/virtio: reject deferred start Rx queue setup Kevin Traynor
2019-10-01 16:39 ` Andrew Rybchenko
2019-10-09 12:32 ` [dpdk-dev] [PATCH v2 1/4] " Andrew Rybchenko
2019-10-09 12:32 ` [dpdk-dev] [PATCH v2 2/4] net/virtio: reject deferred start Tx " Andrew Rybchenko
2019-10-24 9:44 ` Maxime Coquelin
2019-10-09 12:32 ` [dpdk-dev] [PATCH v2 3/4] net/virtio: reject unsupported Rx multi queue modes Andrew Rybchenko
2019-10-24 9:44 ` Maxime Coquelin
2019-10-09 12:32 ` [dpdk-dev] [PATCH v2 4/4] net/virtio: reject unsupported Tx " Andrew Rybchenko
2019-10-24 9:44 ` Maxime Coquelin
2019-10-24 9:44 ` [dpdk-dev] [PATCH v2 1/4] net/virtio: reject deferred start Rx queue setup Maxime Coquelin
2019-10-24 10:19 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9e81a56-337e-7116-fc8c-de00635b6181@solarflare.com \
--to=arybchenko@solarflare.com \
--cc=Dilshod.Urazov@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
--cc=tiwei.bie@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).