From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1329CA00B8; Mon, 28 Oct 2019 09:36:20 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E25CE1BEF1; Mon, 28 Oct 2019 09:36:18 +0100 (CET) Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com [209.85.167.66]) by dpdk.org (Postfix) with ESMTP id 377C21BEED for ; Mon, 28 Oct 2019 09:36:18 +0100 (CET) Received: by mail-lf1-f66.google.com with SMTP id y6so7136843lfj.2 for ; Mon, 28 Oct 2019 01:36:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Z2NNrPD8rlarq622dtRyR2w+mKRyyjv63NKmOVJh/No=; b=XrSu7dodJGunBRc4Dro5xnLGXExdOS2Vz0vYmToGOOzBSFzXcnzoLwx4YKQVqCP8/B lqverF06O6NMc7BNPRbMjQo7RuCmdqlkc3oKPITj04Qca8Hb/VvdDXgocVoAP/3ri0+K FK8nJQ9HUMO3zaXE62r5XDv9eviwVjlLwKeyxKMrj4FnKLk4lqfs8pJv8AxnrbEZvlTX bmzGTyzaVmJoeR/rhzf469o3LsCUrajEDVZeHie3K6OO2iPcSXxiGj43ngkl1bez3d8A m97Bk7zsexOONcyjnhicfmQbFaRJokPKoPPEhRXqbJVOnhLn5TWouettg1fxy2uaa/Um IWlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Z2NNrPD8rlarq622dtRyR2w+mKRyyjv63NKmOVJh/No=; b=DCVBiCybkbvgitE4cp9AyC/cE1p/nEguIFhoR9ra0Q5l39dXfQIhL0iXAAkt46YV/2 Lc1iBqWlgo7N0AwyCpeRYXJ5hJHLWMxM7UnxgxADPuU/By18lkpSomBtZid0QQPaS2ER jje7rLwn9g9M1z2glMcQ60TfLN9MtuKO83nVTjyGsX1lHTWOUDo5f05CjonoFHPeYlZ0 m6kp1FeK2kaoSgv1QAB2PRtuXgL9iCoHxFdf+fqrhAsb7TE874uTQUvH3gujGpeWKedl +rk2wzBFVNwbYlRAPv7jgr1tueswQTSfbV2J6Tt5zY+l+nGSGMG8LckaCARNfHx8tByj m0rg== X-Gm-Message-State: APjAAAXM6bN7PS42r97jfBJi8g4euSTcTmAaVCcN+Ax3jc3S88DCX9g5 R9wdtmDADooez5wsz9NXFheaeA== X-Google-Smtp-Source: APXvYqyNLB0U+pWK2crIdSB1QRVjq39NmHumoyrkalcz/XL5bZllAkTVpVJH4cYLM2jhjTMRLOOVEA== X-Received: by 2002:a19:654d:: with SMTP id c13mr10440601lfj.30.1572251777644; Mon, 28 Oct 2019 01:36:17 -0700 (PDT) Received: from [10.0.0.72] (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id l5sm4605681lfk.17.2019.10.28.01.36.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 28 Oct 2019 01:36:16 -0700 (PDT) To: Thomas Monjalon Cc: dev@dpdk.org, Ray Kinsella , Aaron Conole , Michael Santana , John McNamara , Marko Kovacevic , David Hunt , Bruce Richardson , Vladimir Medvedkin , Robert Sanford , Erik Gabriel Carrillo , mattias.ronnblom@ericsson.com, stephen@networkplumber.org References: <20190917075754.8310-1-amo@semihalf.com> <20190917075754.8310-2-amo@semihalf.com> <8ba7ce2f-e687-3e1c-c7ab-7749764e80d8@ashroe.eu> <1775281.ulgepI6dQ0@xps> From: Andrzej Ostruszka Message-ID: Date: Mon, 28 Oct 2019 09:36:15 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <1775281.ulgepI6dQ0@xps> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 01/10] build: add an option to enable LTO build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/27/19 12:31 PM, Thomas Monjalon wrote: > 18/09/2019 15:32, Ray Kinsella: >> this is cool, good work. >> comments below. >> >> On 17/09/2019 08:57, Andrzej Ostruszka wrote: >>> --- a/lib/librte_distributor/rte_distributor.c >>> +++ b/lib/librte_distributor/rte_distributor.c >>> @@ -32,7 +32,7 @@ EAL_REGISTER_TAILQ(rte_dist_burst_tailq) >>> >>> /**** Burst Packet APIs called by workers ****/ >>> >>> -void >>> +void __vsym >> >> all these additional __vsym annotations looks like they belong in a >> seperate patch, as they are fixing a bug and are not directly related to >> adding LTO the build system. > > Andrzej, you did not reply to this question. > This is a real blocker for merging this series. Thomas, thank you for the reminder. Somehow that comment has escaped me - although I've read it then. > Should __vsym addition be in a separate patch? I'm fine both ways. You could argue that: - it is a bug since '__vsym' clearly annotates the function as being used as a particular version of a symbol and as such it was missing - or as a part of enablement for LTO since without it compiler/linker should not be removing given function and '__vsym' really is just a "attribute(used)" to tell optimizing compiler/linker that this function should not be removed. Since you raised that question I'm guessing that you prefer it to be in a separate patch - so, unless you object now, I'm going to split it in the next version and have it as a first patch. > Should we document its use in rte_function_versioning.h > and versioning.rst? Yes, I think so. I'll add that. Again, thank you for the reminder and comments. Regards Andrzej