From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Xia, Chenbo" <chenbo.xia@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"thomas@monjalon.net" <thomas@monjalon.net>
Cc: "mdr@ashroe.eu" <mdr@ashroe.eu>,
"nhorman@tuxdriver.com" <nhorman@tuxdriver.com>,
"david.marchand@redhat.com" <david.marchand@redhat.com>
Subject: Re: [dpdk-dev] [PATCH] doc: announce removal of ABIs in PCI bus driver
Date: Fri, 23 Jul 2021 13:46:58 +0100 [thread overview]
Message-ID: <ca1ad039-b8d9-6442-7fd4-bcf7c50db412@intel.com> (raw)
In-Reply-To: <MN2PR11MB40638A461F9D8E4F7329784F9CE59@MN2PR11MB4063.namprd11.prod.outlook.com>
On 7/23/2021 8:39 AM, Xia, Chenbo wrote:
> Hi,
>
> A gentle ping for comments..
>
>> -----Original Message-----
>> From: dev <dev-bounces@dpdk.org> On Behalf Of Chenbo Xia
>> Sent: Tuesday, June 1, 2021 4:42 PM
>> To: dev@dpdk.org; thomas@monjalon.net
>> Cc: mdr@ashroe.eu; nhorman@tuxdriver.com
>> Subject: [dpdk-dev] [PATCH] doc: announce removal of ABIs in PCI bus driver
>>
>> All ABIs in PCI bus driver, which are defined in rte_buc_pci.h,
>> will be removed and the header will be made internal.
>>
>> Signed-off-by: Chenbo Xia <chenbo.xia@intel.com>
>> ---
>> doc/guides/rel_notes/deprecation.rst | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/doc/guides/rel_notes/deprecation.rst
>> b/doc/guides/rel_notes/deprecation.rst
>> index 9584d6bfd7..b01f46c62e 100644
>> --- a/doc/guides/rel_notes/deprecation.rst
>> +++ b/doc/guides/rel_notes/deprecation.rst
>> @@ -147,3 +147,8 @@ Deprecation Notices
>> * cmdline: ``cmdline`` structure will be made opaque to hide platform-
>> specific
>> content. On Linux and FreeBSD, supported prior to DPDK 20.11,
>> original structure will be kept until DPDK 21.11.
>> +
>> +* pci: To reduce unnecessary ABIs exposed by DPDK bus driver, "rte_bus_pci.h"
>> + will be made internal in 21.11 and macros/data structures/functions defined
>> + in the header will not be considered as ABI anymore. This change is
>> inspired
>> + by the RFC https://patchwork.dpdk.org/project/dpdk/list/?series=17176.
>
> I see there's some ABI improvement work on-going and I think it could be part of
> the work. If it makes sense to you, I'd like some ACKs.
>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
I am for reducing the public ABI as much as possible. How big will the change
be? Is the 'rte_bus_pci.h' used other than './drivers/bus/pci/'?
next prev parent reply other threads:[~2021-07-23 12:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-01 8:41 Chenbo Xia
2021-07-23 7:39 ` Xia, Chenbo
2021-07-23 12:46 ` Ferruh Yigit [this message]
2021-07-26 5:56 ` Xia, Chenbo
2021-07-27 8:44 ` Bruce Richardson
2021-07-28 15:32 ` Andrew Rybchenko
2021-07-31 20:44 ` Thomas Monjalon
2021-08-03 1:52 ` Xia, Chenbo
2021-08-03 8:19 ` Thomas Monjalon
2021-07-27 10:58 ` Ananyev, Konstantin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca1ad039-b8d9-6442-7fd4-bcf7c50db412@intel.com \
--to=ferruh.yigit@intel.com \
--cc=chenbo.xia@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=mdr@ashroe.eu \
--cc=nhorman@tuxdriver.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).